)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"84b0ef0c42fce1336341d8f297c66caeee48bc5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4d1dd3c0_00862f14","updated":"2025-11-23 11:57:07.000000000","message":"I might not understand this, but we have `+ one_glyph` in one return branch, and `+ 1` in the other.  This can\u0027t be both correct.","commit_id":"72e626b7ef8f24bc9841c2e0c77a9849039df50f"}],"src/openvpnserv/interactive.c":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"84b0ef0c42fce1336341d8f297c66caeee48bc5b","unresolved":true,"context_lines":[{"line_number":2214,"context_line":"                {"},{"line_number":2215,"context_line":"                    /* Domain doesn\u0027t fit, bad luck if it\u0027s the first one */"},{"line_number":2216,"context_line":"                    *pos \u003d \u0027\\0\u0027;"},{"line_number":2217,"context_line":"                    *size \u003d converted_size \u003d\u003d 0 ? 0 : converted_size + 1;"},{"line_number":2218,"context_line":"                    return ERROR_MORE_DATA;"},{"line_number":2219,"context_line":"                }"},{"line_number":2220,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"028ab026_9b0f67b5","line":2217,"updated":"2025-11-23 11:57:07.000000000","message":"`+1` or `+ one_glyph`?\n\nThe code 10 lines up does\n\n```\n                        /* This was the last domain */\n                        *pos \u003d \u0027\\0\u0027;\n                        *size +\u003d one_glyph;\n                        return wcslen(domains) ? NO_ERROR : ERROR_FILE_NOT_FOUND;\n```\n\nboth can not be correct at the same time.","commit_id":"72e626b7ef8f24bc9841c2e0c77a9849039df50f"},{"author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"change_message_id":"010f55f3b10da5246fed5ff09ad4ccdaf5156c91","unresolved":false,"context_lines":[{"line_number":2214,"context_line":"                {"},{"line_number":2215,"context_line":"                    /* Domain doesn\u0027t fit, bad luck if it\u0027s the first one */"},{"line_number":2216,"context_line":"                    *pos \u003d \u0027\\0\u0027;"},{"line_number":2217,"context_line":"                    *size \u003d converted_size \u003d\u003d 0 ? 0 : converted_size + 1;"},{"line_number":2218,"context_line":"                    return ERROR_MORE_DATA;"},{"line_number":2219,"context_line":"                }"},{"line_number":2220,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"bf8a5953_96e69ead","line":2217,"in_reply_to":"028ab026_9b0f67b5","updated":"2025-11-23 19:55:42.000000000","message":"The longer I stare at the code, the less I like `one_glyph` as a name, will change it to `glyph_size` to make more sense. Patch on top follows.","commit_id":"72e626b7ef8f24bc9841c2e0c77a9849039df50f"}]}