)]}'
{"id":"openvpn~1391","triplet_id":"openvpn~master~Iabad046c930dd0f38ec50d1c43d8b3288816df7d","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-11-26 11:06:02.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2025-11-26 10:43:01.000000000","reason":"removed on reply"},"1000006":{"account":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"last_update":"2025-11-26 11:06:02.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Iabad046c930dd0f38ec50d1c43d8b3288816df7d","subject":"iservice: return correct size when domains are truncated","status":"MERGED","created":"2025-11-23 06:47:06.000000000","updated":"2025-11-26 11:06:02.000000000","submitted":"2025-11-26 11:06:02.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1391","meta_rev_id":"589050f7ffecb9c5c0c0a2bae7e87d65792b0c85","_number":1391,"virtual_id_number":1391,"owner":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-11-23 06:47:09.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-11-23 06:47:09.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-11-23 11:57:07.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"8ba4d02d23050c556fc69bfae95951af5d8409c3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-11-23 06:47:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"84b0ef0c42fce1336341d8f297c66caeee48bc5b","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-23 11:57:07.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"075a8d93dc936af35615d9ef7a38e4f420007c92","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-11-23 19:47:56.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nCopied Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"010f55f3b10da5246fed5ff09ad4ccdaf5156c91","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-11-23 19:55:42.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"3b93648041e474eb8cee11a7369f8cdaf929c4c7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-11-23 20:04:07.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"fb93b2004210f5b4df87b524891222ae6aeb716d","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-26 10:43:01.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"589050f7ffecb9c5c0c0a2bae7e87d65792b0c85","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-26 11:06:02.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"aeda359efaeae3d2d77f7a89223fa1b5bcac2c90","revisions":{"72e626b7ef8f24bc9841c2e0c77a9849039df50f":{"kind":"REWORK","_number":1,"created":"2025-11-23 06:47:06.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/91/1391/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/91/1391/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1391/1 \u0026\u0026 git checkout -b change-1391 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1391/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1391/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1391/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/91/1391/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1391/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cf0bb5f7b4b97741f5f3e2e68ef9e6ebae90c39f","subject":"iservice: fix calculation of converted domains size"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-23 06:15:18.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-23 06:15:18.000000000","tz":60},"subject":"iservice: return correct size when domains are truncated","message":"iservice: return correct size when domains are truncated\n\nIn case not all domains can be converted in the available buffer, return\nthe size of the already converted domains size plus the second terminating\nzero for the MULTI_SZ.\n\nReported-by: Marc Heuse \u003cmarc@srlabs.de\u003e\nReported-by: stephan@srlabs.de\nChange-Id: Iabad046c930dd0f38ec50d1c43d8b3288816df7d\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"b7016c4cf76225dac34d830fcc3d995ea491e6bf":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-11-23 19:47:56.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/91/1391/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/91/1391/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1391/2 \u0026\u0026 git checkout -b change-1391 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1391/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1391/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1391/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/91/1391/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1391/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"94db1fae5c2d033b9475ba57ce88d3ff30a1d641","subject":"iservice: fix calculation of converted domains size"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-23 06:15:18.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-23 19:47:34.000000000","tz":60},"subject":"iservice: return correct size when domains are truncated","message":"iservice: return correct size when domains are truncated\n\nIn case not all domains can be converted in the available buffer, return\nthe size of the already converted domains size plus the second terminating\nzero for the MULTI_SZ.\n\nReported-by: Marc Heuse \u003cmarc@srlabs.de\u003e\nReported-by: stephan@srlabs.de\nChange-Id: Iabad046c930dd0f38ec50d1c43d8b3288816df7d\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"b8f02791b26b605ee94bd05e3f7201751706570a":{"kind":"REWORK","_number":3,"created":"2025-11-23 20:04:07.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/91/1391/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/91/1391/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1391/3 \u0026\u0026 git checkout -b change-1391 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1391/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1391/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1391/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/91/1391/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1391/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"94db1fae5c2d033b9475ba57ce88d3ff30a1d641","subject":"iservice: fix calculation of converted domains size"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-23 06:15:18.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-23 19:55:30.000000000","tz":60},"subject":"iservice: return correct size when domains are truncated","message":"iservice: return correct size when domains are truncated\n\nIn case not all domains can be converted in the available buffer, return\nthe size of the already converted domains size plus the second terminating\nzero for the MULTI_SZ.\n\nReported-by: Marc Heuse \u003cmarc@srlabs.de\u003e\nReported-by: stephan@srlabs.de\nChange-Id: Iabad046c930dd0f38ec50d1c43d8b3288816df7d\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"aeda359efaeae3d2d77f7a89223fa1b5bcac2c90":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2025-11-26 11:06:02.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/91/1391/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/91/1391/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1391/4 \u0026\u0026 git checkout -b change-1391 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1391/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1391/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1391/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/91/1391/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1391/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ac6c9d65701ed6d41691497846a47cb4e72b2878","subject":"iservice: fix calculation of converted domains size"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-26 10:43:07.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-26 11:02:42.000000000","tz":60},"subject":"iservice: return correct size when domains are truncated","message":"iservice: return correct size when domains are truncated\n\nIn case not all domains can be converted in the available buffer, return\nthe size of the already converted domains size plus the second terminating\nzero for the MULTI_SZ.\n\nReported-by: Marc Heuse \u003cmarc@srlabs.de\u003e\nReported-by: stephan@srlabs.de\nChange-Id: Iabad046c930dd0f38ec50d1c43d8b3288816df7d\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1391\nMessage-Id: \u003c20251126104315.4776-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg34680.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}