)]}'
{"id":"openvpn~1394","triplet_id":"openvpn~master~I02e2c7b27b5a39b11556e4753c648baa05344ffc","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-11-26 11:11:15.000000000","reason":"Change was submitted"},"1000006":{"account":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"last_update":"2025-11-26 11:11:15.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I02e2c7b27b5a39b11556e4753c648baa05344ffc","subject":"iservice: handle ignoring itf domains correctly","status":"MERGED","created":"2025-11-23 06:47:06.000000000","updated":"2025-11-26 11:11:15.000000000","submitted":"2025-11-26 11:11:15.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1394","meta_rev_id":"1242d0a84e7b8d90901d94adbcb5545b88ddee75","_number":1394,"virtual_id_number":1394,"owner":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-11-23 06:47:10.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-11-23 06:47:10.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-11-26 10:46:53.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"517843e18998ca40921c9f70a92d8b377a454ed8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-11-23 06:47:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cffab1b100f31b9cb1b7e4885f65dd36b21118ba","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-11-23 19:47:56.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"2c600a8317fa88aa2e4dada4e8155b56b5f4fab8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-11-23 20:04:07.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"d5150a0ebfa8322c24fc2e635cd2aa55b217e1f0","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-26 10:46:53.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"1242d0a84e7b8d90901d94adbcb5545b88ddee75","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-26 11:11:15.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"c0cb510257ac48d69c39388024beb1e75bee1893","revisions":{"f0a612295f1b7f925f171ecd9d98bd7599eabfea":{"kind":"REWORK","_number":1,"created":"2025-11-23 06:47:06.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/94/1394/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/94/1394/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1394/1 \u0026\u0026 git checkout -b change-1394 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1394/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1394/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1394/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/94/1394/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1394/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"497bc7f8eb8037f2129838786d61fe9f838f34d6","subject":"iservice: check for NULL pointer"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-23 06:37:39.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-23 06:37:39.000000000","tz":60},"subject":"iservice: handle ignoring itf domains correctly","message":"iservice: handle ignoring itf domains correctly\n\nGetItfDnsDomains() does ignore domains, which are in the search domains\nlist. Handling of this was done wrong if there was more than one\ninterface domain. In any case the size returned to the caller was\ncalculated wrong.\n\nReported-by: Marc Heuse \u003cmarc@srlabs.de\u003e\nReported-by: stephan@srlabs.de\nChange-Id: I02e2c7b27b5a39b11556e4753c648baa05344ffc\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"a620545fd791c32526ea782961e6d45f6a803a5c":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-11-23 19:47:56.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/94/1394/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/94/1394/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1394/2 \u0026\u0026 git checkout -b change-1394 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1394/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1394/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1394/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/94/1394/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1394/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b7016c4cf76225dac34d830fcc3d995ea491e6bf","subject":"iservice: return correct size when domains are truncated"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-23 06:37:39.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-23 19:47:34.000000000","tz":60},"subject":"iservice: handle ignoring itf domains correctly","message":"iservice: handle ignoring itf domains correctly\n\nGetItfDnsDomains() does ignore domains, which are in the search domains\nlist. Handling of this was done wrong if there was more than one\ninterface domain. In any case the size returned to the caller was\ncalculated wrong.\n\nReported-by: Marc Heuse \u003cmarc@srlabs.de\u003e\nReported-by: stephan@srlabs.de\nChange-Id: I02e2c7b27b5a39b11556e4753c648baa05344ffc\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"6f2883251736c17dad18bf3bb75373ba3093a15e":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2025-11-23 20:04:07.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/94/1394/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/94/1394/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1394/3 \u0026\u0026 git checkout -b change-1394 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1394/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1394/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1394/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/94/1394/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1394/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b8f02791b26b605ee94bd05e3f7201751706570a","subject":"iservice: return correct size when domains are truncated"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-23 06:37:39.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-23 19:55:34.000000000","tz":60},"subject":"iservice: handle ignoring itf domains correctly","message":"iservice: handle ignoring itf domains correctly\n\nGetItfDnsDomains() does ignore domains, which are in the search domains\nlist. Handling of this was done wrong if there was more than one\ninterface domain. In any case the size returned to the caller was\ncalculated wrong.\n\nReported-by: Marc Heuse \u003cmarc@srlabs.de\u003e\nReported-by: stephan@srlabs.de\nChange-Id: I02e2c7b27b5a39b11556e4753c648baa05344ffc\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"c0cb510257ac48d69c39388024beb1e75bee1893":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2025-11-26 11:11:15.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/94/1394/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/94/1394/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1394/4 \u0026\u0026 git checkout -b change-1394 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1394/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1394/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1394/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/94/1394/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1394/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"aeda359efaeae3d2d77f7a89223fa1b5bcac2c90","subject":"iservice: return correct size when domains are truncated"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-26 10:47:01.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-26 11:07:01.000000000","tz":60},"subject":"iservice: handle ignoring itf domains correctly","message":"iservice: handle ignoring itf domains correctly\n\nGetItfDnsDomains() does ignore domains, which are in the search domains\nlist. Handling of this was done wrong if there was more than one\ninterface domain. In any case the size returned to the caller was\ncalculated wrong.\n\nReported-by: Marc Heuse \u003cmarc@srlabs.de\u003e\nReported-by: stephan@srlabs.de\nChange-Id: I02e2c7b27b5a39b11556e4753c648baa05344ffc\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1394\nMessage-Id: \u003c20251126104706.5378-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg34677.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}