)]}'
{"id":"openvpn~1396","triplet_id":"openvpn~master~Ie66a142751354e421d48b273784fc79bcb9f7208","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-11-24 17:51:14.000000000","reason":"Change was submitted"},"1000006":{"account":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"last_update":"2025-11-24 17:51:14.000000000","reason":"Change was submitted"},"1000009":{"account":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"last_update":"2025-11-24 15:40:43.000000000","reason":"\u003cGERRIT_ACCOUNT_1000009\u003e replied on the change","reason_account":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"}},"1000008":{"account":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2025-11-24 17:51:14.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ie66a142751354e421d48b273784fc79bcb9f7208","subject":"Harden interactive service pipe","status":"MERGED","created":"2025-11-23 18:35:43.000000000","updated":"2025-11-24 17:51:14.000000000","submitted":"2025-11-24 17:51:14.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1396","meta_rev_id":"748e7300f0a55494d83621de2dad798e184ca7e7","_number":1396,"virtual_id_number":1396,"owner":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"}],"CC":[{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-11-23 18:35:44.000000000","updated_by":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-11-23 18:35:44.000000000","updated_by":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-11-23 18:37:05.000000000","updated_by":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"reviewer":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"state":"REVIEWER"},{"updated":"2025-11-24 11:47:29.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"state":"CC"}],"messages":[{"id":"0dcc7bb1465755c034348c8e663bbbde10f3c6a2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2025-11-23 18:35:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a3c56ec7b1e1fc9b4728861fac572b1299ad83b4","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-11-24 08:02:41.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"bf62770e1fd1eb63724450b0941dcb5c63a9d2a1","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-11-24 11:47:29.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"a6824655c9c5ba4772ac327a93ddf6f028fbae8e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2025-11-24 15:40:10.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"6b8bfd6b16457acb92d085cbae2f1a59cab6a0a6","author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2025-11-24 15:40:43.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"748e7300f0a55494d83621de2dad798e184ca7e7","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-24 17:51:14.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"05d0808ee65d68691b0133f5fc3c09bfdba5259d","revisions":{"356870aae06005a079ea57a28ca30bdb22062abc":{"kind":"REWORK","_number":1,"created":"2025-11-23 18:35:43.000000000","uploader":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"ref":"refs/changes/96/1396/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/96/1396/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/96/1396/1 \u0026\u0026 git checkout -b change-1396 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/96/1396/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/96/1396/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/96/1396/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/96/1396/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/96/1396/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6711ffa9990d027f566fea4dcf005a8a0be71f13","subject":"dco_freebsd.c: add D_DCO_DEBUG messages for counters and notifications"}],"author":{"name":"Selva Nair","email":"selva.nair@gmail.com","date":"2025-11-15 19:44:10.000000000","tz":-300},"committer":{"name":"Selva Nair","email":"selva.nair@gmail.com","date":"2025-11-15 20:42:21.000000000","tz":-300},"subject":"Harden interactive service pipe","message":"Harden interactive service pipe\n\n- Append a version 4 uuid to ovpn_pipe_name to make it less\n  predictable\n- Do not allow remote access to the pipe\n\nThis greatly reduces the possibility of a rogue process racing to\nopen the pipe before CreateFile() is called in the worker thread.\n\nAddresses OpenVPN/openvpn-private-issues#83\n\nReported-by: Marc Heuse \u003cmarc@srlabs.de\u003e\nChange-Id: Ie66a142751354e421d48b273784fc79bcb9f7208\nSigned-off-by: Selva Nair \u003cselva.nair@gmail.com\u003e\n"},"branch":"refs/heads/master"},"a3d0e32d6a5931dd5116202e39c0adf21983069f":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-11-24 15:40:10.000000000","uploader":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"ref":"refs/changes/96/1396/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/96/1396/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/96/1396/2 \u0026\u0026 git checkout -b change-1396 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/96/1396/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/96/1396/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/96/1396/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/96/1396/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/96/1396/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6711ffa9990d027f566fea4dcf005a8a0be71f13","subject":"dco_freebsd.c: add D_DCO_DEBUG messages for counters and notifications"}],"author":{"name":"Selva Nair","email":"selva.nair@gmail.com","date":"2025-11-15 19:44:10.000000000","tz":-300},"committer":{"name":"Selva Nair","email":"selva.nair@gmail.com","date":"2025-11-24 15:38:58.000000000","tz":-300},"subject":"Harden interactive service pipe","message":"Harden interactive service pipe\n\n- Append a version 4 uuid to ovpn_pipe_name to make it less\n  predictable\n- Do not allow remote access to the pipe\n\nThis greatly reduces the possibility of a rogue process racing to\nopen the pipe before CreateFile() is called in the worker thread.\n\nReported-by: Marc Heuse \u003cmarc@srlabs.de\u003e\nChange-Id: Ie66a142751354e421d48b273784fc79bcb9f7208\nSigned-off-by: Selva Nair \u003cselva.nair@gmail.com\u003e\n"},"branch":"refs/heads/master"},"05d0808ee65d68691b0133f5fc3c09bfdba5259d":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2025-11-24 17:51:14.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/96/1396/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/96/1396/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/96/1396/3 \u0026\u0026 git checkout -b change-1396 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/96/1396/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/96/1396/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/96/1396/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/96/1396/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/96/1396/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2e2ac94e9cf3d0bdb28339594c8236fa98784967","subject":"iservice: check for NULL pointer"}],"author":{"name":"Selva Nair","email":"selva.nair@gmail.com","date":"2025-11-24 16:53:06.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-24 17:34:51.000000000","tz":60},"subject":"Harden interactive service pipe","message":"Harden interactive service pipe\n\n- Append a version 4 uuid to ovpn_pipe_name to make it less\n  predictable\n- Do not allow remote access to the pipe\n\nThis greatly reduces the possibility of a rogue process racing to\nopen the pipe before CreateFile() is called in the worker thread.\n\nReported-by: Marc Heuse \u003cmarc@srlabs.de\u003e\nChange-Id: Ie66a142751354e421d48b273784fc79bcb9f7208\nSigned-off-by: Selva Nair \u003cselva.nair@gmail.com\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1396\nMessage-Id: \u003c20251124165311.14859-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg34638.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}