)]}'
{"id":"openvpn~1406","triplet_id":"openvpn~master~I80aed8a91259374d4b2b2155a8f47e286f2def75","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-12-11 09:22:01.000000000","reason":"Change was abandoned"},"1000034":{"account":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"last_update":"2025-11-26 21:12:33.000000000","reason":"\u003cGERRIT_ACCOUNT_1000034\u003e replied on the change","reason_account":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"}}},"hashtags":[],"change_id":"I80aed8a91259374d4b2b2155a8f47e286f2def75","subject":"Properly log peer-id in P2P mode","status":"ABANDONED","created":"2025-11-26 13:58:58.000000000","updated":"2025-12-11 09:22:01.000000000","total_comment_count":2,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"f0f797139829eed2237ceb44f3efc1b1367666b3","_number":1406,"virtual_id_number":1406,"owner":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"actions":{},"labels":{"Code-Review":{"disliked":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"all":[{"value":-1,"date":"2025-11-26 18:19:12.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"value":-1,"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-11-26 13:58:59.000000000","updated_by":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-11-26 13:58:59.000000000","updated_by":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"41708009419fd4ed716b6262cdf2aa7594813895","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2025-11-26 13:58:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1ff409b6f629be946fb5905f18c8d22532f93237","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-11-26 18:19:12.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"525e47ffc7adbe31623fbb186cdc92ab6322fe0d","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2025-11-26 21:12:33.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f0f797139829eed2237ceb44f3efc1b1367666b3","tag":"autogenerated:gerrit:abandon","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2025-12-11 09:22:01.000000000","message":"Abandoned\n\n#1089 will fix this.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5b7dcb01ca18252743d13e13723063d14faf77da","revisions":{"5b7dcb01ca18252743d13e13723063d14faf77da":{"kind":"REWORK","_number":1,"created":"2025-11-26 13:58:58.000000000","uploader":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/06/1406/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/06/1406/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1406/1 \u0026\u0026 git checkout -b change-1406 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1406/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1406/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1406/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/06/1406/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1406/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"dd1524c0bd7c7358b39da2fb4911076054736e0a","subject":"iservice: rename one_glyph to glyph_size"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2025-11-26 13:36:19.000000000","tz":60},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2025-11-26 13:58:32.000000000","tz":60},"subject":"Properly log peer-id in P2P mode","message":"Properly log peer-id in P2P mode\n\nAs of now OpenVPN prints o-\u003epeer_id in the deferred\noptions log message, however in P2P mode that field\nis currently always 0 as it gets populated only when\na peer-id is pushed by a server (which doesn\u0027t happen in P2P).\n\nFix this by populate o-\u003epeer_id before loggin it.\n\nChange-Id: I80aed8a91259374d4b2b2155a8f47e286f2def75\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}