)]}'
{"src/openvpn/circ_list.h":[{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"c896f8909ec6dc06c6d29698121b81c737214da2","unresolved":true,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"#define CIRC_LIST_INDEX(obj, index)                                                     \\"},{"line_number":50,"context_line":"    modulo_add((obj)-\u003ex_head, index_verify((index), (obj)-\u003ex_size, __FILE__, __LINE__), \\"},{"line_number":51,"context_line":"               (obj)-\u003ex_cap)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"#define CIRC_LIST_ITEM(obj, index) ((obj)-\u003ex_list[CIRC_LIST_INDEX((obj), (index))])"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":7,"id":"dfc48ec0_ef064244","line":51,"updated":"2026-06-12 14:43:01.000000000","message":"So the array index and the size should be the same type. Before we had int for both. Now we have size_t for the size but still int for the index. \n\nThis leads all kind of very weird (theorectically) corner case bugs when the size can be (theoretically) larger than an index.","commit_id":"c80b7640aab6ada319d989df363df39135c58aad"}],"src/openvpn/packet_id.c":[{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"c896f8909ec6dc06c6d29698121b81c737214da2","unresolved":true,"context_lines":[{"line_number":252,"context_line":"                                p-\u003emax_backtrack_stat);"},{"line_number":253,"context_line":"            }"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"            if (diff \u003e\u003d (packet_id_type)CIRC_LIST_SIZE(p-\u003eseq_list))"},{"line_number":256,"context_line":"            {"},{"line_number":257,"context_line":"                packet_id_debug(D_PID_DEBUG_LOW, p, pin, \"PID_ERR large diff\", diff);"},{"line_number":258,"context_line":"                return false;"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"81055b9d_6bc76950","line":255,"updated":"2026-06-12 14:43:01.000000000","message":"Technically since CIRC_LIST_SIZE is no longer restricted to (int), this now opens up a theoretical problem unless we ensure or ASSERT on CIRC_LIST_SIZE always smaller than INT_MAX.\n\nI think we can ignore this but we might want to add a comment here?","commit_id":"c80b7640aab6ada319d989df363df39135c58aad"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"c896f8909ec6dc06c6d29698121b81c737214da2","unresolved":true,"context_lines":[{"line_number":258,"context_line":"                return false;"},{"line_number":259,"context_line":"            }"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"            {"},{"line_number":262,"context_line":"                const time_t v \u003d CIRC_LIST_ITEM(p-\u003eseq_list, (int)diff);"},{"line_number":263,"context_line":"                if (v \u003d\u003d 0)"},{"line_number":264,"context_line":"                {"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"4a9c0a52_c7040115","line":261,"updated":"2026-06-12 14:43:01.000000000","message":"These brackets are confusing. Can we remove them?","commit_id":"c80b7640aab6ada319d989df363df39135c58aad"}]}