)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"67fb579f56ef101375d845c248d1f4e9f5335b66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a2071914_46365957","updated":"2025-11-28 11:03:13.000000000","message":"configure.ac needs more work. Presumably there should be a CMakeLists.txt patch as well?","commit_id":"47a7ecb1d686907ac2713d0ee246b2e5497331d6"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"efd05d436116bdcfd5b3a4b49fb5a97d60fb4917","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"41ef6d64_4ba33a29","in_reply_to":"30ef90d4_bea1349f","updated":"2025-11-28 16:03:13.000000000","message":"CMake should really use pkg-config for mbedTLS. Not sure why it doesn\u0027t. We can handle that in a separate patch.","commit_id":"47a7ecb1d686907ac2713d0ee246b2e5497331d6"},{"author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"change_message_id":"f67656d9d14c6fa72d4a376ee7c3c69cf7090693","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"30ef90d4_bea1349f","in_reply_to":"a2071914_46365957","updated":"2025-11-28 12:59:22.000000000","message":"CMake doesn\u0027t check the version. I think the approach is, if you have the wrong version, the build will just fail. It does a bunch of feature detection which I have now removed though.","commit_id":"47a7ecb1d686907ac2713d0ee246b2e5497331d6"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"c5ef766703e6ab95c1ad4a47d43d4ce0d5b209ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0468ad64_f886cc75","updated":"2025-11-28 20:28:44.000000000","message":"Please also remove the Ubuntu mbedTLS builds in .github/workflows/build.yml","commit_id":"c3cb49110f91a0c80de47a236abc64b6ca408769"},{"author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"change_message_id":"70472e43abd872d254786d938790e90a39235e70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b20abd75_1bbb02df","in_reply_to":"0468ad64_f886cc75","updated":"2025-11-29 13:10:55.000000000","message":"Done. I\u0027m not familiar with github actions, so I hope this works.","commit_id":"c3cb49110f91a0c80de47a236abc64b6ca408769"}],"configure.ac":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"67fb579f56ef101375d845c248d1f4e9f5335b66","unresolved":true,"context_lines":[{"line_number":995,"context_line":"\tif test -z \"${MBEDTLS_CFLAGS}\" -a -z \"${MBEDTLS_LIBS}\"; then"},{"line_number":996,"context_line":"\t\t# if the user did not explicitly specify flags, try to autodetect"},{"line_number":997,"context_line":"\t\tPKG_CHECK_MODULES([MBEDTLS],"},{"line_number":998,"context_line":"\t\t\t[mbedtls \u003e\u003d 2.0.0 mbedx509 \u003e\u003d 2.0.0 mbedcrypto \u003e\u003d 2.0.0],"},{"line_number":999,"context_line":"\t\t\t[have_mbedtls\u003d\"yes\"],"},{"line_number":1000,"context_line":"\t\t\t[LIBS\u003d\"${LIBS} -lmbedtls -lmbedx509 -lmbedcrypto\"]"},{"line_number":1001,"context_line":"\t\t)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"eeaca2b9_aa9059f4","line":998,"updated":"2025-11-28 11:03:13.000000000","message":"Needs to be updated as well","commit_id":"47a7ecb1d686907ac2713d0ee246b2e5497331d6"},{"author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"change_message_id":"f67656d9d14c6fa72d4a376ee7c3c69cf7090693","unresolved":false,"context_lines":[{"line_number":995,"context_line":"\tif test -z \"${MBEDTLS_CFLAGS}\" -a -z \"${MBEDTLS_LIBS}\"; then"},{"line_number":996,"context_line":"\t\t# if the user did not explicitly specify flags, try to autodetect"},{"line_number":997,"context_line":"\t\tPKG_CHECK_MODULES([MBEDTLS],"},{"line_number":998,"context_line":"\t\t\t[mbedtls \u003e\u003d 2.0.0 mbedx509 \u003e\u003d 2.0.0 mbedcrypto \u003e\u003d 2.0.0],"},{"line_number":999,"context_line":"\t\t\t[have_mbedtls\u003d\"yes\"],"},{"line_number":1000,"context_line":"\t\t\t[LIBS\u003d\"${LIBS} -lmbedtls -lmbedx509 -lmbedcrypto\"]"},{"line_number":1001,"context_line":"\t\t)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"e31ce4eb_9de17423","line":998,"in_reply_to":"eeaca2b9_aa9059f4","updated":"2025-11-28 12:59:22.000000000","message":"Done","commit_id":"47a7ecb1d686907ac2713d0ee246b2e5497331d6"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"67fb579f56ef101375d845c248d1f4e9f5335b66","unresolved":true,"context_lines":[{"line_number":1033,"context_line":""},{"line_number":1034,"context_line":"\tAC_CHECK_FUNCS([mbedtls_ssl_tls_prf mbedtls_ssl_conf_export_keys_ext_cb])"},{"line_number":1035,"context_line":""},{"line_number":1036,"context_line":"\tif test \"x$ac_cv_func_mbedtls_ssl_conf_export_keys_ext_cb\" !\u003d xyes; then"},{"line_number":1037,"context_line":"\t\tAC_CHECK_FUNCS([mbedtls_ssl_set_export_keys_cb])"},{"line_number":1038,"context_line":"\t\tif test \"x$ac_cv_func_mbedtls_ssl_set_export_keys_cb\" !\u003d xyes; then"},{"line_number":1039,"context_line":"\t\t\tAC_CHECK_FUNC([mbedtls_ssl_export_keying_material])"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"247cb35b_86dd2af0","line":1036,"updated":"2025-11-28 11:03:13.000000000","message":"Now that we have the stricter version check, can we get rid of these additional tests?","commit_id":"47a7ecb1d686907ac2713d0ee246b2e5497331d6"},{"author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"change_message_id":"f67656d9d14c6fa72d4a376ee7c3c69cf7090693","unresolved":false,"context_lines":[{"line_number":1033,"context_line":""},{"line_number":1034,"context_line":"\tAC_CHECK_FUNCS([mbedtls_ssl_tls_prf mbedtls_ssl_conf_export_keys_ext_cb])"},{"line_number":1035,"context_line":""},{"line_number":1036,"context_line":"\tif test \"x$ac_cv_func_mbedtls_ssl_conf_export_keys_ext_cb\" !\u003d xyes; then"},{"line_number":1037,"context_line":"\t\tAC_CHECK_FUNCS([mbedtls_ssl_set_export_keys_cb])"},{"line_number":1038,"context_line":"\t\tif test \"x$ac_cv_func_mbedtls_ssl_set_export_keys_cb\" !\u003d xyes; then"},{"line_number":1039,"context_line":"\t\t\tAC_CHECK_FUNC([mbedtls_ssl_export_keying_material])"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"c2576736_b01015cf","line":1036,"in_reply_to":"247cb35b_86dd2af0","updated":"2025-11-28 12:59:22.000000000","message":"Thanks for pointing that out! In version 3, we always have the export_keys_cb version, this let me remove even more code!","commit_id":"47a7ecb1d686907ac2713d0ee246b2e5497331d6"}]}