)]}'
{"id":"openvpn~1417","triplet_id":"openvpn~master~Iffc114939cb37129057e9c4864fae9e09c3c7fe4","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-12-08 14:41:47.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-12-08 14:41:47.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Iffc114939cb37129057e9c4864fae9e09c3c7fe4","subject":"CMake: For VS build, switch from /W2 to /W3","status":"MERGED","created":"2025-12-05 14:48:24.000000000","updated":"2025-12-08 14:41:47.000000000","submitted":"2025-12-08 14:41:47.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1417","meta_rev_id":"28878e5485a49b770387d74c9eba3518e175ac2e","_number":1417,"virtual_id_number":1417,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-12-05 14:48:26.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-12-05 14:48:26.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-12-08 11:34:43.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"d65c221857cb13ac95be3d9101e85f297c947f58","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-12-05 14:48:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"352469bfcc8ede2d3d9d7fe3bb7a22bc493d33bb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-12-05 16:11:04.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"d1d3ac5274363b4251f83fca4422282a2b7674a0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-12-05 17:57:48.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"af8892000bcda8c11392a57d866c95a92b6a7f69","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-12-08 11:34:43.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"28878e5485a49b770387d74c9eba3518e175ac2e","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-12-08 14:41:47.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"9a2420fd63265166d1b60a38e8180aa360473ddc","revisions":{"82910b81ffc14e3cf5e61db93cca41b34314cde5":{"kind":"REWORK","_number":1,"created":"2025-12-05 14:48:24.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/17/1417/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/17/1417/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/17/1417/1 \u0026\u0026 git checkout -b change-1417 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/17/1417/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/17/1417/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/17/1417/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/17/1417/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/17/1417/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"64017e2cee474ec0ba7ca03fa530b6eea7a44338","subject":"Documentation: Various syntax fixes and text improvements"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-12-05 14:47:18.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-12-05 14:47:18.000000000","tz":60},"subject":"CMake: For VS build, document what we\u0027re missing from /W3","message":"CMake: For VS build, document what we\u0027re missing from /W3\n\nBasically -Wconversion and -Wsign-compare, so as expected.\n\nChange-Id: Iffc114939cb37129057e9c4864fae9e09c3c7fe4\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"a053260323cd3d6901ff1ea59cf9955facefd8cb":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-12-05 16:11:04.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/17/1417/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/17/1417/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/17/1417/2 \u0026\u0026 git checkout -b change-1417 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/17/1417/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/17/1417/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/17/1417/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/17/1417/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/17/1417/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"64017e2cee474ec0ba7ca03fa530b6eea7a44338","subject":"Documentation: Various syntax fixes and text improvements"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-12-05 14:47:18.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-12-05 16:10:24.000000000","tz":60},"subject":"CMake: For VS build, document what we\u0027re missing from /W3","message":"CMake: For VS build, document what we\u0027re missing from /W3\n\nBasically -Wconversion and -Wsign-compare, so as expected.\n\nGithub: #382\nChange-Id: Iffc114939cb37129057e9c4864fae9e09c3c7fe4\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"48e13ab1f776c3ffb012fdaa1929c140a7e3d6c8":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2025-12-05 17:57:48.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/17/1417/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/17/1417/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/17/1417/3 \u0026\u0026 git checkout -b change-1417 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/17/1417/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/17/1417/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/17/1417/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/17/1417/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/17/1417/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"64017e2cee474ec0ba7ca03fa530b6eea7a44338","subject":"Documentation: Various syntax fixes and text improvements"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-12-05 14:47:18.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-12-05 17:56:11.000000000","tz":60},"subject":"CMake: For VS build, switch from /W2 to /W3","message":"CMake: For VS build, switch from /W2 to /W3\n\nBut exclude the added checks that currently have failures\nso that we can keep /WX enabled.\nBasically this excludes -Wconversion and -Wsign-compare,\nas expected from our GCC/Clang flags.\n\nGithub: #382\nChange-Id: Iffc114939cb37129057e9c4864fae9e09c3c7fe4\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"9a2420fd63265166d1b60a38e8180aa360473ddc":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2025-12-08 14:41:47.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/17/1417/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/17/1417/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/17/1417/4 \u0026\u0026 git checkout -b change-1417 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/17/1417/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/17/1417/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/17/1417/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/17/1417/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/17/1417/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bd8d03e91a4c5a6bddd16f5871cc3111dac6c274","subject":"Documentation: Various syntax fixes and text improvements"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-12-08 11:36:30.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-12-08 14:17:45.000000000","tz":60},"subject":"CMake: For VS build, switch from /W2 to /W3","message":"CMake: For VS build, switch from /W2 to /W3\n\nBut exclude the added checks that currently have failures\nso that we can keep /WX enabled.\nBasically this excludes -Wconversion and -Wsign-compare,\nas expected from our GCC/Clang flags.\n\nGithub: #382\nChange-Id: Iffc114939cb37129057e9c4864fae9e09c3c7fe4\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1417\nMessage-Id: \u003c20251208113636.9650-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg34876.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}