)]}'
{"id":"openvpn~1418","triplet_id":"openvpn~master~I99a6604fdfc682f9609bfe7672aa78285084dcb9","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-12-08 11:34:02.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2025-12-07 21:05:10.000000000","reason":"removed on reply"},"1000049":{"account":{"_account_id":1000049,"name":"klemens","display_name":"Klemens Nanni","email":"kn@openbsd.org","username":"klemens","status":"OpenBSD, Yandex"},"last_update":"2025-12-08 11:34:02.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I99a6604fdfc682f9609bfe7672aa78285084dcb9","subject":"Prevent crash on invalid server-ipv6 argument","status":"MERGED","created":"2025-12-06 14:09:08.000000000","updated":"2025-12-08 11:34:02.000000000","submitted":"2025-12-08 11:34:02.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1418","meta_rev_id":"0d66ca0ffe78009eb41fa3fb9b83c26ab9f3c18d","_number":1418,"virtual_id_number":1418,"owner":{"_account_id":1000049,"name":"klemens","display_name":"Klemens Nanni","email":"kn@openbsd.org","username":"klemens","status":"OpenBSD, Yandex"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-12-06 14:09:09.000000000","updated_by":{"_account_id":1000049,"name":"klemens","display_name":"Klemens Nanni","email":"kn@openbsd.org","username":"klemens","status":"OpenBSD, Yandex"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-12-06 14:09:09.000000000","updated_by":{"_account_id":1000049,"name":"klemens","display_name":"Klemens Nanni","email":"kn@openbsd.org","username":"klemens","status":"OpenBSD, Yandex"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-12-06 20:54:25.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"80152ed94d65bd2da7e029d418b7ffa54d4fe094","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000049,"name":"klemens","display_name":"Klemens Nanni","email":"kn@openbsd.org","username":"klemens","status":"OpenBSD, Yandex"},"date":"2025-12-06 14:09:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8e7dd426989041710276292d53f9dad7287ed890","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-12-06 20:54:25.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"cc8b4c5b43f7cc215208d07b92617f2395cd57b7","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-12-06 20:57:16.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f295ec24377d3f6af25fdcb3d18167a8d1165cee","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000049,"name":"klemens","display_name":"Klemens Nanni","email":"kn@openbsd.org","username":"klemens","status":"OpenBSD, Yandex"},"date":"2025-12-07 13:30:32.000000000","message":"Patch Set 2: Commit message was updated.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"5beacf1b1f17225068d4d3700db251551de1f416","author":{"_account_id":1000049,"name":"klemens","display_name":"Klemens Nanni","email":"kn@openbsd.org","username":"klemens","status":"OpenBSD, Yandex"},"date":"2025-12-07 13:31:35.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"c614dc9576e52ce7efca1d34ab6c44fa5f17a22c","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-12-07 21:05:10.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"0d66ca0ffe78009eb41fa3fb9b83c26ab9f3c18d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-12-08 11:34:02.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"0ff66c056f951dcf01cf6ccb3e9b21948e5ca5ad","revisions":{"b53d0f46fcf8bcd938814f07e7d769ad8b704f42":{"kind":"REWORK","_number":1,"created":"2025-12-06 14:09:08.000000000","uploader":{"_account_id":1000049,"name":"klemens","display_name":"Klemens Nanni","email":"kn@openbsd.org","username":"klemens","status":"OpenBSD, Yandex"},"ref":"refs/changes/18/1418/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/18/1418/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1418/1 \u0026\u0026 git checkout -b change-1418 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1418/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1418/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1418/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/18/1418/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1418/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4ff746ad87ca5aa7b2058c9332622fc86551c0c8","subject":"Fix dco with null cipher being enabled without auth none"}],"author":{"name":"Klemens Nanni","email":"kn@openbsd.org","date":"2025-12-06 11:57:17.000000000","tz":180},"committer":{"name":"Klemens Nanni","email":"kn@openbsd.org","date":"2025-12-06 14:08:23.000000000","tz":180},"subject":"Prevent crash on invalid server-ipv6 argument","message":"Prevent crash on invalid server-ipv6 argument\n\n`get_addr_generic()` expects `openvpn_getaddrinfo()` to return a newly\nallocated struct, but getaddrinfo(3) failure leaves `*ai \u003d NULL` as-is.\n\nUnlike free(3), freegetaddrinfo(3) requires a valid struct, thus the\nfollowing is enough to trigger a NULL pointer dereference in libc:\n\n```\n$ openvpn --server-ipv6 \u0027\u0027\n2025-12-06 11:59:18 RESOLVE: Cannot resolve host address: :[AF_INET6] (no address associated with name)\nSegmentation fault (core dumped)\n```\n\nGuard against empty `ai`, i.e. failure, like similar code already does:\n\n```\n$ ./openvpn --server-ipv6 \u0027\u0027\n2025-12-06 12:05:11 RESOLVE: Cannot resolve host address: :[AF_INET6] (no address associated with name)\nOptions error: error parsing --server-ipv6 parameter\nUse --help for more information.\n```\n\nSpotted through a configuration typo \"server-ipv6 fd00:/64\" with 2.6.17,\nreproduced with and tested against 2.7rc3 on OpenBSD/amd64 7.8-current.\n\nChange-Id: I99a6604fdfc682f9609bfe7672aa78285084dcb9\nSigned-off-by: Klemens Nanni \u003ckn@openbsd.org\u003e\n"},"branch":"refs/heads/master"},"2454ead2b62f7bd6071f7d9fd46079ad7646e727":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-12-07 13:30:32.000000000","uploader":{"_account_id":1000049,"name":"klemens","display_name":"Klemens Nanni","email":"kn@openbsd.org","username":"klemens","status":"OpenBSD, Yandex"},"ref":"refs/changes/18/1418/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/18/1418/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1418/2 \u0026\u0026 git checkout -b change-1418 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1418/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1418/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1418/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/18/1418/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1418/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4ff746ad87ca5aa7b2058c9332622fc86551c0c8","subject":"Fix dco with null cipher being enabled without auth none"}],"author":{"name":"Klemens Nanni","email":"kn@openbsd.org","date":"2025-12-06 11:57:17.000000000","tz":180},"committer":{"name":"klemens","email":"kn@openbsd.org","date":"2025-12-07 13:30:31.000000000","tz":0},"subject":"Prevent crash on invalid server-ipv6 argument","message":"Prevent crash on invalid server-ipv6 argument\n\n`get_addr_generic()` expects `openvpn_getaddrinfo()` to return a newly\nallocated struct, but getaddrinfo(3) failure leaves `*ai \u003d NULL` as-is.\n\nOn OpenBSD, unlike free(3), freegetaddrinfo(3) requires a valid struct,\nthus callers must check the argument to avoid NULL-deref or double-free:\n\n```\n$ openvpn --server-ipv6 \u0027\u0027\n2025-12-06 11:59:18 RESOLVE: Cannot resolve host address: :[AF_INET6] (no address associated with name)\nSegmentation fault (core dumped)\n```\n\nGuard against empty `ai`, i.e. failure, like similar code already does:\n\n```\n$ ./openvpn --server-ipv6 \u0027\u0027\n2025-12-06 12:05:11 RESOLVE: Cannot resolve host address: :[AF_INET6] (no address associated with name)\nOptions error: error parsing --server-ipv6 parameter\nUse --help for more information.\n```\n\nSpotted through a configuration typo \"server-ipv6 fd00:/64\" with 2.6.17,\nreproduced with and tested against 2.7rc3 on OpenBSD/amd64 7.8-current.\n\n\nNB: Standards are unclear wrt. freeaddrinfo(3)\u0027s NULL handling;\n    Linux, FreeBSD and illumos do check it and thus not crash.\n\nChange-Id: I99a6604fdfc682f9609bfe7672aa78285084dcb9\nSigned-off-by: Klemens Nanni \u003ckn@openbsd.org\u003e\n"},"branch":"refs/heads/master","description":"Edit commit message"},"0ff66c056f951dcf01cf6ccb3e9b21948e5ca5ad":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2025-12-08 11:34:02.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/18/1418/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/18/1418/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1418/3 \u0026\u0026 git checkout -b change-1418 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1418/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1418/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1418/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/18/1418/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1418/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d7c7caa370ad1fff1cd222e2499a77ea792c8a0e","subject":"mbedtls: gracefully exit if certificate file is NULL"}],"author":{"name":"Klemens Nanni","email":"kn@openbsd.org","date":"2025-12-07 21:05:18.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-12-08 11:32:08.000000000","tz":60},"subject":"Prevent crash on invalid server-ipv6 argument","message":"Prevent crash on invalid server-ipv6 argument\n\n`get_addr_generic()` expects `openvpn_getaddrinfo()` to return a newly\nallocated struct, but getaddrinfo(3) failure leaves `*ai \u003d NULL` as-is.\n\nOn OpenBSD, unlike free(3), freegetaddrinfo(3) requires a valid struct,\nthus callers must check the argument to avoid NULL-deref or double-free:\n\n```\n$ openvpn --server-ipv6 \u0027\u0027\n2025-12-06 11:59:18 RESOLVE: Cannot resolve host address: :[AF_INET6] (no address associated with name)\nSegmentation fault (core dumped)\n```\n\nGuard against empty `ai`, i.e. failure, like similar code already does:\n\n```\n$ ./openvpn --server-ipv6 \u0027\u0027\n2025-12-06 12:05:11 RESOLVE: Cannot resolve host address: :[AF_INET6] (no address associated with name)\nOptions error: error parsing --server-ipv6 parameter\nUse --help for more information.\n```\n\nSpotted through a configuration typo \"server-ipv6 fd00:/64\" with 2.6.17,\nreproduced with and tested against 2.7rc3 on OpenBSD/amd64 7.8-current.\n\nNB: Standards are unclear wrt. freeaddrinfo(3)\u0027s NULL handling;\n    Linux, FreeBSD and illumos do check it and thus not crash.\n\nGithub: fixes OpenVPN/openvpn#930\n\nChange-Id: I99a6604fdfc682f9609bfe7672aa78285084dcb9\nSigned-off-by: Klemens Nanni \u003ckn@openbsd.org\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1418\nMessage-Id: \u003c20251207210529.9949-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg34870.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}