)]}'
{"id":"openvpn~1429","triplet_id":"openvpn~master~I6debe8bbedd5a08da417bfee1243a43ef6df7980","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-12-10 09:45:27.000000000","reason":"Change was submitted"},"1000006":{"account":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"last_update":"2025-12-10 09:45:27.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I6debe8bbedd5a08da417bfee1243a43ef6df7980","subject":"iservice: set adapter DNS only with search domains","status":"MERGED","created":"2025-12-09 16:28:13.000000000","updated":"2025-12-10 09:45:27.000000000","submitted":"2025-12-10 09:45:27.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1429","meta_rev_id":"125c5c2cde194e32ad6565f6eadb2c035482927f","_number":1429,"virtual_id_number":1429,"owner":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-12-09 16:28:13.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-12-09 16:28:13.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-12-10 01:41:51.000000000","updated_by":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"reviewer":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"state":"REVIEWER"}],"messages":[{"id":"d1ee81b829a3ef11394117b1896d30806856fb82","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-12-09 16:28:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4cc4d8c9f0c3594a754a5e20a8378f42162210ce","author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2025-12-10 01:41:51.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"125c5c2cde194e32ad6565f6eadb2c035482927f","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-12-10 09:45:27.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"f7afbc511b9d30b27d0b6bbb3ee02dfb1abea646","revisions":{"cee712f363ff559c1d9373235b8a62385c103cd8":{"kind":"REWORK","_number":1,"created":"2025-12-09 16:28:13.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/29/1429/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/29/1429/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1429/1 \u0026\u0026 git checkout -b change-1429 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1429/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1429/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1429/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/29/1429/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1429/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6c7489e2edaeeb60fa2b442e4f33d93bfbbdab11","subject":"tun: Refactor BSD write_tun/read_tun"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-12-09 16:11:46.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-12-09 16:27:52.000000000","tz":60},"subject":"iservice: set adapter DNS only with search domains","message":"iservice: set adapter DNS only with search domains\n\nWith NRPT the adapter name server configuration is not needed\ntheoretically. However DNS config is not showing with traditional\ntools like ipconfig if they are left out. More importantly if\nthere are no DNS servers configured for an adapter the adapter\nspecific search domains are not recognized by the Windows resolver.\n\nHowever, adding the servers to the adapter has the side effect, that\ngeneral look-ups are now also done using this adapter, which might\ncome as unexpected and yield wrong results, if there is some trickery\nhappening with the default DNS, for example.\n\nAs a workaround, set the adapter DNS only when strictly needed.\n\nChange-Id: I6debe8bbedd5a08da417bfee1243a43ef6df7980\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"f7afbc511b9d30b27d0b6bbb3ee02dfb1abea646":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2025-12-10 09:45:27.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/29/1429/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/29/1429/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1429/2 \u0026\u0026 git checkout -b change-1429 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1429/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1429/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1429/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/29/1429/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1429/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a0813a9d219a824196a0bc782bf7af17af027ed6","subject":"Correct documentation for --ns-cert-type"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-12-10 07:29:44.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-12-10 09:28:31.000000000","tz":60},"subject":"iservice: set adapter DNS only with search domains","message":"iservice: set adapter DNS only with search domains\n\nWith NRPT the adapter name server configuration is not needed\ntheoretically. However DNS config is not showing with traditional\ntools like ipconfig if they are left out. More importantly if\nthere are no DNS servers configured for an adapter the adapter\nspecific search domains are not recognized by the Windows resolver.\n\nHowever, adding the servers to the adapter has the side effect, that\ngeneral look-ups are now also done using this adapter, which might\ncome as unexpected and yield wrong results, if there is some trickery\nhappening with the default DNS, for example.\n\nAs a workaround, set the adapter DNS only when strictly needed.\n\nGithub: OpenVPN/openvpn#473\n\nChange-Id: I6debe8bbedd5a08da417bfee1243a43ef6df7980\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\nAcked-by: Selva Nair \u003cselva.nair@gmail.com\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1429\nMessage-Id: \u003c20251210072951.25753-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg34968.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}