)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"change_message_id":"5f75403f2877abfd19041a7f7f670ba2f68365d4","unresolved":true,"context_lines":[{"line_number":20,"context_line":"Fixes https://github.com/OpenVPN/openvpn/issues/228"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Currently works only on Windows, since we do\u0027t have"},{"line_number":23,"context_line":"since peer stats implementation yet for Linux and FreeBSD."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: Ib417b965bc4a2c17b51935b43c9627b106716526"},{"line_number":26,"context_line":"Signed-off-by: Lev Stipakov \u003clev@openvpn.net\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a165450a_8fc22829","line":23,"updated":"2023-03-13 14:25:40.000000000","message":"Extra \"since\"","commit_id":"6f4e0a288284a77a41ca81aa97b53568ca79a53d"},{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"29a0245d477b8b5c67b8d29e50d70923504befd7","unresolved":false,"context_lines":[{"line_number":20,"context_line":"Fixes https://github.com/OpenVPN/openvpn/issues/228"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Currently works only on Windows, since we do\u0027t have"},{"line_number":23,"context_line":"since peer stats implementation yet for Linux and FreeBSD."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: Ib417b965bc4a2c17b51935b43c9627b106716526"},{"line_number":26,"context_line":"Signed-off-by: Lev Stipakov \u003clev@openvpn.net\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b7d67597_4895526e","line":23,"in_reply_to":"a165450a_8fc22829","updated":"2023-03-13 15:03:30.000000000","message":"Ack","commit_id":"6f4e0a288284a77a41ca81aa97b53568ca79a53d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"176912929af113e73e1748e710932a962a13caa2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"98b6c765_bca6c318","updated":"2023-03-15 13:22:32.000000000","message":"Agreed, OTOH that will add a second exit point.","commit_id":"5a23570c7ff5a8d792d5f477014091b1f1fb4f78"}],"src/openvpn/forward.c":[{"author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"change_message_id":"5f75403f2877abfd19041a7f7f670ba2f68365d4","unresolved":true,"context_lines":[{"line_number":724,"context_line":"    if (c-\u003eoptions.inactivity_timeout"},{"line_number":725,"context_line":"        \u0026\u0026 event_timeout_trigger(\u0026c-\u003ec2.inactivity_interval, \u0026c-\u003ec2.timeval, ETT_DEFAULT))"},{"line_number":726,"context_line":"    {"},{"line_number":727,"context_line":"        if (dco_enabled(\u0026c-\u003eoptions) \u0026\u0026 dco_get_peer_stats(c) \u003d\u003d 0)"},{"line_number":728,"context_line":"        {"},{"line_number":729,"context_line":"            int64_t tot_bytes \u003d c-\u003ec2.tun_read_bytes + c-\u003ec2.tun_write_bytes;"},{"line_number":730,"context_line":"            int64_t new_bytes \u003d tot_bytes - c-\u003ec2.inactivity_bytes;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"74b4a79f_799f8733","line":727,"updated":"2023-03-13 14:25:40.000000000","message":"Wouldn\u0027t it be nicer if this code would live in check_inactivity_timeout() instead? If I didn\u0027t miss anything the code accesses only data that is available through the \"c\" pointer, so technically it would be possible.","commit_id":"6f4e0a288284a77a41ca81aa97b53568ca79a53d"},{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"29a0245d477b8b5c67b8d29e50d70923504befd7","unresolved":false,"context_lines":[{"line_number":724,"context_line":"    if (c-\u003eoptions.inactivity_timeout"},{"line_number":725,"context_line":"        \u0026\u0026 event_timeout_trigger(\u0026c-\u003ec2.inactivity_interval, \u0026c-\u003ec2.timeval, ETT_DEFAULT))"},{"line_number":726,"context_line":"    {"},{"line_number":727,"context_line":"        if (dco_enabled(\u0026c-\u003eoptions) \u0026\u0026 dco_get_peer_stats(c) \u003d\u003d 0)"},{"line_number":728,"context_line":"        {"},{"line_number":729,"context_line":"            int64_t tot_bytes \u003d c-\u003ec2.tun_read_bytes + c-\u003ec2.tun_write_bytes;"},{"line_number":730,"context_line":"            int64_t new_bytes \u003d tot_bytes - c-\u003ec2.inactivity_bytes;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d8be0064_8a4a42d7","line":727,"in_reply_to":"74b4a79f_799f8733","updated":"2023-03-13 15:03:30.000000000","message":"Agreed.","commit_id":"6f4e0a288284a77a41ca81aa97b53568ca79a53d"},{"author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"change_message_id":"d6a9355cc5ef397aab2ef42229612066ccadfe0f","unresolved":true,"context_lines":[{"line_number":477,"context_line":"            c-\u003ec2.inactivity_bytes \u003d tot_bytes;"},{"line_number":478,"context_line":"            event_timeout_reset(\u0026c-\u003ec2.inactivity_interval);"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"            trigger_timeout \u003d false;"},{"line_number":481,"context_line":"        }"},{"line_number":482,"context_line":"    }"},{"line_number":483,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"d4dd54e3_6bfc1301","line":480,"updated":"2023-03-15 13:00:01.000000000","message":"A simple `return` here would defeat the need for `trigger_timeout`","commit_id":"b0134f5bb48bf8546313f391083a1084d699b37c"},{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"176912929af113e73e1748e710932a962a13caa2","unresolved":false,"context_lines":[{"line_number":477,"context_line":"            c-\u003ec2.inactivity_bytes \u003d tot_bytes;"},{"line_number":478,"context_line":"            event_timeout_reset(\u0026c-\u003ec2.inactivity_interval);"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"            trigger_timeout \u003d false;"},{"line_number":481,"context_line":"        }"},{"line_number":482,"context_line":"    }"},{"line_number":483,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"41c5d36a_aa0dcab3","line":480,"in_reply_to":"d4dd54e3_6bfc1301","updated":"2023-03-15 13:22:32.000000000","message":"Ack","commit_id":"b0134f5bb48bf8546313f391083a1084d699b37c"}]}