)]}'
{"id":"openvpn~143","triplet_id":"openvpn~release%2F2.6~Ib417b965bc4a2c17b51935b43c9627b106716526","project":"openvpn","branch":"release/2.6","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2023-03-21 09:23:26.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2023-03-21 09:23:26.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2023-03-21 09:23:26.000000000","reason":"Change was submitted"},"1000007":{"account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2023-03-21 09:23:26.000000000","reason":"Change was submitted"},"1000006":{"account":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"last_update":"2023-03-15 13:28:06.000000000","reason":"removed on reply"},"1000008":{"account":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2023-03-21 09:23:26.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ib417b965bc4a2c17b51935b43c9627b106716526","subject":"Support --inactive option for DCO","status":"MERGED","created":"2023-03-13 09:37:55.000000000","updated":"2023-03-21 09:23:26.000000000","submitted":"2023-03-21 09:23:26.000000000","submitter":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"143","meta_rev_id":"d16c3bde65c3c8a990965a1badf046617c2026fc","_number":143,"virtual_id_number":143,"owner":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},{"value":0,"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-03-13 09:42:23.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2023-03-13 09:42:23.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"},{"updated":"2023-03-13 09:42:23.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"state":"REVIEWER"},{"updated":"2023-03-13 09:42:23.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2023-03-13 09:42:23.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"REVIEWER"}],"messages":[{"id":"8ce42ed318ada1cfa85143d6c2b318353cd65cde","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2023-03-13 09:37:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5f75403f2877abfd19041a7f7f670ba2f68365d4","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2023-03-13 14:25:40.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"afa9f8eb937b42add7011932e1a4b4d1e62c8eea","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2023-03-13 15:01:49.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"29a0245d477b8b5c67b8d29e50d70923504befd7","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2023-03-13 15:03:30.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"d6a9355cc5ef397aab2ef42229612066ccadfe0f","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2023-03-15 13:00:01.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"e7a1e6a0686815cf772c01b024057ba787ffc295","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2023-03-15 13:21:18.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"176912929af113e73e1748e710932a962a13caa2","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2023-03-15 13:22:32.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"ccc1749d5b5a8a4ca94d6dcd1cb2c66a53a2c0cf","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2023-03-15 13:28:06.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"d16c3bde65c3c8a990965a1badf046617c2026fc","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2023-03-21 09:23:26.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"fd71bce651d5f606d3c1d430c7c0911fe119f075","revisions":{"6f4e0a288284a77a41ca81aa97b53568ca79a53d":{"kind":"REWORK","_number":1,"created":"2023-03-13 09:37:55.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/43/143/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/43/143/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/143/1 \u0026\u0026 git checkout -b change-143 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/143/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/143/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/143/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/43/143/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/143/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5eb94ce9ef2d4095004a0a3c9dbf3aeae78cf371","subject":"tests/unit_tests: Fix \u0027make distcheck\u0027 with subdir-objects enabled"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2023-02-09 08:50:25.000000000","tz":120},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2023-03-13 09:27:19.000000000","tz":120},"subject":"Support --inactive option for DCO","message":"Support --inactive option for DCO\n\nWhen DCO is in use, userland doesn\u0027t see any traffic\nwhich breaks --inactive option.\n\nFix by adding inactivity check to inactivity timeout\ncallback. Get the cumulative tun bytes count (ping packets\nare excluded) from DCO and compare it to the previous value\nstored in c2.inactivity_bytes. Reset inactivity timer and\nupdate c2.inactivity_bytes if amount of new bytes exceeds\ninactivity_minimum_bytes, otherwise terminate session\ndue to inactivity.\n\nFixes https://github.com/OpenVPN/openvpn/issues/228\n\nCurrently works only on Windows, since we do\u0027t have\nsince peer stats implementation yet for Linux and FreeBSD.\n\nChange-Id: Ib417b965bc4a2c17b51935b43c9627b106716526\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/release/2.6"},"b0134f5bb48bf8546313f391083a1084d699b37c":{"kind":"REWORK","_number":2,"created":"2023-03-13 15:01:49.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/43/143/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/43/143/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/143/2 \u0026\u0026 git checkout -b change-143 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/143/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/143/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/143/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/43/143/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/143/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5eb94ce9ef2d4095004a0a3c9dbf3aeae78cf371","subject":"tests/unit_tests: Fix \u0027make distcheck\u0027 with subdir-objects enabled"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2023-02-09 08:50:25.000000000","tz":120},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2023-03-13 14:59:37.000000000","tz":120},"subject":"Support --inactive option for DCO","message":"Support --inactive option for DCO\n\nWhen DCO is in use, userland doesn\u0027t see any traffic\nwhich breaks --inactive option.\n\nFix by adding inactivity check to inactivity timeout\ncallback. Get the cumulative tun bytes count (ping packets\nare excluded) from DCO and compare it to the previous value\nstored in c2.inactivity_bytes. Reset inactivity timer and\nupdate c2.inactivity_bytes if amount of new bytes exceeds\ninactivity_minimum_bytes, otherwise terminate session\ndue to inactivity.\n\nFixes https://github.com/OpenVPN/openvpn/issues/228\n\nCurrently works only on Windows, since we don\u0027t yet have\nsingle peer stats implementation for Linux and FreeBSD.\n\nChange-Id: Ib417b965bc4a2c17b51935b43c9627b106716526\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/release/2.6"},"5a23570c7ff5a8d792d5f477014091b1f1fb4f78":{"kind":"REWORK","_number":3,"created":"2023-03-15 13:21:18.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/43/143/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/43/143/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/143/3 \u0026\u0026 git checkout -b change-143 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/143/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/143/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/143/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/43/143/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/143/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5eb94ce9ef2d4095004a0a3c9dbf3aeae78cf371","subject":"tests/unit_tests: Fix \u0027make distcheck\u0027 with subdir-objects enabled"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2023-02-09 08:50:25.000000000","tz":120},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2023-03-15 13:16:04.000000000","tz":120},"subject":"Support --inactive option for DCO","message":"Support --inactive option for DCO\n\nWhen DCO is in use, userland doesn\u0027t see any traffic\nwhich breaks --inactive option.\n\nFix by adding inactivity check to inactivity timeout\ncallback. Get the cumulative tun bytes count (ping packets\nare excluded) from DCO and compare it to the previous value\nstored in c2.inactivity_bytes. Reset inactivity timer and\nupdate c2.inactivity_bytes if amount of new bytes exceeds\ninactivity_minimum_bytes, otherwise terminate session\ndue to inactivity.\n\nFixes https://github.com/OpenVPN/openvpn/issues/228\n\nCurrently works only on Windows, since we don\u0027t yet have\nsingle peer stats implementation for Linux and FreeBSD.\n\nChange-Id: Ib417b965bc4a2c17b51935b43c9627b106716526\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/release/2.6"},"fd71bce651d5f606d3c1d430c7c0911fe119f075":{"kind":"REWORK","_number":4,"created":"2023-03-21 09:23:26.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/43/143/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/43/143/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/143/4 \u0026\u0026 git checkout -b change-143 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/143/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/143/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/143/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/43/143/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/143/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f970ad99a1a1f30d091853b111e678dbdc3dede9","subject":"Add a test for signing with certificates in Windows store"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2023-03-15 13:38:08.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2023-03-17 12:10:44.000000000","tz":60},"subject":"Support --inactive option for DCO","message":"Support --inactive option for DCO\n\nWhen DCO is in use, userland doesn\u0027t see any traffic\nwhich breaks --inactive option.\n\nFix by adding inactivity check to inactivity timeout\ncallback. Get the cumulative tun bytes count (ping packets\nare excluded) from DCO and compare it to the previous value\nstored in c2.inactivity_bytes. Reset inactivity timer and\nupdate c2.inactivity_bytes if amount of new bytes exceeds\ninactivity_minimum_bytes, otherwise terminate session\ndue to inactivity.\n\nGithub: Fixes OpenVPN/openvpn#228\n\nCurrently works only on Windows, since we don\u0027t yet have\nsingle peer stats implementation for Linux and FreeBSD.\n\nChange-Id: Ib417b965bc4a2c17b51935b43c9627b106716526\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\nAcked-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\nMessage-Id: \u003c20230315133808.1550-1-lstipakov@gmail.com\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26421.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n(cherry picked from commit 514eefb14ace41a5790e59b81654d1d5eed60670)\n"},"branch":"refs/heads/release/2.6"}},"requirements":[],"submit_records":[],"submit_requirements":[]}