)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"b1a0204a89710b3b74c50e8993c8aecc3aa2a011","unresolved":true,"context_lines":[{"line_number":13,"context_line":"reload is necessary."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Changing it to a pointer will make it more clear that this is shared"},{"line_number":16,"context_line":"and also the CRL being reload multiple times."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I21251a42f94fa1d9de083d2acd95b887658c5760"},{"line_number":19,"context_line":"Signed-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7420438b_56404671","line":16,"updated":"2025-12-11 12:02:38.000000000","message":"\"reloaded\"","commit_id":"6331c44bef30adef338e10001d9502f5c7a51a30"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"ed1fcb7a55c178e4a61bbfb8a3b97b3dab64d267","unresolved":false,"context_lines":[{"line_number":13,"context_line":"reload is necessary."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Changing it to a pointer will make it more clear that this is shared"},{"line_number":16,"context_line":"and also the CRL being reload multiple times."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I21251a42f94fa1d9de083d2acd95b887658c5760"},{"line_number":19,"context_line":"Signed-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fbc7ef23_d8a57d72","line":16,"in_reply_to":"7420438b_56404671","updated":"2025-12-15 16:07:29.000000000","message":"Done","commit_id":"6331c44bef30adef338e10001d9502f5c7a51a30"}],"src/openvpn/init.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"b1a0204a89710b3b74c50e8993c8aecc3aa2a011","unresolved":true,"context_lines":[{"line_number":3126,"context_line":"    {"},{"line_number":3127,"context_line":"        /*"},{"line_number":3128,"context_line":"         * Initialize the OpenSSL library\u0027s global"},{"line_number":3129,"context_line":"         * SSL context. */"},{"line_number":3130,"context_line":"        ASSERT(NULL \u003d\u003d c-\u003ec1.ks.ssl_ctx);"},{"line_number":3131,"context_line":"        c-\u003ec1.ks.ssl_ctx \u003d init_ssl(options, c-\u003ec0 \u0026\u0026 c-\u003ec0-\u003euid_gid_chroot_set);"},{"line_number":3132,"context_line":"        if (!tls_ctx_initialised(c-\u003ec1.ks.ssl_ctx))"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"4b726ecf_b6b6dad8","line":3129,"updated":"2025-12-11 12:02:38.000000000","message":"Please leave `*/` on its own line for consistency","commit_id":"6331c44bef30adef338e10001d9502f5c7a51a30"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"78e8c28e7ca28138c70405e339cc810c6721b659","unresolved":false,"context_lines":[{"line_number":3126,"context_line":"    {"},{"line_number":3127,"context_line":"        /*"},{"line_number":3128,"context_line":"         * Initialize the OpenSSL library\u0027s global"},{"line_number":3129,"context_line":"         * SSL context. */"},{"line_number":3130,"context_line":"        ASSERT(NULL \u003d\u003d c-\u003ec1.ks.ssl_ctx);"},{"line_number":3131,"context_line":"        c-\u003ec1.ks.ssl_ctx \u003d init_ssl(options, c-\u003ec0 \u0026\u0026 c-\u003ec0-\u003euid_gid_chroot_set);"},{"line_number":3132,"context_line":"        if (!tls_ctx_initialised(c-\u003ec1.ks.ssl_ctx))"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"503ce1bd_d2891ac8","line":3129,"in_reply_to":"4b726ecf_b6b6dad8","updated":"2025-12-15 16:06:41.000000000","message":"Done","commit_id":"6331c44bef30adef338e10001d9502f5c7a51a30"}],"src/openvpn/ssl.c":[{"author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"change_message_id":"706bf30d7019359706b1d6f618f985044622322a","unresolved":true,"context_lines":[{"line_number":875,"context_line":"    /*"},{"line_number":876,"context_line":"     * Attempt CRL reload before TLS negotiation. Won\u0027t be performed if"},{"line_number":877,"context_line":"     * the file was not modified since the last reload. This affects"},{"line_number":878,"context_line":"     * all instances sharing the same context"},{"line_number":879,"context_line":"     */"},{"line_number":880,"context_line":"    if (session-\u003eopt-\u003ecrl_file \u0026\u0026 !(session-\u003eopt-\u003essl_flags \u0026 SSLF_CRL_VERIFY_DIR))"},{"line_number":881,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"c2acf41e_4c956f57","line":878,"range":{"start_line":878,"start_character":7,"end_line":878,"end_character":45},"updated":"2025-12-15 10:09:47.000000000","message":"I\u0027m a bit confused here. The point of this change is to make all instances share the same context, right? But \"all instances sharing the same context\" makes me wonder if I misunderstand something, because isn\u0027t that just the same as \"all instances\"?","commit_id":"6331c44bef30adef338e10001d9502f5c7a51a30"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"b1a0204a89710b3b74c50e8993c8aecc3aa2a011","unresolved":true,"context_lines":[{"line_number":875,"context_line":"    /*"},{"line_number":876,"context_line":"     * Attempt CRL reload before TLS negotiation. Won\u0027t be performed if"},{"line_number":877,"context_line":"     * the file was not modified since the last reload. This affects"},{"line_number":878,"context_line":"     * all instances sharing the same context"},{"line_number":879,"context_line":"     */"},{"line_number":880,"context_line":"    if (session-\u003eopt-\u003ecrl_file \u0026\u0026 !(session-\u003eopt-\u003essl_flags \u0026 SSLF_CRL_VERIFY_DIR))"},{"line_number":881,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"a249f13e_f414aad5","line":878,"updated":"2025-12-11 12:02:38.000000000","message":"Please add missing \".\"","commit_id":"6331c44bef30adef338e10001d9502f5c7a51a30"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"78e8c28e7ca28138c70405e339cc810c6721b659","unresolved":false,"context_lines":[{"line_number":875,"context_line":"    /*"},{"line_number":876,"context_line":"     * Attempt CRL reload before TLS negotiation. Won\u0027t be performed if"},{"line_number":877,"context_line":"     * the file was not modified since the last reload. This affects"},{"line_number":878,"context_line":"     * all instances sharing the same context"},{"line_number":879,"context_line":"     */"},{"line_number":880,"context_line":"    if (session-\u003eopt-\u003ecrl_file \u0026\u0026 !(session-\u003eopt-\u003essl_flags \u0026 SSLF_CRL_VERIFY_DIR))"},{"line_number":881,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"ac721aa5_fc4cd00e","line":878,"in_reply_to":"a249f13e_f414aad5","updated":"2025-12-15 16:06:41.000000000","message":"Done","commit_id":"6331c44bef30adef338e10001d9502f5c7a51a30"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"78e8c28e7ca28138c70405e339cc810c6721b659","unresolved":true,"context_lines":[{"line_number":875,"context_line":"    /*"},{"line_number":876,"context_line":"     * Attempt CRL reload before TLS negotiation. Won\u0027t be performed if"},{"line_number":877,"context_line":"     * the file was not modified since the last reload. This affects"},{"line_number":878,"context_line":"     * all instances sharing the same context"},{"line_number":879,"context_line":"     */"},{"line_number":880,"context_line":"    if (session-\u003eopt-\u003ecrl_file \u0026\u0026 !(session-\u003eopt-\u003essl_flags \u0026 SSLF_CRL_VERIFY_DIR))"},{"line_number":881,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"e4e71a9c_3b3e27a7","line":878,"range":{"start_line":878,"start_character":7,"end_line":878,"end_character":45},"in_reply_to":"c2acf41e_4c956f57","updated":"2025-12-15 16:06:41.000000000","message":"yeah. I tried to word it better.","commit_id":"6331c44bef30adef338e10001d9502f5c7a51a30"},{"author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"change_message_id":"0407f66e61cff07a5c964fb9fdd36378135918de","unresolved":false,"context_lines":[{"line_number":875,"context_line":"    /*"},{"line_number":876,"context_line":"     * Attempt CRL reload before TLS negotiation. Won\u0027t be performed if"},{"line_number":877,"context_line":"     * the file was not modified since the last reload. This affects"},{"line_number":878,"context_line":"     * all instances sharing the same context"},{"line_number":879,"context_line":"     */"},{"line_number":880,"context_line":"    if (session-\u003eopt-\u003ecrl_file \u0026\u0026 !(session-\u003eopt-\u003essl_flags \u0026 SSLF_CRL_VERIFY_DIR))"},{"line_number":881,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"a1640a1c_d4ad9269","line":878,"range":{"start_line":878,"start_character":7,"end_line":878,"end_character":45},"in_reply_to":"e4e71a9c_3b3e27a7","updated":"2025-12-16 14:38:21.000000000","message":"That\u0027s better!","commit_id":"6331c44bef30adef338e10001d9502f5c7a51a30"}],"src/openvpn/ssl_common.h":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"b1a0204a89710b3b74c50e8993c8aecc3aa2a011","unresolved":true,"context_lines":[{"line_number":305,"context_line":" */"},{"line_number":306,"context_line":"struct tls_options"},{"line_number":307,"context_line":"{"},{"line_number":308,"context_line":"    /* our master TLS context from which all SSL objects derived,"},{"line_number":309,"context_line":"     * this context is shared between all instances so point"},{"line_number":310,"context_line":"     * the real master context */"},{"line_number":311,"context_line":"    struct tls_root_ctx *ssl_ctx;"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"6d9492a9_d331710c","line":308,"updated":"2025-12-11 12:02:38.000000000","message":"\"are derived\"?","commit_id":"6331c44bef30adef338e10001d9502f5c7a51a30"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"78e8c28e7ca28138c70405e339cc810c6721b659","unresolved":false,"context_lines":[{"line_number":305,"context_line":" */"},{"line_number":306,"context_line":"struct tls_options"},{"line_number":307,"context_line":"{"},{"line_number":308,"context_line":"    /* our master TLS context from which all SSL objects derived,"},{"line_number":309,"context_line":"     * this context is shared between all instances so point"},{"line_number":310,"context_line":"     * the real master context */"},{"line_number":311,"context_line":"    struct tls_root_ctx *ssl_ctx;"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"42a32659_134db4a7","line":308,"in_reply_to":"6d9492a9_d331710c","updated":"2025-12-15 16:06:41.000000000","message":"Done","commit_id":"6331c44bef30adef338e10001d9502f5c7a51a30"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"b1a0204a89710b3b74c50e8993c8aecc3aa2a011","unresolved":true,"context_lines":[{"line_number":306,"context_line":"struct tls_options"},{"line_number":307,"context_line":"{"},{"line_number":308,"context_line":"    /* our master TLS context from which all SSL objects derived,"},{"line_number":309,"context_line":"     * this context is shared between all instances so point"},{"line_number":310,"context_line":"     * the real master context */"},{"line_number":311,"context_line":"    struct tls_root_ctx *ssl_ctx;"},{"line_number":312,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":4,"id":"beee4aac_f65ec234","line":309,"updated":"2025-12-11 12:02:38.000000000","message":"\"points to\"?","commit_id":"6331c44bef30adef338e10001d9502f5c7a51a30"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"78e8c28e7ca28138c70405e339cc810c6721b659","unresolved":false,"context_lines":[{"line_number":306,"context_line":"struct tls_options"},{"line_number":307,"context_line":"{"},{"line_number":308,"context_line":"    /* our master TLS context from which all SSL objects derived,"},{"line_number":309,"context_line":"     * this context is shared between all instances so point"},{"line_number":310,"context_line":"     * the real master context */"},{"line_number":311,"context_line":"    struct tls_root_ctx *ssl_ctx;"},{"line_number":312,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":4,"id":"2e35660d_ac9baf46","line":309,"in_reply_to":"beee4aac_f65ec234","updated":"2025-12-15 16:06:41.000000000","message":"Done","commit_id":"6331c44bef30adef338e10001d9502f5c7a51a30"}]}