)]}'
{"id":"openvpn~1432","triplet_id":"openvpn~master~Icab68a5fd1b6288955f0073179f1ddde1468d951","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-12-12 12:52:59.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-12-12 12:52:59.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Icab68a5fd1b6288955f0073179f1ddde1468d951","subject":"mbuf: Add unit tests","status":"MERGED","created":"2025-12-10 16:24:01.000000000","updated":"2025-12-12 12:52:59.000000000","submitted":"2025-12-12 12:52:59.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1432","meta_rev_id":"26b063e1705d511e73d52264dfe7be61dd9ec6d0","_number":1432,"virtual_id_number":1432,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-12-10 16:24:07.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-12-10 16:24:07.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-12-12 12:03:36.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"5ebbd7b99e18bcbe94c369e0cff84cf124826aa7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-12-10 16:24:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8f68bb7f309335847ec703aa4b065be56c0ec06f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-12-11 12:50:09.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"beeee076e1ac5fc46f69254fb93ce16bd7dba6fb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-12-11 15:42:28.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"6d09e01f641ac5a78e06f15fc8ff8ed41ffe69c4","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-12-12 12:03:36.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"26b063e1705d511e73d52264dfe7be61dd9ec6d0","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-12-12 12:52:59.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"75cc34eccca990a2efbaa02639311def6b2cd70f","revisions":{"af858f45adb1cd07e35b6fe6f76edf3e1e2efb20":{"kind":"REWORK","_number":1,"created":"2025-12-10 16:24:01.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/32/1432/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/32/1432/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1432/1 \u0026\u0026 git checkout -b change-1432 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1432/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1432/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1432/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/32/1432/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1432/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a1b1f104f28f36bbda685d54976ea67bc339c86b","subject":"packet_id: Avoid conversion warnings"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-12-10 16:17:14.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-12-10 16:23:13.000000000","tz":60},"subject":"mbuf: Add unit tests","message":"mbuf: Add unit tests\n\nWhile fixing the conversion warning I was\nsomewhat confused how this works, so added\nUTs to verify I understood it.\n\nChange-Id: Icab68a5fd1b6288955f0073179f1ddde1468d951\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"d97c434ac5a84f503c6df2c5a20fd4f51c8e76ce":{"kind":"REWORK","_number":2,"created":"2025-12-11 12:50:09.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/32/1432/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/32/1432/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1432/2 \u0026\u0026 git checkout -b change-1432 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1432/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1432/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1432/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/32/1432/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1432/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"27a61f124399143067acbaf0931dcb0ad8134a4c","subject":"packet_id: Avoid conversion warnings"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-12-10 16:17:14.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-12-11 12:47:19.000000000","tz":60},"subject":"mbuf: Add unit tests","message":"mbuf: Add unit tests\n\nWhile fixing the conversion warning I was\nsomewhat confused how this works, so added\nUTs to verify I understood it.\n\nv2:\n - disable assert test for MS VS\n - add define for memory-intensive UTs and\n   only enable it by default for CMake builds,\n   so we do not break a lot of builds out there\n   due to memory allocation failures\n\nChange-Id: Icab68a5fd1b6288955f0073179f1ddde1468d951\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"f0318378c65691ccb314ec9e1d7c31e8c96ecbac":{"kind":"REWORK","_number":3,"created":"2025-12-11 15:42:28.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/32/1432/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/32/1432/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1432/3 \u0026\u0026 git checkout -b change-1432 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1432/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1432/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1432/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/32/1432/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1432/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c170d521f2f5e97b54b659dfde184f700224f47b","subject":"buffer: Change limits for array_mult_safe"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-12-10 16:17:14.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-12-11 15:39:42.000000000","tz":60},"subject":"mbuf: Add unit tests","message":"mbuf: Add unit tests\n\nWhile fixing the conversion warning I was\nsomewhat confused how this works, so added\nUTs to verify I understood it.\n\nv2:\n - disable assert test for MS VS\n - add define for memory-intensive UTs and\n   only enable it by default for CMake builds,\n   so we do not break a lot of builds out there\n   due to memory allocation failures\n\nChange-Id: Icab68a5fd1b6288955f0073179f1ddde1468d951\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"75cc34eccca990a2efbaa02639311def6b2cd70f":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2025-12-12 12:52:59.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/32/1432/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/32/1432/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1432/4 \u0026\u0026 git checkout -b change-1432 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1432/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1432/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1432/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/32/1432/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1432/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2b8149a4fe0d73ea0bedf2e282188d55c8511c45","subject":"buffer: Change limits for array_mult_safe"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-12-12 12:03:46.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-12-12 12:52:02.000000000","tz":60},"subject":"mbuf: Add unit tests","message":"mbuf: Add unit tests\n\nWhile fixing the conversion warning I was\nsomewhat confused how this works, so added\nUTs to verify I understood it.\n\nv2:\n - disable assert test for MS VS\n - add define for memory-intensive UTs and\n   only enable it by default for CMake builds,\n   so we do not break a lot of builds out there\n   due to memory allocation failures\n\nChange-Id: Icab68a5fd1b6288955f0073179f1ddde1468d951\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1432\nMessage-Id: \u003c20251212120352.17402-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg35050.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}