)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"469540553ebdf3fbf37e3b2fe01281c0ee8ca138","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"06ee36c0_dfb7406e","updated":"2025-12-11 11:43:51.000000000","message":"please do also remove the\n\n```\n\"${openvpn}\" --genkey secret key.$$\n```\n\netc. from t_lpback.sh then","commit_id":"956997482bf00c1e95e817d212ba1970ca24bcde"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"5e6beef87c1e1ac75a79c501a93b5b7a4d95d9a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ef590ff2_965c430a","in_reply_to":"06ee36c0_dfb7406e","updated":"2025-12-11 11:46:29.000000000","message":"Acknowledged","commit_id":"956997482bf00c1e95e817d212ba1970ca24bcde"},{"author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"change_message_id":"7e09b33aaba467d1fca338544ceda99a79adc2eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"be87d74d_25561fd2","updated":"2025-12-18 14:08:08.000000000","message":"The init function is called now, and I\u0027m ok with this change. I\u0027ll leave the +2 to Frank because he still has an open discussion.","commit_id":"2727ac71de2bd6bfc11c402a1d4ce72bfdbd2b9c"}],"src/openvpn/init.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"f165ea5484a97649f6318e70bd51b04913f8a65a","unresolved":true,"context_lines":[{"line_number":3525,"context_line":"    {"},{"line_number":3526,"context_line":"        do_init_crypto_static(c, flags);"},{"line_number":3527,"context_line":"    }"},{"line_number":3528,"context_line":"    else if (c-\u003eoptions.test_crypto)"},{"line_number":3529,"context_line":"    {"},{"line_number":3530,"context_line":"        do_init_crypto_test(c, flags);"},{"line_number":3531,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"b759d66f_128a83d7","line":3528,"updated":"2025-12-11 11:46:26.000000000","message":"Why not do this test first and remove all handling of test-crypto from do_init_crypto_static?","commit_id":"956997482bf00c1e95e817d212ba1970ca24bcde"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"bcf67d678475dea48b4406588f310698260200bc","unresolved":false,"context_lines":[{"line_number":3525,"context_line":"    {"},{"line_number":3526,"context_line":"        do_init_crypto_static(c, flags);"},{"line_number":3527,"context_line":"    }"},{"line_number":3528,"context_line":"    else if (c-\u003eoptions.test_crypto)"},{"line_number":3529,"context_line":"    {"},{"line_number":3530,"context_line":"        do_init_crypto_test(c, flags);"},{"line_number":3531,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"08f7e7fe_7800d03f","line":3528,"in_reply_to":"133004d8_d3bfcd06","updated":"2025-12-12 10:54:53.000000000","message":"Acknowledged","commit_id":"956997482bf00c1e95e817d212ba1970ca24bcde"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"d7b818e5321dcf4ed26aa9d7c60f913bfb683395","unresolved":true,"context_lines":[{"line_number":3525,"context_line":"    {"},{"line_number":3526,"context_line":"        do_init_crypto_static(c, flags);"},{"line_number":3527,"context_line":"    }"},{"line_number":3528,"context_line":"    else if (c-\u003eoptions.test_crypto)"},{"line_number":3529,"context_line":"    {"},{"line_number":3530,"context_line":"        do_init_crypto_test(c, flags);"},{"line_number":3531,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"133004d8_d3bfcd06","line":3528,"in_reply_to":"b759d66f_128a83d7","updated":"2025-12-11 14:44:20.000000000","message":"So basically to currently still support the old mode that allows to use --secret to manually specify the key. When we remove --secret in OpenVPN 2.8 master brnach it is going away entirely anyway.","commit_id":"956997482bf00c1e95e817d212ba1970ca24bcde"},{"author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"change_message_id":"44935968dc9f0f72394cd2733b31e783f3c77cfe","unresolved":true,"context_lines":[{"line_number":2999,"context_line":""},{"line_number":3000,"context_line":""},{"line_number":3001,"context_line":"static void"},{"line_number":3002,"context_line":"do_init_crypto_test(struct context *c, const unsigned int flags)"},{"line_number":3003,"context_line":"{"},{"line_number":3004,"context_line":"    const struct options *options \u003d \u0026c-\u003eoptions;"},{"line_number":3005,"context_line":"    ASSERT(options-\u003etest_crypto);"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"1c6c2400_8ae3694e","line":3002,"updated":"2025-12-16 11:44:33.000000000","message":"This function isn\u0027t called before do_test_crypto runs.\n\n(Found by colleagues at Sentyron)","commit_id":"8833da78f9b467e98dbf2b5c1e8633576d8b969f"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"7b96fe75e960bdd5ee7767a60c95401bf56fe9c5","unresolved":true,"context_lines":[{"line_number":2999,"context_line":""},{"line_number":3000,"context_line":""},{"line_number":3001,"context_line":"static void"},{"line_number":3002,"context_line":"do_init_crypto_test(struct context *c, const unsigned int flags)"},{"line_number":3003,"context_line":"{"},{"line_number":3004,"context_line":"    const struct options *options \u003d \u0026c-\u003eoptions;"},{"line_number":3005,"context_line":"    ASSERT(options-\u003etest_crypto);"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"5ca3c174_73dab1c5","line":3002,"in_reply_to":"1c6c2400_8ae3694e","updated":"2025-12-17 14:53:16.000000000","message":"You are right. I am not entirely sure why it even worked.","commit_id":"8833da78f9b467e98dbf2b5c1e8633576d8b969f"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"a64a400d67bdcd3d829c0e3cdb11a58cae518e97","unresolved":false,"context_lines":[{"line_number":2999,"context_line":""},{"line_number":3000,"context_line":""},{"line_number":3001,"context_line":"static void"},{"line_number":3002,"context_line":"do_init_crypto_test(struct context *c, const unsigned int flags)"},{"line_number":3003,"context_line":"{"},{"line_number":3004,"context_line":"    const struct options *options \u003d \u0026c-\u003eoptions;"},{"line_number":3005,"context_line":"    ASSERT(options-\u003etest_crypto);"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"c8751373_284a2f3c","line":3002,"in_reply_to":"5ca3c174_73dab1c5","updated":"2025-12-17 14:53:30.000000000","message":"Done","commit_id":"8833da78f9b467e98dbf2b5c1e8633576d8b969f"}],"src/openvpn/options.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"bcf67d678475dea48b4406588f310698260200bc","unresolved":true,"context_lines":[{"line_number":2692,"context_line":"    /*"},{"line_number":2693,"context_line":"     * SSL/TLS mode sanity checks."},{"line_number":2694,"context_line":"     */"},{"line_number":2695,"context_line":"    if (options-\u003etls_server + options-\u003etls_client + (options-\u003eshared_secret_file !\u003d NULL) \u003e 1)"},{"line_number":2696,"context_line":"    {"},{"line_number":2697,"context_line":"        msg(M_USAGE, \"specify only one of --tls-server, --tls-client, or --secret\");"},{"line_number":2698,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"c8f0900d_ef9eff0f","line":2695,"updated":"2025-12-12 10:54:53.000000000","message":"Since test_crypto does not imply shared_secret_file anymore should we add a check here that we do not combine `--test-crypto` with `--tls-*` ?","commit_id":"8833da78f9b467e98dbf2b5c1e8633576d8b969f"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"59ed82d4e075c6d29753deb77277403703daa7c1","unresolved":true,"context_lines":[{"line_number":2692,"context_line":"    /*"},{"line_number":2693,"context_line":"     * SSL/TLS mode sanity checks."},{"line_number":2694,"context_line":"     */"},{"line_number":2695,"context_line":"    if (options-\u003etls_server + options-\u003etls_client + (options-\u003eshared_secret_file !\u003d NULL) \u003e 1)"},{"line_number":2696,"context_line":"    {"},{"line_number":2697,"context_line":"        msg(M_USAGE, \"specify only one of --tls-server, --tls-client, or --secret\");"},{"line_number":2698,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"76bfcbc2_b234d8c7","line":2695,"in_reply_to":"8c44e18c_770dbb08","updated":"2025-12-18 16:25:41.000000000","message":"I\u0027m okay with moving this change to a separate patch. It is not strictly required.","commit_id":"8833da78f9b467e98dbf2b5c1e8633576d8b969f"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"973e55da4f0c927d37ff70e51f4a7af7600f9091","unresolved":true,"context_lines":[{"line_number":2692,"context_line":"    /*"},{"line_number":2693,"context_line":"     * SSL/TLS mode sanity checks."},{"line_number":2694,"context_line":"     */"},{"line_number":2695,"context_line":"    if (options-\u003etls_server + options-\u003etls_client + (options-\u003eshared_secret_file !\u003d NULL) \u003e 1)"},{"line_number":2696,"context_line":"    {"},{"line_number":2697,"context_line":"        msg(M_USAGE, \"specify only one of --tls-server, --tls-client, or --secret\");"},{"line_number":2698,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"8c44e18c_770dbb08","line":2695,"in_reply_to":"c8f0900d_ef9eff0f","updated":"2025-12-15 11:41:40.000000000","message":"I think if we do that we should add it for all the \"standalone\" keys like genkey, show-ciphers, show-tls, show-digest.","commit_id":"8833da78f9b467e98dbf2b5c1e8633576d8b969f"}]}