)]}'
{"id":"openvpn~1442","triplet_id":"openvpn~master~I3f661cf305c52652e430b8d219df5186dd8ea4f7","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-01-14 11:00:37.000000000","reason":"\u003cGERRIT_ACCOUNT_1000003\u003e replied on the change","reason_account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2026-01-14 11:15:01.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I3f661cf305c52652e430b8d219df5186dd8ea4f7","subject":"remove ENABLE_X509ALTUSERNAME conditional","status":"MERGED","created":"2025-12-15 12:00:34.000000000","updated":"2026-01-14 11:15:01.000000000","submitted":"2026-01-14 11:15:01.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1442","meta_rev_id":"d773c63222d61d69778c12f436731dc1316e8609","_number":1442,"virtual_id_number":1442,"owner":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-12-15 12:00:36.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-12-15 12:00:36.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"acf55acead58d19831d24c832d4791476b31a44f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-12-15 12:00:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1dab08d471a7c0b399951a8bef466dbb02a7b2ac","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-01-14 11:00:37.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d773c63222d61d69778c12f436731dc1316e8609","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-01-14 11:15:01.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"faac9681cce54f576eddea4b6389395542c24315","revisions":{"3af540e3c4c44e2c185649661ad899dc70f4c519":{"kind":"REWORK","_number":1,"created":"2025-12-15 12:00:34.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/42/1442/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/42/1442/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1442/1 \u0026\u0026 git checkout -b change-1442 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1442/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1442/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1442/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/42/1442/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1442/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2a9c8a8cd6f50c27a8295a169fd14ccf92ee92ac","subject":"options: Avoid some conversion warnings"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-12-15 11:53:21.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-12-15 12:00:22.000000000","tz":60},"subject":"remove ENABLE_X509ALTUSERNAME conditional","message":"remove ENABLE_X509ALTUSERNAME conditional\n\nThis is one of the #ifdef producing compile-time variants that make the\ncode harder to read and harder to test.  The extra code size due to\nturning it on is marginal.\n\nThe mbedTLS backend does not (yet) support it.  To cope with that,\nadd a minimum function x509_username_field_ext_supported() that always\nreturns \"false\", and omit the --x509-username-field from the help\ntext if ENABLE_CRYPTO_MBEDTLS.  Implement this on another day.\n\nGithub: closes OpenVPN/openvpn#917\n\nChange-Id: I3f661cf305c52652e430b8d219df5186dd8ea4f7\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"faac9681cce54f576eddea4b6389395542c24315":{"kind":"REWORK","_number":2,"created":"2026-01-14 11:15:01.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/42/1442/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/42/1442/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1442/2 \u0026\u0026 git checkout -b change-1442 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1442/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1442/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1442/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/42/1442/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1442/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4a15d4e51ddb58fbc7a2b2369f30e51616a2a591","subject":"Require script-security 2 when using unix: tun"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-01-14 11:04:47.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-01-14 11:13:47.000000000","tz":60},"subject":"remove ENABLE_X509ALTUSERNAME conditional","message":"remove ENABLE_X509ALTUSERNAME conditional\n\nThis is one of the #ifdef producing compile-time variants that make the\ncode harder to read and harder to test.  The extra code size due to\nturning it on is marginal.\n\nThe mbedTLS backend does not (yet) support it.  To cope with that,\nadd a minimum function x509_username_field_ext_supported() that always\nreturns \"false\", and omit the --x509-username-field from the help\ntext if ENABLE_CRYPTO_MBEDTLS.  Implement this on another day.\n\nGithub: closes OpenVPN/openvpn#917\n\nChange-Id: I3f661cf305c52652e430b8d219df5186dd8ea4f7\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1442\nMessage-Id: \u003c20260114110452.4976-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg35237.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}