)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000046,"name":"mandree","email":"matthias.andree@gmx.de","username":"mandree"},"change_message_id":"b209d745eef65afa5ff7ae764ad2e7207f8b86bd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"85d830d7_e4f9da4a","updated":"2025-12-16 19:41:00.000000000","message":"I think the fixes go in the wrong direction.","commit_id":"aa01a9c0bf6a48b79ddc66a65e7dc8ae465a821a"},{"author":{"_account_id":1000046,"name":"mandree","email":"matthias.andree@gmx.de","username":"mandree"},"change_message_id":"cb875d72bcbf077b31419afba699c1f78bb6be51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ee499c48_7f58b643","in_reply_to":"85d830d7_e4f9da4a","updated":"2026-01-16 19:31:32.000000000","message":"Done","commit_id":"aa01a9c0bf6a48b79ddc66a65e7dc8ae465a821a"},{"author":{"_account_id":1000046,"name":"mandree","email":"matthias.andree@gmx.de","username":"mandree"},"change_message_id":"cb875d72bcbf077b31419afba699c1f78bb6be51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0b449e74_e783abcd","updated":"2026-01-16 19:31:32.000000000","message":"the revised version seems OK, but I haven\u0027t compile-time tested it.","commit_id":"0f0e8ed1bfe617ecd46e88f243c4a1d6cc363279"}],"src/openvpn/ssl_verify_openssl.c":[{"author":{"_account_id":1000046,"name":"mandree","email":"matthias.andree@gmx.de","username":"mandree"},"change_message_id":"b209d745eef65afa5ff7ae764ad2e7207f8b86bd","unresolved":true,"context_lines":[{"line_number":675,"context_line":"}"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"result_t"},{"line_number":678,"context_line":"x509_verify_cert_ku(X509 *x509, const unsigned *const expected_ku, int expected_len)"},{"line_number":679,"context_line":"{"},{"line_number":680,"context_line":"    ASN1_BIT_STRING *ku \u003d X509_get_ext_d2i(x509, NID_key_usage, NULL, NULL);"},{"line_number":681,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"821e73fa_f775f9c3","line":678,"updated":"2025-12-16 19:41:00.000000000","message":"expected_len might be an unsigned int or size_t to fix warnings below.","commit_id":"aa01a9c0bf6a48b79ddc66a65e7dc8ae465a821a"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"bdab3a3efe16a7ab8059cfe860483c8324af7da2","unresolved":false,"context_lines":[{"line_number":675,"context_line":"}"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"result_t"},{"line_number":678,"context_line":"x509_verify_cert_ku(X509 *x509, const unsigned *const expected_ku, int expected_len)"},{"line_number":679,"context_line":"{"},{"line_number":680,"context_line":"    ASN1_BIT_STRING *ku \u003d X509_get_ext_d2i(x509, NID_key_usage, NULL, NULL);"},{"line_number":681,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"daf21b8d_ebd343a0","line":678,"in_reply_to":"821e73fa_f775f9c3","updated":"2025-12-17 14:26:05.000000000","message":"Done","commit_id":"aa01a9c0bf6a48b79ddc66a65e7dc8ae465a821a"},{"author":{"_account_id":1000046,"name":"mandree","email":"matthias.andree@gmx.de","username":"mandree"},"change_message_id":"b209d745eef65afa5ff7ae764ad2e7207f8b86bd","unresolved":true,"context_lines":[{"line_number":693,"context_line":"    }"},{"line_number":694,"context_line":""},{"line_number":695,"context_line":"    unsigned int nku \u003d 0;"},{"line_number":696,"context_line":"    for (int i \u003d 0; i \u003c 8; i++)"},{"line_number":697,"context_line":"    {"},{"line_number":698,"context_line":"        if (ASN1_BIT_STRING_get_bit(ku, i))"},{"line_number":699,"context_line":"        {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d6e1387e_3213e9eb","line":696,"updated":"2025-12-16 19:41:00.000000000","message":"I don\u0027t seem to have the ASN1_BIT_STRING_get_bit() manpage handy, but if the compiler is unhappy about the nku |\u003d line, make the literals unsigned, as in nku |\u003d 1u \u003c\u003c (7u - i) while i is some unsigned type (such as size_t).","commit_id":"aa01a9c0bf6a48b79ddc66a65e7dc8ae465a821a"},{"author":{"_account_id":1000046,"name":"mandree","email":"matthias.andree@gmx.de","username":"mandree"},"change_message_id":"c3db9f170d945716f7d563149f2371ad3e055251","unresolved":false,"context_lines":[{"line_number":693,"context_line":"    }"},{"line_number":694,"context_line":""},{"line_number":695,"context_line":"    unsigned int nku \u003d 0;"},{"line_number":696,"context_line":"    for (int i \u003d 0; i \u003c 8; i++)"},{"line_number":697,"context_line":"    {"},{"line_number":698,"context_line":"        if (ASN1_BIT_STRING_get_bit(ku, i))"},{"line_number":699,"context_line":"        {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c27d7464_b4c44732","line":696,"in_reply_to":"d6e1387e_3213e9eb","updated":"2025-12-16 19:46:58.000000000","message":"\u003e I don\u0027t seem to have the ASN1_BIT_STRING_get_bit() manpage handy, but if the compiler is unhappy about the nku |\u003d line, make the literals unsigned, as in nku |\u003d 1u \u003c\u003c (7u - i) while i is some unsigned type (such as size_t).\nSo the 2nd argument to ASN1_BIT_STRING_get_bit() wants to be a literal \"int\" so this one change in the \"for\" would be OK.","commit_id":"aa01a9c0bf6a48b79ddc66a65e7dc8ae465a821a"},{"author":{"_account_id":1000046,"name":"mandree","email":"matthias.andree@gmx.de","username":"mandree"},"change_message_id":"b209d745eef65afa5ff7ae764ad2e7207f8b86bd","unresolved":true,"context_lines":[{"line_number":711,"context_line":""},{"line_number":712,"context_line":"    msg(D_HANDSHAKE, \"Validating certificate key usage\");"},{"line_number":713,"context_line":"    result_t fFound \u003d FAILURE;"},{"line_number":714,"context_line":"    for (int i \u003d 0; fFound !\u003d SUCCESS \u0026\u0026 i \u003c expected_len; i++)"},{"line_number":715,"context_line":"    {"},{"line_number":716,"context_line":"        if (expected_ku[i] !\u003d 0 \u0026\u0026 (nku \u0026 expected_ku[i]) \u003d\u003d expected_ku[i])"},{"line_number":717,"context_line":"        {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"253f9ee2_e2908373","line":714,"updated":"2025-12-16 19:41:00.000000000","message":"If this triggers a signed/unsigned mismatch on the \u003c - that\u0027s because the iterator was a size_t and the expected_len argument a signed plain \"int\".","commit_id":"aa01a9c0bf6a48b79ddc66a65e7dc8ae465a821a"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"bdab3a3efe16a7ab8059cfe860483c8324af7da2","unresolved":false,"context_lines":[{"line_number":711,"context_line":""},{"line_number":712,"context_line":"    msg(D_HANDSHAKE, \"Validating certificate key usage\");"},{"line_number":713,"context_line":"    result_t fFound \u003d FAILURE;"},{"line_number":714,"context_line":"    for (int i \u003d 0; fFound !\u003d SUCCESS \u0026\u0026 i \u003c expected_len; i++)"},{"line_number":715,"context_line":"    {"},{"line_number":716,"context_line":"        if (expected_ku[i] !\u003d 0 \u0026\u0026 (nku \u0026 expected_ku[i]) \u003d\u003d expected_ku[i])"},{"line_number":717,"context_line":"        {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c6d817b4_b71d7230","line":714,"in_reply_to":"253f9ee2_e2908373","updated":"2025-12-17 14:26:05.000000000","message":"Done","commit_id":"aa01a9c0bf6a48b79ddc66a65e7dc8ae465a821a"},{"author":{"_account_id":1000046,"name":"mandree","email":"matthias.andree@gmx.de","username":"mandree"},"change_message_id":"b209d745eef65afa5ff7ae764ad2e7207f8b86bd","unresolved":true,"context_lines":[{"line_number":722,"context_line":"    if (fFound !\u003d SUCCESS)"},{"line_number":723,"context_line":"    {"},{"line_number":724,"context_line":"        msg(D_TLS_ERRORS, \"ERROR: Certificate has key usage %04x, expected one of:\", nku);"},{"line_number":725,"context_line":"        for (int i \u003d 0; i \u003c expected_len \u0026\u0026 expected_ku[i]; i++)"},{"line_number":726,"context_line":"        {"},{"line_number":727,"context_line":"            msg(D_TLS_ERRORS, \" * %04x\", expected_ku[i]);"},{"line_number":728,"context_line":"        }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"360f53ad_26945225","line":725,"updated":"2025-12-16 19:41:00.000000000","message":"If this triggers a signed/unsigned mismatch on the \u003c - that\u0027s because the iterator was a size_t and the expected_len argument a signed plain \"int\".","commit_id":"aa01a9c0bf6a48b79ddc66a65e7dc8ae465a821a"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"bdab3a3efe16a7ab8059cfe860483c8324af7da2","unresolved":false,"context_lines":[{"line_number":722,"context_line":"    if (fFound !\u003d SUCCESS)"},{"line_number":723,"context_line":"    {"},{"line_number":724,"context_line":"        msg(D_TLS_ERRORS, \"ERROR: Certificate has key usage %04x, expected one of:\", nku);"},{"line_number":725,"context_line":"        for (int i \u003d 0; i \u003c expected_len \u0026\u0026 expected_ku[i]; i++)"},{"line_number":726,"context_line":"        {"},{"line_number":727,"context_line":"            msg(D_TLS_ERRORS, \" * %04x\", expected_ku[i]);"},{"line_number":728,"context_line":"        }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f6912297_5457cc36","line":725,"in_reply_to":"360f53ad_26945225","updated":"2025-12-17 14:26:05.000000000","message":"Done","commit_id":"aa01a9c0bf6a48b79ddc66a65e7dc8ae465a821a"}]}
