)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"ed0699a34d0cb737ffc9fb779986f796f024a63c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c761f621_6fb228fe","updated":"2026-01-08 17:27:48.000000000","message":"Two comments, and I really think Heiko should have a look at these changes.","commit_id":"79d6ba3cfc1202b03e929ac185135b95699e908c"}],"src/openvpnserv/interactive.c":[{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"ed0699a34d0cb737ffc9fb779986f796f024a63c","unresolved":true,"context_lines":[{"line_number":1388,"context_line":" *"},{"line_number":1389,"context_line":" */"},{"line_number":1390,"context_line":"static DWORD"},{"line_number":1391,"context_line":"RegWStringLength(PCWSTR string)"},{"line_number":1392,"context_line":"{"},{"line_number":1393,"context_line":"    size_t length \u003d (wcslen(string) + 1) * sizeof(wchar_t);"},{"line_number":1394,"context_line":"    if (length \u003e UINT_MAX)"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"55b31c70_6a63bb5f","line":1391,"updated":"2026-01-08 17:27:48.000000000","message":"I\u0027d suggest to name that `RegWStringSize()` - d12fk has tried to make everything that is a \"number of bytes in memory\" named \"xxxsize\", and everything that is \"length of glyphs in a whatever-string\" a \"xxxlength\".  So this would be a \"size\" function.\n\n(Also for `length` inside the function, as soon as `wcslen()` is multiplied it\u0027s not longer a \"length\" in that terminology)","commit_id":"79d6ba3cfc1202b03e929ac185135b95699e908c"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"7e416778799de0396a13c8a3c037f0a4ab34fb6f","unresolved":false,"context_lines":[{"line_number":1388,"context_line":" *"},{"line_number":1389,"context_line":" */"},{"line_number":1390,"context_line":"static DWORD"},{"line_number":1391,"context_line":"RegWStringLength(PCWSTR string)"},{"line_number":1392,"context_line":"{"},{"line_number":1393,"context_line":"    size_t length \u003d (wcslen(string) + 1) * sizeof(wchar_t);"},{"line_number":1394,"context_line":"    if (length \u003e UINT_MAX)"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"cb480e29_6a268e34","line":1391,"in_reply_to":"55b31c70_6a63bb5f","updated":"2026-01-09 12:56:27.000000000","message":"Done","commit_id":"79d6ba3cfc1202b03e929ac185135b95699e908c"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"ed0699a34d0cb737ffc9fb779986f796f024a63c","unresolved":true,"context_lines":[{"line_number":1741,"context_line":" *"},{"line_number":1742,"context_line":" * @return NO_ERROR on success, a Windows error code otherwise"},{"line_number":1743,"context_line":" */"},{"line_number":1744,"context_line":"static LSTATUS"},{"line_number":1745,"context_line":"SetNameServersValue(PCWSTR itf_id, short family, PCSTR value)"},{"line_number":1746,"context_line":"{"},{"line_number":1747,"context_line":"    DWORD err;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"6dd9276d_710aa1d2","line":1744,"updated":"2026-01-08 17:27:48.000000000","message":"why is that change?  We have a `DWORD err` and return that?","commit_id":"79d6ba3cfc1202b03e929ac185135b95699e908c"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"7e416778799de0396a13c8a3c037f0a4ab34fb6f","unresolved":false,"context_lines":[{"line_number":1741,"context_line":" *"},{"line_number":1742,"context_line":" * @return NO_ERROR on success, a Windows error code otherwise"},{"line_number":1743,"context_line":" */"},{"line_number":1744,"context_line":"static LSTATUS"},{"line_number":1745,"context_line":"SetNameServersValue(PCWSTR itf_id, short family, PCSTR value)"},{"line_number":1746,"context_line":"{"},{"line_number":1747,"context_line":"    DWORD err;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"591009df_dff70458","line":1744,"in_reply_to":"6dd9276d_710aa1d2","updated":"2026-01-09 12:56:27.000000000","message":"Yeah, I started cleaning up DWORD vs LSTATUS. But didn\u0027t really finish it. Also not relevant right now since they are the same size, only differ in signedness. So removing all these changes and deferring them to later.","commit_id":"79d6ba3cfc1202b03e929ac185135b95699e908c"},{"author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"change_message_id":"954a88e3736fa9f5857413e181e13ce1f21cc90c","unresolved":true,"context_lines":[{"line_number":1384,"context_line":"}"},{"line_number":1385,"context_line":""},{"line_number":1386,"context_line":"/**"},{"line_number":1387,"context_line":" * Return correct length for regex value to set for string"},{"line_number":1388,"context_line":" *"},{"line_number":1389,"context_line":" */"},{"line_number":1390,"context_line":"static DWORD"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"0e9049bb_dd642e67","line":1387,"updated":"2026-01-19 20:57:18.000000000","message":"I think you mean Registry not Regex","commit_id":"20b33916808e4c049ce3470ace371f91b7638dc4"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"d867c5637a50e9948ab2a74128f1c66549b51ccc","unresolved":false,"context_lines":[{"line_number":1384,"context_line":"}"},{"line_number":1385,"context_line":""},{"line_number":1386,"context_line":"/**"},{"line_number":1387,"context_line":" * Return correct length for regex value to set for string"},{"line_number":1388,"context_line":" *"},{"line_number":1389,"context_line":" */"},{"line_number":1390,"context_line":"static DWORD"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"834b3ca5_a2c05ba2","line":1387,"in_reply_to":"0e9049bb_dd642e67","updated":"2026-01-20 12:00:27.000000000","message":"Done","commit_id":"20b33916808e4c049ce3470ace371f91b7638dc4"}]}
