)]}'
{"id":"openvpn~1464","triplet_id":"openvpn~master~I789022af7c4977c4dff4f7671f491fe5836828fa","project":"openvpn","branch":"master","topic":"wconversion","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-01-19 11:40:38.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-01-19 11:40:38.000000000","reason":"Change was submitted"}},"hashtags":["mailsubmitted"],"change_id":"I789022af7c4977c4dff4f7671f491fe5836828fa","subject":"cryptoapi: Avoid conversion warnings","status":"MERGED","created":"2026-01-12 13:26:55.000000000","updated":"2026-01-19 11:40:38.000000000","submitted":"2026-01-19 11:40:38.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1464-wconversion","meta_rev_id":"dfa9f06a2fae216ce8badbed3c9cead51bbbe3ae","_number":1464,"virtual_id_number":1464,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-01-12 13:26:56.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-01-12 13:26:56.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-01-15 08:55:40.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"},{"updated":"2026-01-15 16:20:44.000000000","updated_by":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"reviewer":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"state":"REVIEWER"}],"messages":[{"id":"a1a8747005ba5245bf66bf149d3a2a498bb790b5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-01-12 13:26:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"58d3e7b6dc8f41f8b6b253035706a11828111032","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-01-15 08:55:40.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"fe3475f4349586bed395beb47091f1ba8ded03dc","author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2026-01-15 16:20:44.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"cd078ea4e7801cd540ab26b1d548cf054754ec9b","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-01-16 13:57:43.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":1},{"id":"dfa9f06a2fae216ce8badbed3c9cead51bbbe3ae","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-01-19 11:40:38.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"2ece9a5df5ed14ca4beb026eef0687f448322245","revisions":{"18f375662efce41b95146f0883b10cde19fc7657":{"kind":"REWORK","_number":1,"created":"2026-01-12 13:26:55.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/64/1464/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/64/1464/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1464/1 \u0026\u0026 git checkout -b change-1464 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1464/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1464/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1464/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/64/1464/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1464/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"626289334f79feed863a06079c3911455b8dc0ac","subject":"openvpnserv: Add a first unit test"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-12 13:17:48.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-12 13:17:48.000000000","tz":60},"subject":"cryptoapi: Avoid conversion warnings","message":"cryptoapi: Avoid conversion warnings\n\nDue to the differences in the types of APIs\nbetween xkey provider and Windows cryptoapi\nwe can\u0027t avoid the casts. And they should be\nsafe generally since the involved sizes should\nbe small compared to the maximum values. So\njust add asserts and explicit cast to avoid\nthe warnings.\n\nChange-Id: I789022af7c4977c4dff4f7671f491fe5836828fa\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"2ece9a5df5ed14ca4beb026eef0687f448322245":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2026-01-19 11:40:38.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/64/1464/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/64/1464/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1464/2 \u0026\u0026 git checkout -b change-1464 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1464/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1464/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1464/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/64/1464/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1464/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"07fc73025b8679540c9964853e9ca47ff385abc8","subject":"crypto_openssl: Fix various conversion warnings"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-16 13:57:29.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-01-19 11:38:50.000000000","tz":60},"subject":"cryptoapi: Avoid conversion warnings","message":"cryptoapi: Avoid conversion warnings\n\nDue to the differences in the types of APIs\nbetween xkey provider and Windows cryptoapi\nwe can\u0027t avoid the casts. And they should be\nsafe generally since the involved sizes should\nbe small compared to the maximum values. So\njust add asserts and explicit cast to avoid\nthe warnings.\n\nChange-Id: I789022af7c4977c4dff4f7671f491fe5836828fa\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Selva Nair \u003cselva.nair@gmail.com\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1464\nMessage-Id: \u003c20260116135729.40545-1-frank@lichtenheld.com\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg35304.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
