)]}'
{"id":"openvpn~1466","triplet_id":"openvpn~master~I13b411fb3e8b913ae049c6ca8a1cf5a2edbab0fb","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-01-13 07:23:25.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-01-13 07:23:25.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I13b411fb3e8b913ae049c6ca8a1cf5a2edbab0fb","subject":"socks: Fix wrong success check in socks_username_password_auth","status":"MERGED","created":"2026-01-12 14:19:21.000000000","updated":"2026-01-13 07:23:25.000000000","submitted":"2026-01-13 07:23:25.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1466","meta_rev_id":"a29613efd2ac22011d701ecbd90f18e87cc8472d","_number":1466,"virtual_id_number":1466,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-01-12 14:19:22.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-01-12 14:19:22.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-01-12 18:02:48.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"3ee8ca56899c9ab0e63913409f9f264c8cd7f27f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-01-12 14:19:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d4e80af4d1a015034d4c6b3e41cf331d6b93da5f","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-01-12 18:02:48.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"a29613efd2ac22011d701ecbd90f18e87cc8472d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-01-13 07:23:25.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d104917e34be43890a86c532329780037e419085","revisions":{"72d1ea166f7745d5ffb32dac4eabc0893a97d664":{"kind":"REWORK","_number":1,"created":"2026-01-12 14:19:21.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/66/1466/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/66/1466/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1466/1 \u0026\u0026 git checkout -b change-1466 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1466/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1466/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1466/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/66/1466/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1466/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"50a6b663e49410456ef6497346dc4ec149d50b0b","subject":"configure.ac: Clean up systemd support"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-12 13:34:43.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-12 14:18:07.000000000","tz":60},"subject":"socks: Fix wrong success check in socks_username_password_auth","message":"socks: Fix wrong success check in socks_username_password_auth\n\nDue to wrong boolean operator the function did not\ncorrectly detect when the authentication failed.\n\nReported-By: Joshua Rogers \u003ccontact@joshua.hu\u003e\nFound-By: ZeroPath (https://zeropath.com)\nGithub: openvpn-private-issues#4\nChange-Id: I13b411fb3e8b913ae049c6ca8a1cf5a2edbab0fb\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"d104917e34be43890a86c532329780037e419085":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2026-01-13 07:23:25.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/66/1466/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/66/1466/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1466/2 \u0026\u0026 git checkout -b change-1466 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1466/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1466/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1466/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/66/1466/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1466/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e2d0e856061d43eabd8010070b456a10052b4e2b","subject":"socks: Replace magic \"10\" for socks header with macro"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-12 18:02:56.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-01-13 07:19:45.000000000","tz":60},"subject":"socks: Fix wrong success check in socks_username_password_auth","message":"socks: Fix wrong success check in socks_username_password_auth\n\nDue to wrong boolean operator the function did not\ncorrectly detect when the authentication failed.\n\nReported-By: Joshua Rogers \u003ccontact@joshua.hu\u003e\nFound-By: ZeroPath (https://zeropath.com)\nGithub: openvpn-private-issues#4\nChange-Id: I13b411fb3e8b913ae049c6ca8a1cf5a2edbab0fb\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1466\nMessage-Id: \u003c20260112180304.8742-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg35219.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}