)]}'
{"id":"openvpn~1469","triplet_id":"openvpn~master~Ic1c8f24de423541bdc85e70b5a688213800d86de","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-01-14 18:40:44.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-01-14 18:40:44.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ic1c8f24de423541bdc85e70b5a688213800d86de","subject":"socks: In establish_socks_proxy_udpassoc check result of recv_socks_reply","status":"MERGED","created":"2026-01-13 12:43:59.000000000","updated":"2026-01-14 18:40:44.000000000","submitted":"2026-01-14 18:40:44.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1469","meta_rev_id":"d41aaceacaa9545a43c7b03539cd47f3c9dff2ad","_number":1469,"virtual_id_number":1469,"owner":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-01-13 12:43:59.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-01-13 12:43:59.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-01-14 13:57:54.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"2e54f5c81ea3ad46f2b35606bfc89a45b8682507","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-01-13 12:43:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f77c07db0283ae7d7067a3366c4f65265ec8b6f5","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-01-14 13:57:54.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"d41aaceacaa9545a43c7b03539cd47f3c9dff2ad","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-01-14 18:40:44.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b2cc5c2ec49c3cfc428f0ecef9684ac318845a84","revisions":{"3266769211d17d398f4339046c0c6cde38c2185c":{"kind":"REWORK","_number":1,"created":"2026-01-13 12:43:59.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/69/1469/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/69/1469/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/69/1469/1 \u0026\u0026 git checkout -b change-1469 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/69/1469/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/69/1469/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/69/1469/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/69/1469/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/69/1469/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4a15d4e51ddb58fbc7a2b2369f30e51616a2a591","subject":"Require script-security 2 when using unix: tun"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-13 12:37:52.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-13 12:37:52.000000000","tz":60},"subject":"socks: In establish_socks_proxy_udpassoc check result of recv_socks_reply","message":"socks: In establish_socks_proxy_udpassoc check result of recv_socks_reply\n\nNot just check the return value but also that relay_addr\nis valid. recv_socks_reply doesn\u0027t care whether the answer\nis what we expected. This is probably a very unlikely edge\ncase but it doesn\u0027t hurt to check for it here.\n\nReported-By: Joshua Rogers \u003ccontact@joshua.hu\u003e\nFound-By: ZeroPath (https://zeropath.com)\nGithub: openvpn-private-issues#13\nChange-Id: Ic1c8f24de423541bdc85e70b5a688213800d86de\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"b2cc5c2ec49c3cfc428f0ecef9684ac318845a84":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2026-01-14 18:40:44.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/69/1469/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/69/1469/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/69/1469/2 \u0026\u0026 git checkout -b change-1469 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/69/1469/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/69/1469/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/69/1469/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/69/1469/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/69/1469/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d61d3c2a71136cee146ede8b834b460721dd8d23","subject":"socket: Remove old \u0027dynamic remote\u0027 feature"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-14 13:58:02.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-01-14 18:38:28.000000000","tz":60},"subject":"socks: In establish_socks_proxy_udpassoc check result of recv_socks_reply","message":"socks: In establish_socks_proxy_udpassoc check result of recv_socks_reply\n\nNot just check the return value but also that relay_addr\nis valid. recv_socks_reply doesn\u0027t care whether the answer\nis what we expected. This is probably a very unlikely edge\ncase but it doesn\u0027t hurt to check for it here.\n\nReported-By: Joshua Rogers \u003ccontact@joshua.hu\u003e\nFound-By: ZeroPath (https://zeropath.com)\nGithub: openvpn-private-issues#13\nChange-Id: Ic1c8f24de423541bdc85e70b5a688213800d86de\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1469\nMessage-Id: \u003c20260114135807.20637-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg35249.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}
