)]}'
{"id":"openvpn~1489","triplet_id":"openvpn~master~Ia3477b8ee7a637c15aad7f285144280595cda5d5","project":"openvpn","branch":"master","topic":"wextra","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-03-04 14:24:45.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-03-04 14:24:45.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ia3477b8ee7a637c15aad7f285144280595cda5d5","subject":"buffer: Add checked_snprintf function and use it in the code","status":"MERGED","created":"2026-01-26 16:04:18.000000000","updated":"2026-03-04 14:24:45.000000000","submitted":"2026-03-04 14:24:45.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1489-wextra","meta_rev_id":"c4ff83e54e192345235a92dab0ebdaea9f2f8a11","_number":1489,"virtual_id_number":1489,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-01-26 16:04:23.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-01-26 16:04:23.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-03-04 11:04:23.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"eb94e819225144c48d99ffae4289072c88efeb0d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-01-26 16:04:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9f5eae538413f8b2195857f117574d593cb4cc69","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-01-26 18:02:23.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"80d0755203e721814d882f699297f0a9bd8e23f2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-04 13:36:43.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"6d437b3ef5cf0cec54e64135120f1ad1d5d2477f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-10 14:55:07.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"1e0a987eeda2121dab58afad11b151cede996a4b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-16 15:50:01.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.","accounts_in_message":[],"_revision_number":5},{"id":"850b7731b5bca7648665891e2b1df5360143b759","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-03 14:07:55.000000000","message":"Uploaded patch set 6: Patch Set 5 was rebased.","accounts_in_message":[],"_revision_number":6},{"id":"6b6bb4a71c3ea356ab6e1541dc811ca4d221c476","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-03-04 11:04:23.000000000","message":"Patch Set 6: Code-Review+2","accounts_in_message":[],"_revision_number":6},{"id":"c4ff83e54e192345235a92dab0ebdaea9f2f8a11","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-03-04 14:24:45.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"1ec71fe0c0cd3f593036197abdc9486ce3665c38","revisions":{"747a8dc0d10c254819f97e4508bfe9ee7177c257":{"kind":"REWORK","_number":1,"created":"2026-01-26 16:04:18.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/89/1489/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/89/1489/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/1 \u0026\u0026 git checkout -b change-1489 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/89/1489/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"22a7010f5b80ec8c69e789d0ca7e31a8f34f2f78","subject":"route: Fix conversion warnings on BSDs"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-26 14:42:16.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-26 14:58:00.000000000","tz":60},"subject":"buffer: Add checked_snprintf function and use it in the code","message":"buffer: Add checked_snprintf function and use it in the code\n\nThis reintroduces a function that converts the result\nof snprintf to a boolean since the check is always the\nsame but annoyingly verbose. And it gets worse when you add\n-Wsign-compare.\n\nSo in preparation of introducing -Wsign-compare wrap this\ncheck in the function.\n\nThis somewhat reverts the removal of openvpn_snprintf.\nBut note that that was originally introduced to work\naround the broken snprintf of Windows. So this is not\nexactly the same. For this reason I also classified this\nas a buffer function and not a compat function.\n\nChange-Id: Ia3477b8ee7a637c15aad7f285144280595cda5d5\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"41d51951c068fbf56176cfb995cceedf1ff28d85":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-01-26 18:02:23.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/89/1489/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/89/1489/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/2 \u0026\u0026 git checkout -b change-1489 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/89/1489/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e1e3b9aed13d42fd5e298bec5b079598fdf3a04e","subject":"status: Avoid conversion warnings in status_read/status_printf"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-26 14:42:16.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-26 17:25:48.000000000","tz":60},"subject":"buffer: Add checked_snprintf function and use it in the code","message":"buffer: Add checked_snprintf function and use it in the code\n\nThis reintroduces a function that converts the result\nof snprintf to a boolean since the check is always the\nsame but annoyingly verbose. And it gets worse when you add\n-Wsign-compare.\n\nSo in preparation of introducing -Wsign-compare wrap this\ncheck in the function.\n\nThis somewhat reverts the removal of openvpn_snprintf.\nBut note that that was originally introduced to work\naround the broken snprintf of Windows. So this is not\nexactly the same. For this reason I also classified this\nas a buffer function and not a compat function.\n\nChange-Id: Ia3477b8ee7a637c15aad7f285144280595cda5d5\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"abdee6a2a81732dec804c1629a36bf320be70a32":{"kind":"REWORK","_number":3,"created":"2026-02-04 13:36:43.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/89/1489/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/89/1489/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/3 \u0026\u0026 git checkout -b change-1489 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/89/1489/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"706fcc7d1a24077e2b3c711a5b9ceaa2a93a6a70","subject":"OpenVPN Release 2.7_rc6"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-26 14:42:16.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-04 13:11:01.000000000","tz":60},"subject":"buffer: Add checked_snprintf function and use it in the code","message":"buffer: Add checked_snprintf function and use it in the code\n\nThis reintroduces a function that converts the result\nof snprintf to a boolean since the check is always the\nsame but annoyingly verbose. And it gets worse when you add\n-Wsign-compare.\n\nSo in preparation of introducing -Wsign-compare wrap this\ncheck in the function.\n\nThis somewhat reverts the removal of openvpn_snprintf.\nBut note that that was originally introduced to work\naround the broken snprintf of Windows. So this is not\nexactly the same. For this reason I also classified this\nas a buffer function and not a compat function.\n\nChange-Id: Ia3477b8ee7a637c15aad7f285144280595cda5d5\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"d05147e7926298854714384a4bf2a7ae37781dac":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2026-02-10 14:55:07.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/89/1489/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/89/1489/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/4 \u0026\u0026 git checkout -b change-1489 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/89/1489/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fc86d9a2ffb2fa3aaff4bda129a5819bbf1ffd8a","subject":"crypto_backend: Improve signature of md_full to avoid conversions"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-26 14:42:16.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-10 14:51:33.000000000","tz":60},"subject":"buffer: Add checked_snprintf function and use it in the code","message":"buffer: Add checked_snprintf function and use it in the code\n\nThis reintroduces a function that converts the result\nof snprintf to a boolean since the check is always the\nsame but annoyingly verbose. And it gets worse when you add\n-Wsign-compare.\n\nSo in preparation of introducing -Wsign-compare wrap this\ncheck in the function.\n\nThis somewhat reverts the removal of openvpn_snprintf.\nBut note that that was originally introduced to work\naround the broken snprintf of Windows. So this is not\nexactly the same. For this reason I also classified this\nas a buffer function and not a compat function.\n\nChange-Id: Ia3477b8ee7a637c15aad7f285144280595cda5d5\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"e45fab88b9cf9e765734f172a03a19d5aac9ea99":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2026-02-16 15:50:01.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/89/1489/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/89/1489/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/5 \u0026\u0026 git checkout -b change-1489 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/89/1489/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"74e88cf06685bd2834d2e7c392e4914c90f2034e","subject":"crypto_backend: Improve signature of md_full to avoid conversions"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-26 14:42:16.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-16 15:48:13.000000000","tz":60},"subject":"buffer: Add checked_snprintf function and use it in the code","message":"buffer: Add checked_snprintf function and use it in the code\n\nThis reintroduces a function that converts the result\nof snprintf to a boolean since the check is always the\nsame but annoyingly verbose. And it gets worse when you add\n-Wsign-compare.\n\nSo in preparation of introducing -Wsign-compare wrap this\ncheck in the function.\n\nThis somewhat reverts the removal of openvpn_snprintf.\nBut note that that was originally introduced to work\naround the broken snprintf of Windows. So this is not\nexactly the same. For this reason I also classified this\nas a buffer function and not a compat function.\n\nChange-Id: Ia3477b8ee7a637c15aad7f285144280595cda5d5\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"a7fb7fc1d3fdab9ad14553a6ea7ba2414e657145":{"kind":"TRIVIAL_REBASE","_number":6,"created":"2026-03-03 14:07:55.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/89/1489/6","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/89/1489/6","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/6 \u0026\u0026 git checkout -b change-1489 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/89/1489/6","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4ec6f92fa808e4428058dfa7e280aedf5ae3097f","subject":"buffer: Clarify usage of char_class"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-26 14:42:16.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-03 13:55:17.000000000","tz":60},"subject":"buffer: Add checked_snprintf function and use it in the code","message":"buffer: Add checked_snprintf function and use it in the code\n\nThis reintroduces a function that converts the result\nof snprintf to a boolean since the check is always the\nsame but annoyingly verbose. And it gets worse when you add\n-Wsign-compare.\n\nSo in preparation of introducing -Wsign-compare wrap this\ncheck in the function.\n\nThis somewhat reverts the removal of openvpn_snprintf.\nBut note that that was originally introduced to work\naround the broken snprintf of Windows. So this is not\nexactly the same. For this reason I also classified this\nas a buffer function and not a compat function.\n\nChange-Id: Ia3477b8ee7a637c15aad7f285144280595cda5d5\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"1ec71fe0c0cd3f593036197abdc9486ce3665c38":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":7,"created":"2026-03-04 14:24:45.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/89/1489/7","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/89/1489/7","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/7 \u0026\u0026 git checkout -b change-1489 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/89/1489/7","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1489/7 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"28941473f32153a762db25a0ebe54aae321a8155","subject":"buffer: Add BLENZ macro that returns size_t and use it where required"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-04 11:04:49.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-03-04 13:11:31.000000000","tz":60},"subject":"buffer: Add checked_snprintf function and use it in the code","message":"buffer: Add checked_snprintf function and use it in the code\n\nThis reintroduces a function that converts the result\nof snprintf to a boolean since the check is always the\nsame but annoyingly verbose. And it gets worse when you add\n-Wsign-compare.\n\nSo in preparation of introducing -Wsign-compare wrap this\ncheck in the function.\n\nThis somewhat reverts the removal of openvpn_snprintf.\nBut note that that was originally introduced to work\naround the broken snprintf of Windows. So this is not\nexactly the same. For this reason I also classified this\nas a buffer function and not a compat function.\n\nChange-Id: Ia3477b8ee7a637c15aad7f285144280595cda5d5\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1489\nMessage-Id: \u003c20260304110455.15859-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg35872.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}