)]}'
{"id":"openvpn~1490","triplet_id":"openvpn~master~I68c8ebb593262116b42b4c749d4aed3078f8499b","project":"openvpn","branch":"master","topic":"wextra","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-03-02 15:37:31.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-03-03 14:24:48.000000000","reason":"Change was marked work in progress"}},"hashtags":[],"change_id":"I68c8ebb593262116b42b4c749d4aed3078f8499b","subject":"Change signedness of constants to avoid sign-compare issues","status":"ABANDONED","created":"2026-01-26 16:04:18.000000000","updated":"2026-03-04 13:21:43.000000000","total_comment_count":0,"unresolved_comment_count":0,"work_in_progress":true,"has_review_started":true,"meta_rev_id":"22d590e7b15991727edd5b53e8ac037d8badf449","_number":1490,"virtual_id_number":1490,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"all":[{"value":2,"date":"2026-03-02 15:37:31.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-01-26 16:04:23.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-01-26 16:04:23.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"904b843fd657b11dc625b93bccabd4c4bbb105bc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-01-26 16:04:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5d2fe92f558fb6dfbeeae9667309a28c122b31bb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-01-26 18:02:23.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"a2f7978096c1dd65037f28ac03c6f8fffa7863d4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-04 13:36:43.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"8ea1310e30b1c509c65966e6170543716db4ce8d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-10 14:55:07.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"5561e53d4aa50d5a3a610497e21865880595a755","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-16 15:50:01.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.","accounts_in_message":[],"_revision_number":5},{"id":"4ce5f77d36eeba72146a70d32a197d911495893a","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-03-02 15:37:31.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"b3cb9e1eeefcc0c3e8c16b0bac65282bb1c04c52","tag":"autogenerated:gerrit:setWorkInProgress","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-03 14:24:48.000000000","message":"Set Work In Progress","accounts_in_message":[],"_revision_number":5},{"id":"22d590e7b15991727edd5b53e8ac037d8badf449","tag":"autogenerated:gerrit:abandon","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-04 13:21:43.000000000","message":"Abandoned\n\nUsed #1132 instead","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"d7ef06ee6cd54a1580d08a29ca016ce47a3cf61e","revisions":{"793c92ddf71f5cc7a8741d0c85e48fc38f344bb7":{"kind":"REWORK","_number":1,"created":"2026-01-26 16:04:18.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/90/1490/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/90/1490/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1490/1 \u0026\u0026 git checkout -b change-1490 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1490/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1490/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1490/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/90/1490/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1490/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"747a8dc0d10c254819f97e4508bfe9ee7177c257","subject":"buffer: Add checked_snprintf function and use it in the code"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-26 15:06:29.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-26 15:59:48.000000000","tz":60},"subject":"Change signedness of constants to avoid sign-compare issues","message":"Change signedness of constants to avoid sign-compare issues\n\nImprove conditionals where we want to ensure that\na signed int is greater than a unsigned constant int\nby forcing the comparison to be signed (instead\nof the default unsigned comparison).\nThis avoids the potential corner case where the\ninteger might falsely compare as bigger due to being\nnegative.\n\nEven if we know the comparison to be safe already, we\nstill need the cast to suppress -Wsign-compare errors.\n\nChange-Id: I68c8ebb593262116b42b4c749d4aed3078f8499b\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"0a2ef3e58fd70633ebd50c748fa5e8c657b68ccd":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-01-26 18:02:23.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/90/1490/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/90/1490/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1490/2 \u0026\u0026 git checkout -b change-1490 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1490/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1490/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1490/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/90/1490/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1490/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"41d51951c068fbf56176cfb995cceedf1ff28d85","subject":"buffer: Add checked_snprintf function and use it in the code"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-26 15:06:29.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-26 17:25:48.000000000","tz":60},"subject":"Change signedness of constants to avoid sign-compare issues","message":"Change signedness of constants to avoid sign-compare issues\n\nImprove conditionals where we want to ensure that\na signed int is greater than a unsigned constant int\nby forcing the comparison to be signed (instead\nof the default unsigned comparison).\nThis avoids the potential corner case where the\ninteger might falsely compare as bigger due to being\nnegative.\n\nEven if we know the comparison to be safe already, we\nstill need the cast to suppress -Wsign-compare errors.\n\nChange-Id: I68c8ebb593262116b42b4c749d4aed3078f8499b\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"c5f80e4795b4cd7fe8cd9b2f1a206859c2f4a0ba":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2026-02-04 13:36:43.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/90/1490/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/90/1490/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1490/3 \u0026\u0026 git checkout -b change-1490 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1490/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1490/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1490/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/90/1490/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1490/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"abdee6a2a81732dec804c1629a36bf320be70a32","subject":"buffer: Add checked_snprintf function and use it in the code"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-26 15:06:29.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-04 13:11:01.000000000","tz":60},"subject":"Change signedness of constants to avoid sign-compare issues","message":"Change signedness of constants to avoid sign-compare issues\n\nImprove conditionals where we want to ensure that\na signed int is greater than a unsigned constant int\nby forcing the comparison to be signed (instead\nof the default unsigned comparison).\nThis avoids the potential corner case where the\ninteger might falsely compare as bigger due to being\nnegative.\n\nEven if we know the comparison to be safe already, we\nstill need the cast to suppress -Wsign-compare errors.\n\nChange-Id: I68c8ebb593262116b42b4c749d4aed3078f8499b\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"e53b044a662d7ff4687b3c0b775d760aac42112b":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2026-02-10 14:55:07.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/90/1490/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/90/1490/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1490/4 \u0026\u0026 git checkout -b change-1490 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1490/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1490/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1490/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/90/1490/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1490/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d05147e7926298854714384a4bf2a7ae37781dac","subject":"buffer: Add checked_snprintf function and use it in the code"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-26 15:06:29.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-10 14:51:33.000000000","tz":60},"subject":"Change signedness of constants to avoid sign-compare issues","message":"Change signedness of constants to avoid sign-compare issues\n\nImprove conditionals where we want to ensure that\na signed int is greater than a unsigned constant int\nby forcing the comparison to be signed (instead\nof the default unsigned comparison).\nThis avoids the potential corner case where the\ninteger might falsely compare as bigger due to being\nnegative.\n\nEven if we know the comparison to be safe already, we\nstill need the cast to suppress -Wsign-compare errors.\n\nChange-Id: I68c8ebb593262116b42b4c749d4aed3078f8499b\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"d7ef06ee6cd54a1580d08a29ca016ce47a3cf61e":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2026-02-16 15:50:01.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/90/1490/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/90/1490/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1490/5 \u0026\u0026 git checkout -b change-1490 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1490/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1490/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1490/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/90/1490/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1490/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e45fab88b9cf9e765734f172a03a19d5aac9ea99","subject":"buffer: Add checked_snprintf function and use it in the code"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-26 15:06:29.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-16 15:48:13.000000000","tz":60},"subject":"Change signedness of constants to avoid sign-compare issues","message":"Change signedness of constants to avoid sign-compare issues\n\nImprove conditionals where we want to ensure that\na signed int is greater than a unsigned constant int\nby forcing the comparison to be signed (instead\nof the default unsigned comparison).\nThis avoids the potential corner case where the\ninteger might falsely compare as bigger due to being\nnegative.\n\nEven if we know the comparison to be safe already, we\nstill need the cast to suppress -Wsign-compare errors.\n\nChange-Id: I68c8ebb593262116b42b4c749d4aed3078f8499b\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}