)]}'
{"id":"openvpn~1491","triplet_id":"openvpn~master~Ib6c3e154fbe14113ff990f13347f85a7c93dd3e0","project":"openvpn","branch":"master","topic":"wextra","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-02-19 16:15:04.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-02-19 16:15:04.000000000","reason":"Change was submitted"}},"hashtags":["mailsubmitted"],"change_id":"Ib6c3e154fbe14113ff990f13347f85a7c93dd3e0","subject":"Fix various loop index types to avoid sign-compare issues","status":"MERGED","created":"2026-01-26 18:02:23.000000000","updated":"2026-02-19 16:15:04.000000000","submitted":"2026-02-19 16:15:04.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1491-wextra","meta_rev_id":"dc11270aa02a0f7f6992c958717772f55118bce0","_number":1491,"virtual_id_number":1491,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-01-26 18:02:28.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-01-26 18:02:28.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-02-16 21:27:47.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"773bcef6ac4dee0bba7a395502c33ab64df4809f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-01-26 18:02:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"07bd55d8128c6497a8e735c1bcd0dea53e8397c7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-04 13:36:43.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"23872dde5a157d9f47d3bd7cf56253063bb1c82d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-10 14:55:07.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"ef799b75f822f365b78bbd51ddeba2cf4d1aaa4f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-16 15:50:01.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"85386274ed5e981d12780d53c0025b522e887414","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-02-16 21:27:47.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"2d1ed99bdabb271c0692f2eecd0f229d57f6db9e","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-18 13:47:25.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":4},{"id":"dc11270aa02a0f7f6992c958717772f55118bce0","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-02-19 16:15:04.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"25af0b222facf1169f1d27e29cb2ac0de0279286","revisions":{"1e8279c3dd63b44803d7c5adb04bd8017cc557fc":{"kind":"REWORK","_number":1,"created":"2026-01-26 18:02:23.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/91/1491/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/91/1491/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1491/1 \u0026\u0026 git checkout -b change-1491 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1491/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1491/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1491/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/91/1491/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1491/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0a2ef3e58fd70633ebd50c748fa5e8c657b68ccd","subject":"Change signedness of constants to avoid sign-compare issues"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-26 17:48:28.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-26 17:52:02.000000000","tz":60},"subject":"Fix various loop index types to avoid sign-compare issues","message":"Fix various loop index types to avoid sign-compare issues\n\nJust uses the correct types i.e. the same as the limit.\nSince the index is usually only used as a non-negative\narray index the type change does not cause any behavioral\nchanges.\n\nBut it avoids -Wsign-compare complaints and is just\ncleaner.\n\nChange-Id: Ib6c3e154fbe14113ff990f13347f85a7c93dd3e0\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"b142061c269021fa7122248bec74c19620226a76":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-02-04 13:36:43.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/91/1491/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/91/1491/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1491/2 \u0026\u0026 git checkout -b change-1491 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1491/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1491/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1491/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/91/1491/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1491/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c5f80e4795b4cd7fe8cd9b2f1a206859c2f4a0ba","subject":"Change signedness of constants to avoid sign-compare issues"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-26 17:48:28.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-04 13:11:01.000000000","tz":60},"subject":"Fix various loop index types to avoid sign-compare issues","message":"Fix various loop index types to avoid sign-compare issues\n\nJust uses the correct types i.e. the same as the limit.\nSince the index is usually only used as a non-negative\narray index the type change does not cause any behavioral\nchanges.\n\nBut it avoids -Wsign-compare complaints and is just\ncleaner.\n\nChange-Id: Ib6c3e154fbe14113ff990f13347f85a7c93dd3e0\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"df7d8345d2722e763ae52dd231395938e34c84f8":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2026-02-10 14:55:07.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/91/1491/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/91/1491/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1491/3 \u0026\u0026 git checkout -b change-1491 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1491/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1491/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1491/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/91/1491/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1491/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e53b044a662d7ff4687b3c0b775d760aac42112b","subject":"Change signedness of constants to avoid sign-compare issues"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-26 17:48:28.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-10 14:51:33.000000000","tz":60},"subject":"Fix various loop index types to avoid sign-compare issues","message":"Fix various loop index types to avoid sign-compare issues\n\nJust uses the correct types i.e. the same as the limit.\nSince the index is usually only used as a non-negative\narray index the type change does not cause any behavioral\nchanges.\n\nBut it avoids -Wsign-compare complaints and is just\ncleaner.\n\nChange-Id: Ib6c3e154fbe14113ff990f13347f85a7c93dd3e0\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"f4be7d4dc70024cb99ae12b3717bb0f38049c86b":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2026-02-16 15:50:01.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/91/1491/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/91/1491/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1491/4 \u0026\u0026 git checkout -b change-1491 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1491/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1491/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1491/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/91/1491/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1491/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d7ef06ee6cd54a1580d08a29ca016ce47a3cf61e","subject":"Change signedness of constants to avoid sign-compare issues"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-26 17:48:28.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-16 15:48:13.000000000","tz":60},"subject":"Fix various loop index types to avoid sign-compare issues","message":"Fix various loop index types to avoid sign-compare issues\n\nJust uses the correct types i.e. the same as the limit.\nSince the index is usually only used as a non-negative\narray index the type change does not cause any behavioral\nchanges.\n\nBut it avoids -Wsign-compare complaints and is just\ncleaner.\n\nChange-Id: Ib6c3e154fbe14113ff990f13347f85a7c93dd3e0\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"25af0b222facf1169f1d27e29cb2ac0de0279286":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":5,"created":"2026-02-19 16:15:04.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/91/1491/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/91/1491/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1491/5 \u0026\u0026 git checkout -b change-1491 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1491/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1491/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1491/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/91/1491/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/91/1491/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b3e0e8696b162794beefc22aad7406b328471cf6","subject":"DCO Linux: Fix setting DCO ifmode failing on big endian archs"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-16 21:27:56.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-02-19 16:11:30.000000000","tz":60},"subject":"Fix various loop index types to avoid sign-compare issues","message":"Fix various loop index types to avoid sign-compare issues\n\nJust uses the correct types i.e. the same as the limit.\nSince the index is usually only used as a non-negative\narray index the type change does not cause any behavioral\nchanges.\n\nBut it avoids -Wsign-compare complaints and is just\ncleaner.\n\nChange-Id: Ib6c3e154fbe14113ff990f13347f85a7c93dd3e0\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1491\nMessage-Id: \u003c20260216212805.7808-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg35682.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}