)]}'
{"id":"openvpn~1492","triplet_id":"openvpn~master~I525a5b1b9b6f173cdf12341aefc44d58f0d43aed","project":"openvpn","branch":"master","topic":"wextra","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-03-05 08:29:41.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-03-05 08:29:41.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I525a5b1b9b6f173cdf12341aefc44d58f0d43aed","subject":"cryptoapi: Change signature of parse_hexstring to match code","status":"MERGED","created":"2026-01-27 11:16:11.000000000","updated":"2026-03-05 08:29:41.000000000","submitted":"2026-03-05 08:29:41.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1492-wextra","meta_rev_id":"1562f09d13d2d7dcb28aa49beb8229b023b7296b","_number":1492,"virtual_id_number":1492,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-01-27 11:16:13.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-01-27 11:16:13.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-01-27 11:41:26.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"REVIEWER"}],"messages":[{"id":"80c5aefb751687a289df5baa2762d5f46e3ca634","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-01-27 11:16:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"01be8a00b067bc56a97fd14dba4f23f63179b355","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-01-27 11:41:26.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"065847a8347410689b1c285b0dfb4bfe89eb6693","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-04 13:04:26.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"c8cf964591649159ad99a7a0099ba7a5124526f8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-04 13:36:43.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"897b94c19011390d1d261d2f5379dfe343adcbbc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-10 14:55:07.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":4},{"id":"d9174d9be8b2153ec946617e1e0a1bf1751fa099","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-16 15:50:01.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":5},{"id":"1562f09d13d2d7dcb28aa49beb8229b023b7296b","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-03-05 08:29:41.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"3451c18fe1a8afb288a55704295cc89c4eadce8b","revisions":{"b1ce2140f03edf512082f04087d7f269d8e559be":{"kind":"REWORK","_number":1,"created":"2026-01-27 11:16:11.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/92/1492/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/92/1492/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1492/1 \u0026\u0026 git checkout -b change-1492 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1492/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1492/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1492/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/92/1492/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1492/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3b18def85d387d09f82bc4a9c176bbde8ba7e4a0","subject":"Enable -Wsign-compare"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-27 11:04:08.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-27 11:07:35.000000000","tz":60},"subject":"cryptoapi: Change signature of parse_hexstring to match code","message":"cryptoapi: Change signature of parse_hexstring to match code\n\nparse_hexdigest is a function that is used in\nexactly one place (not counting tests). So\nchange the types in a way that they match what\nthe caller actually wants (DWORD) and so we\ndo not have any unnecessary conversions.\n\nChange-Id: I525a5b1b9b6f173cdf12341aefc44d58f0d43aed\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"63a7f99a279afc8ab0cf7e4bcf91f8ad6ec89698":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-02-04 13:04:26.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/92/1492/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/92/1492/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1492/2 \u0026\u0026 git checkout -b change-1492 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1492/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1492/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1492/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/92/1492/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1492/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e37778a1f1ec665e418ca0f9089f8b8014d7c0a8","subject":"Enable -Wsign-compare"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-27 11:04:08.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-04 13:01:42.000000000","tz":60},"subject":"cryptoapi: Change signature of parse_hexstring to match code","message":"cryptoapi: Change signature of parse_hexstring to match code\n\nparse_hexdigest is a function that is used in\nexactly one place (not counting tests). So\nchange the types in a way that they match what\nthe caller actually wants (DWORD) and so we\ndo not have any unnecessary conversions.\n\nChange-Id: I525a5b1b9b6f173cdf12341aefc44d58f0d43aed\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"e6f311abdcb970e68df7d0b23b5fc6031bad3d79":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2026-02-04 13:36:43.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/92/1492/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/92/1492/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1492/3 \u0026\u0026 git checkout -b change-1492 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1492/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1492/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1492/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/92/1492/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1492/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e74321613a0dace6f667956331b0e9e854ede487","subject":"Enable -Wsign-compare"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-27 11:04:08.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-04 13:11:01.000000000","tz":60},"subject":"cryptoapi: Change signature of parse_hexstring to match code","message":"cryptoapi: Change signature of parse_hexstring to match code\n\nparse_hexdigest is a function that is used in\nexactly one place (not counting tests). So\nchange the types in a way that they match what\nthe caller actually wants (DWORD) and so we\ndo not have any unnecessary conversions.\n\nChange-Id: I525a5b1b9b6f173cdf12341aefc44d58f0d43aed\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"f4122ba3d5eba46a2a87504cbac586409a8e5915":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2026-02-10 14:55:07.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/92/1492/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/92/1492/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1492/4 \u0026\u0026 git checkout -b change-1492 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1492/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1492/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1492/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/92/1492/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1492/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1ea05663f6c45967a29f0b320c29087cc837cab6","subject":"Enable -Wsign-compare"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-27 11:04:08.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-10 14:51:33.000000000","tz":60},"subject":"cryptoapi: Change signature of parse_hexstring to match code","message":"cryptoapi: Change signature of parse_hexstring to match code\n\nparse_hexdigest is a function that is used in\nexactly one place (not counting tests). So\nchange the types in a way that they match what\nthe caller actually wants (DWORD) and so we\ndo not have any unnecessary conversions.\n\nChange-Id: I525a5b1b9b6f173cdf12341aefc44d58f0d43aed\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"e27936677b80de61c01d5c0a6e7a2d6fa9bfe0f0":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2026-02-16 15:50:01.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/92/1492/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/92/1492/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1492/5 \u0026\u0026 git checkout -b change-1492 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1492/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1492/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1492/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/92/1492/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1492/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9d57e7cd147425ca08a0059527732d22ce6cd64a","subject":"Enable -Wsign-compare"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-27 11:04:08.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-16 15:48:30.000000000","tz":60},"subject":"cryptoapi: Change signature of parse_hexstring to match code","message":"cryptoapi: Change signature of parse_hexstring to match code\n\nparse_hexdigest is a function that is used in\nexactly one place (not counting tests). So\nchange the types in a way that they match what\nthe caller actually wants (DWORD) and so we\ndo not have any unnecessary conversions.\n\nChange-Id: I525a5b1b9b6f173cdf12341aefc44d58f0d43aed\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"3451c18fe1a8afb288a55704295cc89c4eadce8b":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":6,"created":"2026-03-05 08:29:41.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/92/1492/6","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/92/1492/6","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1492/6 \u0026\u0026 git checkout -b change-1492 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1492/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1492/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1492/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/92/1492/6","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1492/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"71c6729c403a17492a68ce70b0f6fd17c07e3de0","subject":"win32-util: Handle return value from WideCharToMultiByte better"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-04 16:44:55.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-03-05 08:27:37.000000000","tz":60},"subject":"cryptoapi: Change signature of parse_hexstring to match code","message":"cryptoapi: Change signature of parse_hexstring to match code\n\nparse_hexdigest is a function that is used in\nexactly one place (not counting tests). So\nchange the types in a way that they match what\nthe caller actually wants (DWORD) and so we\ndo not have any unnecessary conversions.\n\nChange-Id: I525a5b1b9b6f173cdf12341aefc44d58f0d43aed\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1492\nMessage-Id: \u003c20260304164502.15449-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg35901.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}