)]}'
{"id":"openvpn~1499","triplet_id":"openvpn~release%2F2.6~Idcb1421b9f7fcbee9620fd1d45cceab050751373","project":"openvpn","branch":"release/2.6","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-01-28 14:59:58.000000000","reason":"removed on reply"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2026-01-29 17:40:02.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Idcb1421b9f7fcbee9620fd1d45cceab050751373","subject":"tunnel_server_*(): close correct inotify fd","status":"MERGED","created":"2026-01-28 14:47:35.000000000","updated":"2026-01-29 17:40:02.000000000","submitted":"2026-01-29 17:40:02.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1499","meta_rev_id":"d6ae306c753f6f14daa421d15fc652a08ed00008","_number":1499,"virtual_id_number":1499,"owner":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-01-28 14:47:36.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-01-28 14:47:36.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"1fe638ff38cdb965459e56246c1b7d2b86bb15dd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-01-28 14:47:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f34062ec5b9af79e0539f54302409977d500108b","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-01-28 14:59:58.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"d6ae306c753f6f14daa421d15fc652a08ed00008","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-01-29 17:40:02.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"172fe07129f02be2d3e6779c632ed1e8081c412c","revisions":{"81992dede4af49cdcf3c17b14e8eae7141207499":{"kind":"REWORK","_number":1,"created":"2026-01-28 14:47:35.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/99/1499/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/99/1499/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1499/1 \u0026\u0026 git checkout -b change-1499 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1499/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1499/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1499/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/99/1499/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1499/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bb27e40799dcfe51a8cd82b236ce404bd7ab93aa","subject":"manage: Do not trigger actions on management disconnect if not authenticated"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-01-28 14:41:36.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-01-28 14:46:41.000000000","tz":60},"subject":"tunnel_server_*(): close correct inotify fd","message":"tunnel_server_*(): close correct inotify fd\n\nOn a full SIGUSR1 restart of a p2mp server compiled with\n--enable-async-push, tunnel_server_{udp,tcp}() will try to close and\nreopen the \"inotify\" control file descriptor.  For whatever reason,\nthe original code referenced the wrong context, always closing fd 0.\n\nAs a consequence of this, on the second SIGUSR1 restart, the server\nwill close() the first active socket file descriptor, and if there\nare active DCO clients, the resulting event confusion will lead to\nan ASSERT(!mi-\u003ehalt).\n\nFix by closing the correct FD. Add logging.\n\nThis is a backport of commit 5521872f80313060 to the \"old p2mp code\"\nwith a separate mudp.c and mtcp.c for UDP and TCP servers, respectively.\n\nGithub: fixes OpenVPN/openvpn#966\n\nChange-Id: Idcb1421b9f7fcbee9620fd1d45cceab050751373\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/release/2.6"},"172fe07129f02be2d3e6779c632ed1e8081c412c":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2026-01-29 17:40:02.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/99/1499/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/99/1499/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1499/2 \u0026\u0026 git checkout -b change-1499 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1499/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1499/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1499/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/99/1499/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1499/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bb27e40799dcfe51a8cd82b236ce404bd7ab93aa","subject":"manage: Do not trigger actions on management disconnect if not authenticated"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-01-28 15:06:35.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-01-29 17:28:32.000000000","tz":60},"subject":"tunnel_server_*(): close correct inotify fd","message":"tunnel_server_*(): close correct inotify fd\n\nOn a full SIGUSR1 restart of a p2mp server compiled with\n--enable-async-push, tunnel_server_{udp,tcp}() will try to close and\nreopen the \"inotify\" control file descriptor.  For whatever reason,\nthe original code referenced the wrong context, always closing fd 0.\n\nAs a consequence of this, on the second SIGUSR1 restart, the server\nwill close() the first active socket file descriptor, and if there\nare active DCO clients, the resulting event confusion will lead to\nan ASSERT(!mi-\u003ehalt).\n\nFix by closing the correct FD. Add logging.\n\nThis is a backport of commit 5521872f80313060 to the \"old p2mp code\"\nwith a separate mudp.c and mtcp.c for UDP and TCP servers, respectively.\n\nGithub: fixes OpenVPN/openvpn#966\n\nChange-Id: Idcb1421b9f7fcbee9620fd1d45cceab050751373\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1499\nMessage-Id: \u003c20260128150640.13867-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg35493.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/release/2.6"}},"requirements":[],"submit_records":[],"submit_requirements":[]}