)]}'
{"id":"openvpn~1502","triplet_id":"openvpn~master~I7be033bc88e9a6ba474916c8be039c126e8bc574","project":"openvpn","branch":"master","topic":"wextra","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-03-02 15:36:21.000000000","reason":"\u003cGERRIT_ACCOUNT_1000003\u003e replied on the change","reason_account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-03-05 08:45:06.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I7be033bc88e9a6ba474916c8be039c126e8bc574","subject":"push: Improve check of vsnprintf return value","status":"MERGED","created":"2026-01-30 16:10:55.000000000","updated":"2026-03-05 08:45:06.000000000","submitted":"2026-03-05 08:45:06.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1502-wextra","meta_rev_id":"736cfec630465f1c80e0c01f498f0b4726fb0bd1","_number":1502,"virtual_id_number":1502,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-01-30 16:10:59.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-01-30 16:10:59.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"736bb190fc209173ee1a9c96de056611e298a3ce","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-01-30 16:10:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d344595996cbbe21cc48681ae252e362eb2f2cf9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-04 13:04:26.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"a7a10b89d6cbd81b6ba61688fa4b458a722b3df4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-04 13:36:43.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"c11cfa0dcf8169bceb37df81976e6ed38ef30267","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-10 14:55:07.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"789b1a05af42beb9f22ecf7c91e26101a7e2830b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-16 15:50:01.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.","accounts_in_message":[],"_revision_number":5},{"id":"81628b36a3030a0f4ecf31209c932405d80cf864","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-03-02 15:36:21.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"736cfec630465f1c80e0c01f498f0b4726fb0bd1","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-03-05 08:45:06.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"4523e506bd2978c78a29824ce471c0518e85cb6c","revisions":{"7e1886e83c0e53c3a86ad1ca4f5d9fc483e1d881":{"kind":"REWORK","_number":1,"created":"2026-01-30 16:10:55.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/02/1502/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/02/1502/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1502/1 \u0026\u0026 git checkout -b change-1502 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1502/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1502/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1502/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/02/1502/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1502/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7f7bfbcf4601d5bffdae4662243f3555420591c6","subject":"error: Use SOCKET_UNDEFINED instead of -1 to avoid sign error on Windows"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-30 14:39:19.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-30 14:39:19.000000000","tz":60},"subject":"push: Improve check of vsnprintf return value","message":"push: Improve check of vsnprintf return value\n\nAvoid sign-compare warning and do not ignore error\nreturn values.\n\nChange-Id: I7be033bc88e9a6ba474916c8be039c126e8bc574\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"1a507f370e5faeb238d8a6d73d0e45d865d67437":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-02-04 13:04:26.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/02/1502/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/02/1502/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1502/2 \u0026\u0026 git checkout -b change-1502 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1502/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1502/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1502/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/02/1502/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1502/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7bb22513122e573a3b5e10f531716b431bdc98ea","subject":"error: Use SOCKET_UNDEFINED instead of -1 to avoid sign error on Windows"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-30 14:39:19.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-04 13:01:42.000000000","tz":60},"subject":"push: Improve check of vsnprintf return value","message":"push: Improve check of vsnprintf return value\n\nAvoid sign-compare warning and do not ignore error\nreturn values.\n\nChange-Id: I7be033bc88e9a6ba474916c8be039c126e8bc574\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"436095d0154574c9366246426c2f33bd43d5633c":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2026-02-04 13:36:43.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/02/1502/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/02/1502/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1502/3 \u0026\u0026 git checkout -b change-1502 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1502/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1502/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1502/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/02/1502/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1502/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8bd9689ff1f77f424d0d019f7ef2296e8742ee4e","subject":"error: Use SOCKET_UNDEFINED instead of -1 to avoid sign error on Windows"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-30 14:39:19.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-04 13:11:01.000000000","tz":60},"subject":"push: Improve check of vsnprintf return value","message":"push: Improve check of vsnprintf return value\n\nAvoid sign-compare warning and do not ignore error\nreturn values.\n\nChange-Id: I7be033bc88e9a6ba474916c8be039c126e8bc574\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"552ae4c845f942fa5700b52ccd520657f79f22d8":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2026-02-10 14:55:07.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/02/1502/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/02/1502/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1502/4 \u0026\u0026 git checkout -b change-1502 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1502/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1502/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1502/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/02/1502/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1502/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"98cad96666e520a4a0b38287e53be4935df2d4f6","subject":"error: Use SOCKET_UNDEFINED instead of -1 to avoid sign error on Windows"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-30 14:39:19.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-10 14:51:33.000000000","tz":60},"subject":"push: Improve check of vsnprintf return value","message":"push: Improve check of vsnprintf return value\n\nAvoid sign-compare warning and do not ignore error\nreturn values.\n\nChange-Id: I7be033bc88e9a6ba474916c8be039c126e8bc574\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"49c7a8ca3380a33e7d1aeafec623cec994efc5b6":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2026-02-16 15:50:01.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/02/1502/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/02/1502/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1502/5 \u0026\u0026 git checkout -b change-1502 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1502/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1502/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1502/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/02/1502/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1502/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a92abd1b5e455d7cf7ae8483e7e323063f0c9376","subject":"error: Use SOCKET_UNDEFINED instead of -1 to avoid sign error on Windows"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-30 14:39:19.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-16 15:48:30.000000000","tz":60},"subject":"push: Improve check of vsnprintf return value","message":"push: Improve check of vsnprintf return value\n\nAvoid sign-compare warning and do not ignore error\nreturn values.\n\nChange-Id: I7be033bc88e9a6ba474916c8be039c126e8bc574\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"4523e506bd2978c78a29824ce471c0518e85cb6c":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":6,"created":"2026-03-05 08:45:06.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/02/1502/6","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/02/1502/6","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1502/6 \u0026\u0026 git checkout -b change-1502 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1502/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1502/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1502/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/02/1502/6","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1502/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3451c18fe1a8afb288a55704295cc89c4eadce8b","subject":"cryptoapi: Change signature of parse_hexstring to match code"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-04 16:48:58.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-03-05 08:43:15.000000000","tz":60},"subject":"push: Improve check of vsnprintf return value","message":"push: Improve check of vsnprintf return value\n\nAvoid sign-compare warning and do not ignore error\nreturn values.\n\nChange-Id: I7be033bc88e9a6ba474916c8be039c126e8bc574\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1502\nMessage-Id: \u003c20260304164904.15743-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg35905.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
