)]}'
{"id":"openvpn~1503","triplet_id":"openvpn~master~Ib0d2b9520e4a77a9f4bf70ce092f76ca73608537","project":"openvpn","branch":"master","topic":"wextra","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-03-02 15:46:43.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-03-04 16:20:50.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ib0d2b9520e4a77a9f4bf70ce092f76ca73608537","subject":"ssl_ncp: Fix length check in mutate_ncp_cipher_list","status":"MERGED","created":"2026-01-30 16:10:55.000000000","updated":"2026-03-04 16:20:50.000000000","submitted":"2026-03-04 16:20:50.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1503-wextra","meta_rev_id":"1d0810771fbf3de4de7c702d9f86d3325b5058a2","_number":1503,"virtual_id_number":1503,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-01-30 16:11:00.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-01-30 16:11:00.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"12e14cfccca3b0b04b57ec9169276c5956e9da31","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-01-30 16:10:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a44942583e02c3e9ec5207ec3bc0b21d7e35e520","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-04 13:04:26.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"202ff68863c3d79345287faf3f630a7cf6f58194","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-04 13:36:43.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"8c35d5f86cfd82a3f33d65a7b64a28f1f63e981b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-10 14:55:07.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"248cd679f8f0c087f0d648506ca28c623e400ecb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-16 15:50:01.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.","accounts_in_message":[],"_revision_number":5},{"id":"fc1cb228c11108bf10c2f35648dd6cbb78f78051","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-03-02 15:46:43.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"1d0810771fbf3de4de7c702d9f86d3325b5058a2","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-03-04 16:20:50.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"984bd3952e991f186bc51cfac3c15b9b56aa72b3","revisions":{"838b24c37493bcb79c93fc4a99554ed7b4015584":{"kind":"REWORK","_number":1,"created":"2026-01-30 16:10:55.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/03/1503/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/03/1503/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1503/1 \u0026\u0026 git checkout -b change-1503 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1503/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1503/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1503/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/03/1503/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1503/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7e1886e83c0e53c3a86ad1ca4f5d9fc483e1d881","subject":"push: Improve check of vsnprintf return value"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-30 15:15:28.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-30 15:18:40.000000000","tz":60},"subject":"ssl_ncp: Fix length check in mutate_ncp_cipher_list","message":"ssl_ncp: Fix length check in mutate_ncp_cipher_list\n\n* Make it more readable by removing a level of negation\n* Fix an off-by-one error. It accepted one char fewer than\n  allowed.\n* Slightly improve the UT.\n\nChange-Id: Ib0d2b9520e4a77a9f4bf70ce092f76ca73608537\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"785cbe15ca5597dc42f2d07e765a3263d571460f":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-02-04 13:04:26.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/03/1503/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/03/1503/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1503/2 \u0026\u0026 git checkout -b change-1503 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1503/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1503/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1503/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/03/1503/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1503/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1a507f370e5faeb238d8a6d73d0e45d865d67437","subject":"push: Improve check of vsnprintf return value"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-30 15:15:28.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-04 13:01:42.000000000","tz":60},"subject":"ssl_ncp: Fix length check in mutate_ncp_cipher_list","message":"ssl_ncp: Fix length check in mutate_ncp_cipher_list\n\n* Make it more readable by removing a level of negation\n* Fix an off-by-one error. It accepted one char fewer than\n  allowed.\n* Slightly improve the UT.\n\nChange-Id: Ib0d2b9520e4a77a9f4bf70ce092f76ca73608537\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"946abc2a903a1969c873ea52034555c9f4e513f9":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2026-02-04 13:36:43.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/03/1503/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/03/1503/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1503/3 \u0026\u0026 git checkout -b change-1503 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1503/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1503/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1503/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/03/1503/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1503/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"436095d0154574c9366246426c2f33bd43d5633c","subject":"push: Improve check of vsnprintf return value"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-30 15:15:28.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-04 13:11:01.000000000","tz":60},"subject":"ssl_ncp: Fix length check in mutate_ncp_cipher_list","message":"ssl_ncp: Fix length check in mutate_ncp_cipher_list\n\n* Make it more readable by removing a level of negation\n* Fix an off-by-one error. It accepted one char fewer than\n  allowed.\n* Slightly improve the UT.\n\nChange-Id: Ib0d2b9520e4a77a9f4bf70ce092f76ca73608537\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"22e74c65c76bf7db08ab11f00d25e5287aa199ff":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2026-02-10 14:55:07.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/03/1503/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/03/1503/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1503/4 \u0026\u0026 git checkout -b change-1503 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1503/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1503/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1503/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/03/1503/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1503/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"552ae4c845f942fa5700b52ccd520657f79f22d8","subject":"push: Improve check of vsnprintf return value"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-30 15:15:28.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-10 14:51:33.000000000","tz":60},"subject":"ssl_ncp: Fix length check in mutate_ncp_cipher_list","message":"ssl_ncp: Fix length check in mutate_ncp_cipher_list\n\n* Make it more readable by removing a level of negation\n* Fix an off-by-one error. It accepted one char fewer than\n  allowed.\n* Slightly improve the UT.\n\nChange-Id: Ib0d2b9520e4a77a9f4bf70ce092f76ca73608537\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"102f408af94b59422ee5a49a052254a4c27fb239":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2026-02-16 15:50:01.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/03/1503/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/03/1503/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1503/5 \u0026\u0026 git checkout -b change-1503 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1503/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1503/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1503/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/03/1503/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1503/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"49c7a8ca3380a33e7d1aeafec623cec994efc5b6","subject":"push: Improve check of vsnprintf return value"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-01-30 15:15:28.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-16 15:48:30.000000000","tz":60},"subject":"ssl_ncp: Fix length check in mutate_ncp_cipher_list","message":"ssl_ncp: Fix length check in mutate_ncp_cipher_list\n\n* Make it more readable by removing a level of negation\n* Fix an off-by-one error. It accepted one char fewer than\n  allowed.\n* Slightly improve the UT.\n\nChange-Id: Ib0d2b9520e4a77a9f4bf70ce092f76ca73608537\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"984bd3952e991f186bc51cfac3c15b9b56aa72b3":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":6,"created":"2026-03-04 16:20:50.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/03/1503/6","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/03/1503/6","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1503/6 \u0026\u0026 git checkout -b change-1503 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1503/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1503/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1503/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/03/1503/6","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1503/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4f0f2615f942feb3298f96b9c915d6682c5640e8","subject":"Enable -Wsign-compare"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-02 18:16:22.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-03-04 16:17:14.000000000","tz":60},"subject":"ssl_ncp: Fix length check in mutate_ncp_cipher_list","message":"ssl_ncp: Fix length check in mutate_ncp_cipher_list\n\n* Make it more readable by removing a level of negation\n* Fix an off-by-one error. It accepted one char fewer than\n  allowed.\n* Slightly improve the UT.\n\nChange-Id: Ib0d2b9520e4a77a9f4bf70ce092f76ca73608537\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1503\nMessage-Id: \u003c20260302181627.29008-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg35828.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}