)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"56e056b43126b4d2504799dde90b043d2db88e14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"274f1661_69decff5","updated":"2026-03-10 10:48:34.000000000","message":"Could we make it just unsigned int instead? Using a size_t for something that is not really something that will ever be create than a few thousends feels quite silly","commit_id":"b501eac26fcd695edf0d0189b4d9ff7cb978f898"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"7fc9a3bf2bb77758b06011f2e644b1856bd5ba45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b4e2f576_5c3aedae","in_reply_to":"274f1661_69decff5","updated":"2026-03-11 10:47:30.000000000","message":"Done","commit_id":"b501eac26fcd695edf0d0189b4d9ff7cb978f898"}],"src/openvpn/crypto.c":[{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"df39503e10e064e3252df90928ce70aabe4f29a6","unresolved":true,"context_lines":[{"line_number":88,"context_line":"    {"},{"line_number":89,"context_line":"        struct buffer iv_buffer;"},{"line_number":90,"context_line":"        uint8_t iv[OPENVPN_MAX_IV_LENGTH] \u003d { 0 };"},{"line_number":91,"context_line":"        const unsigned int iv_len \u003d cipher_ctx_iv_length(ctx-\u003ecipher);"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        ASSERT(iv_len \u003e\u003d OPENVPN_AEAD_MIN_IV_LEN \u0026\u0026 iv_len \u003c\u003d OPENVPN_MAX_IV_LENGTH);"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":6,"id":"8b0e13d7_3c7a3f09","line":91,"updated":"2026-03-10 10:51:31.000000000","message":"Shouldn\u0027t this trigger a warning because we are putting a 8 byte int into a 4 byte int","commit_id":"b501eac26fcd695edf0d0189b4d9ff7cb978f898"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"7fc9a3bf2bb77758b06011f2e644b1856bd5ba45","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    {"},{"line_number":89,"context_line":"        struct buffer iv_buffer;"},{"line_number":90,"context_line":"        uint8_t iv[OPENVPN_MAX_IV_LENGTH] \u003d { 0 };"},{"line_number":91,"context_line":"        const unsigned int iv_len \u003d cipher_ctx_iv_length(ctx-\u003ecipher);"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        ASSERT(iv_len \u003e\u003d OPENVPN_AEAD_MIN_IV_LEN \u0026\u0026 iv_len \u003c\u003d OPENVPN_MAX_IV_LENGTH);"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":6,"id":"4868ae72_9464a4d3","line":91,"in_reply_to":"8b0e13d7_3c7a3f09","updated":"2026-03-11 10:47:30.000000000","message":"Acknowledged","commit_id":"b501eac26fcd695edf0d0189b4d9ff7cb978f898"}],"src/openvpn/crypto_backend.h":[{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"df39503e10e064e3252df90928ce70aabe4f29a6","unresolved":true,"context_lines":[{"line_number":281,"context_line":" * @return              Tag size in bytes, or 0 if the tag size could not be"},{"line_number":282,"context_line":" *                      determined."},{"line_number":283,"context_line":" */"},{"line_number":284,"context_line":"size_t cipher_kt_tag_size(const char *ciphername);"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"/**"},{"line_number":287,"context_line":" * Returns true if we consider this cipher to be insecure."}],"source_content_type":"text/x-csrc","patch_set":6,"id":"c62f107f_bb65928c","line":284,"updated":"2026-03-10 10:51:31.000000000","message":"I would like to have some more consistency here. We are making cipher_ctx_iv_length an unsigned int but this a size_t","commit_id":"b501eac26fcd695edf0d0189b4d9ff7cb978f898"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"7fc9a3bf2bb77758b06011f2e644b1856bd5ba45","unresolved":false,"context_lines":[{"line_number":281,"context_line":" * @return              Tag size in bytes, or 0 if the tag size could not be"},{"line_number":282,"context_line":" *                      determined."},{"line_number":283,"context_line":" */"},{"line_number":284,"context_line":"size_t cipher_kt_tag_size(const char *ciphername);"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"/**"},{"line_number":287,"context_line":" * Returns true if we consider this cipher to be insecure."}],"source_content_type":"text/x-csrc","patch_set":6,"id":"70af9e9e_335e1b00","line":284,"in_reply_to":"c62f107f_bb65928c","updated":"2026-03-11 10:47:30.000000000","message":"Done","commit_id":"b501eac26fcd695edf0d0189b4d9ff7cb978f898"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"df39503e10e064e3252df90928ce70aabe4f29a6","unresolved":true,"context_lines":[{"line_number":376,"context_line":" *"},{"line_number":377,"context_line":" * @return              Block size, in bytes, or 0 if ctx was NULL."},{"line_number":378,"context_line":" */"},{"line_number":379,"context_line":"unsigned int cipher_ctx_block_size(const cipher_ctx_t *ctx);"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"/**"},{"line_number":382,"context_line":" * Returns the mode that the cipher runs in."}],"source_content_type":"text/x-csrc","patch_set":6,"id":"4d9f4906_47ca6c0c","line":379,"updated":"2026-03-10 10:51:31.000000000","message":"This is an unsigned int while the non context uses a different return type of size_t","commit_id":"b501eac26fcd695edf0d0189b4d9ff7cb978f898"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"7fc9a3bf2bb77758b06011f2e644b1856bd5ba45","unresolved":false,"context_lines":[{"line_number":376,"context_line":" *"},{"line_number":377,"context_line":" * @return              Block size, in bytes, or 0 if ctx was NULL."},{"line_number":378,"context_line":" */"},{"line_number":379,"context_line":"unsigned int cipher_ctx_block_size(const cipher_ctx_t *ctx);"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"/**"},{"line_number":382,"context_line":" * Returns the mode that the cipher runs in."}],"source_content_type":"text/x-csrc","patch_set":6,"id":"36f5a73f_70322dfd","line":379,"in_reply_to":"4d9f4906_47ca6c0c","updated":"2026-03-11 10:47:30.000000000","message":"Done","commit_id":"b501eac26fcd695edf0d0189b4d9ff7cb978f898"}]}