)]}'
{"id":"openvpn~1508","triplet_id":"openvpn~master~I1bc576c4c7ffacbb9300608d98b06b22f2475fd9","project":"openvpn","branch":"master","topic":"wextra","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-03-11 16:30:22.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-03-14 17:07:33.000000000","reason":"Change was submitted"}},"hashtags":["mailsubmitted"],"change_id":"I1bc576c4c7ffacbb9300608d98b06b22f2475fd9","subject":"crypto: Change cipher_kt_*_size to return unsigned instead of int","status":"MERGED","created":"2026-02-02 17:37:49.000000000","updated":"2026-03-14 17:07:33.000000000","submitted":"2026-03-14 17:07:33.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1508-wextra","meta_rev_id":"05dbb3b63c1681d57b2c3110faa028479d18f916","_number":1508,"virtual_id_number":1508,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-02-02 17:37:50.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-02-02 17:37:50.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"06224d63453157d6854fdd267ae5fb416bf6e56a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-02 17:37:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2a2d204ca9365da30c2950fe5edfa736abf24a54","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-04 13:04:26.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"99312e1072f291ee5404f7b4df6ee24fa7aeec01","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-04 13:36:43.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"a92260b3a79e137e9c51e8d493ec612b224c3208","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-10 14:55:07.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"b2b1808d977d9fb24c7e188623a10adec6e25880","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-16 15:50:01.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.","accounts_in_message":[],"_revision_number":5},{"id":"4e50aa5f266c092a7a644a5e22a549ac025617ca","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-06 11:56:43.000000000","message":"Uploaded patch set 6: Patch Set 5 was rebased.","accounts_in_message":[],"_revision_number":6},{"id":"56e056b43126b4d2504799dde90b043d2db88e14","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-03-10 10:48:34.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"df39503e10e064e3252df90928ce70aabe4f29a6","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-03-10 10:51:31.000000000","message":"Patch Set 6: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":6},{"id":"204e06290da22b1b16caaed34909da8bb250ec89","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-10 13:21:27.000000000","message":"Uploaded patch set 7.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":7},{"id":"7fc9a3bf2bb77758b06011f2e644b1856bd5ba45","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-11 10:47:30.000000000","message":"Patch Set 7:\n\n(4 comments)","accounts_in_message":[],"_revision_number":7},{"id":"c87ba510479258e632e0af72d6c81afef99c90a9","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-03-11 16:30:22.000000000","message":"Patch Set 7: Code-Review+2","accounts_in_message":[],"_revision_number":7},{"id":"c820589ea3324bc13e5d1e140da923dc4764aa4b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-12 13:25:17.000000000","message":"Uploaded patch set 8: Patch Set 7 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":8},{"id":"cae7d66158097f9d4b09b2a7462e8f0803400913","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-13 10:47:24.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":8},{"id":"b51f31a1c53290df7a1a4de53c047d70b30c4981","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-13 16:39:02.000000000","message":"Uploaded patch set 9: Patch Set 8 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":9},{"id":"05dbb3b63c1681d57b2c3110faa028479d18f916","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-03-14 17:07:33.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":10}],"current_revision_number":10,"current_revision":"b0c2174a9ee7bfdf40df5a728b84967bded555d7","revisions":{"11623eb9f6ea4f1e346c3eab8cc7ecda4e7725d4":{"kind":"REWORK","_number":1,"created":"2026-02-02 17:37:49.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/08/1508/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/08/1508/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/1 \u0026\u0026 git checkout -b change-1508 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/08/1508/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1d0fc2bde9be8541663eeb9abb53feefb8e93fe3","subject":"ssl_verify_openssl: Clean up extract_x509_extension"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-02 17:02:29.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-02 17:35:07.000000000","tz":60},"subject":"crypto: Change cipher_kt_*_size to return size_t instead of int","message":"crypto: Change cipher_kt_*_size to return size_t instead of int\n\nOpenSSL uses int but never returns negative values.\nmbedTLS \u003c 4 uses size_t and mbedTLS \u003e\u003d 4 doesn\u0027t have\nits own implementation, so we can choose.\n\nSo choose size_t as a type that can take all these values.\nMaking this unsigned makes it easier in most cases to write\ncode that doesn\u0027t have sign-compare issues.\n\nAlso change cipher_ctx_iv_length and cipher_ctx_block_size\nto return an unsigned value for similar reasons. In that\ncase I did go for unsigned int since no implementation\nacutally requires size_t.\n\nChange-Id: I1bc576c4c7ffacbb9300608d98b06b22f2475fd9\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"ad77937c5ee444eb27a61137fc00bda6750eff25":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-02-04 13:04:26.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/08/1508/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/08/1508/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/2 \u0026\u0026 git checkout -b change-1508 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/08/1508/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e0895b3dc1617c088eb99084f6f2b821ac57f130","subject":"ssl_verify_openssl: Clean up extract_x509_extension"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-02 17:02:29.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-04 13:01:42.000000000","tz":60},"subject":"crypto: Change cipher_kt_*_size to return size_t instead of int","message":"crypto: Change cipher_kt_*_size to return size_t instead of int\n\nOpenSSL uses int but never returns negative values.\nmbedTLS \u003c 4 uses size_t and mbedTLS \u003e\u003d 4 doesn\u0027t have\nits own implementation, so we can choose.\n\nSo choose size_t as a type that can take all these values.\nMaking this unsigned makes it easier in most cases to write\ncode that doesn\u0027t have sign-compare issues.\n\nAlso change cipher_ctx_iv_length and cipher_ctx_block_size\nto return an unsigned value for similar reasons. In that\ncase I did go for unsigned int since no implementation\nacutally requires size_t.\n\nChange-Id: I1bc576c4c7ffacbb9300608d98b06b22f2475fd9\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"053ee82885f7b4b696239879fac6047f06b7ddc6":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2026-02-04 13:36:43.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/08/1508/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/08/1508/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/3 \u0026\u0026 git checkout -b change-1508 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/08/1508/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3533430029544d58690adecec2bf56da094f6a0a","subject":"ssl_verify_openssl: Clean up extract_x509_extension"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-02 17:02:29.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-04 13:11:01.000000000","tz":60},"subject":"crypto: Change cipher_kt_*_size to return size_t instead of int","message":"crypto: Change cipher_kt_*_size to return size_t instead of int\n\nOpenSSL uses int but never returns negative values.\nmbedTLS \u003c 4 uses size_t and mbedTLS \u003e\u003d 4 doesn\u0027t have\nits own implementation, so we can choose.\n\nSo choose size_t as a type that can take all these values.\nMaking this unsigned makes it easier in most cases to write\ncode that doesn\u0027t have sign-compare issues.\n\nAlso change cipher_ctx_iv_length and cipher_ctx_block_size\nto return an unsigned value for similar reasons. In that\ncase I did go for unsigned int since no implementation\nacutally requires size_t.\n\nChange-Id: I1bc576c4c7ffacbb9300608d98b06b22f2475fd9\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"f738167cd935ae69d6b21b917e223b51ab34a52e":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2026-02-10 14:55:07.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/08/1508/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/08/1508/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/4 \u0026\u0026 git checkout -b change-1508 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/08/1508/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3cac7b6033286c1331ceb42715ba1f2beb6eb033","subject":"ssl_verify_openssl: Clean up extract_x509_extension"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-02 17:02:29.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-10 14:51:33.000000000","tz":60},"subject":"crypto: Change cipher_kt_*_size to return size_t instead of int","message":"crypto: Change cipher_kt_*_size to return size_t instead of int\n\nOpenSSL uses int but never returns negative values.\nmbedTLS \u003c 4 uses size_t and mbedTLS \u003e\u003d 4 doesn\u0027t have\nits own implementation, so we can choose.\n\nSo choose size_t as a type that can take all these values.\nMaking this unsigned makes it easier in most cases to write\ncode that doesn\u0027t have sign-compare issues.\n\nAlso change cipher_ctx_iv_length and cipher_ctx_block_size\nto return an unsigned value for similar reasons. In that\ncase I did go for unsigned int since no implementation\nacutally requires size_t.\n\nChange-Id: I1bc576c4c7ffacbb9300608d98b06b22f2475fd9\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"6b9bfa52ef5794b46776a363fa517002e052d87d":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2026-02-16 15:50:01.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/08/1508/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/08/1508/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/5 \u0026\u0026 git checkout -b change-1508 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/08/1508/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0ef959844e362e73ba7286a53c940b7ae769ad2e","subject":"ssl_verify_openssl: Clean up extract_x509_extension"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-02 17:02:29.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-16 15:48:30.000000000","tz":60},"subject":"crypto: Change cipher_kt_*_size to return size_t instead of int","message":"crypto: Change cipher_kt_*_size to return size_t instead of int\n\nOpenSSL uses int but never returns negative values.\nmbedTLS \u003c 4 uses size_t and mbedTLS \u003e\u003d 4 doesn\u0027t have\nits own implementation, so we can choose.\n\nSo choose size_t as a type that can take all these values.\nMaking this unsigned makes it easier in most cases to write\ncode that doesn\u0027t have sign-compare issues.\n\nAlso change cipher_ctx_iv_length and cipher_ctx_block_size\nto return an unsigned value for similar reasons. In that\ncase I did go for unsigned int since no implementation\nacutally requires size_t.\n\nChange-Id: I1bc576c4c7ffacbb9300608d98b06b22f2475fd9\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"b501eac26fcd695edf0d0189b4d9ff7cb978f898":{"kind":"TRIVIAL_REBASE","_number":6,"created":"2026-03-06 11:56:43.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/08/1508/6","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/08/1508/6","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/6 \u0026\u0026 git checkout -b change-1508 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/08/1508/6","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d191a7d27cd87fd23baf88af7a81d65357501fbc","subject":"ssl_verify_openssl: Clean up extract_x509_extension"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-02 17:02:29.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-06 11:52:04.000000000","tz":60},"subject":"crypto: Change cipher_kt_*_size to return size_t instead of int","message":"crypto: Change cipher_kt_*_size to return size_t instead of int\n\nOpenSSL uses int but never returns negative values.\nmbedTLS \u003c 4 uses size_t and mbedTLS \u003e\u003d 4 doesn\u0027t have\nits own implementation, so we can choose.\n\nSo choose size_t as a type that can take all these values.\nMaking this unsigned makes it easier in most cases to write\ncode that doesn\u0027t have sign-compare issues.\n\nAlso change cipher_ctx_iv_length and cipher_ctx_block_size\nto return an unsigned value for similar reasons. In that\ncase I did go for unsigned int since no implementation\nacutally requires size_t.\n\nChange-Id: I1bc576c4c7ffacbb9300608d98b06b22f2475fd9\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"e817bcae41bc70538062f1be32d2d7d33ea9bef7":{"kind":"REWORK","_number":7,"created":"2026-03-10 13:21:27.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/08/1508/7","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/08/1508/7","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/7 \u0026\u0026 git checkout -b change-1508 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/08/1508/7","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/7 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f16ec4f6a5bb95e81f952a11cdc8d434c26c7632","subject":"init: Avoid sign-compare warnings"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-02 17:02:29.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-10 13:14:53.000000000","tz":60},"subject":"crypto: Change cipher_kt_*_size to return unsigned instead of int","message":"crypto: Change cipher_kt_*_size to return unsigned instead of int\n\nOpenSSL uses int but never returns negative values.\nmbedTLS \u003c 4 uses size_t and mbedTLS \u003e\u003d 4 doesn\u0027t have\nits own implementation, so we can choose.\n\nWe chose unsigned int since size_t seems a bit silly for\nvalues that are never even close to UINT_MAX.\nMaking it unsigned makes it easier in most cases to write\ncode that doesn\u0027t have sign-compare issues.\n\nAlso change cipher_ctx_iv_length and cipher_ctx_block_size\nto return an unsigned value for similar reasons.\n\nv7:\n - switch to unsigned int instead of size_t\n\nChange-Id: I1bc576c4c7ffacbb9300608d98b06b22f2475fd9\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"e19a0bdc36c5d81007bc6f1bfdd817eac32dd393":{"kind":"TRIVIAL_REBASE","_number":8,"created":"2026-03-12 13:25:17.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/08/1508/8","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/08/1508/8","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/8 \u0026\u0026 git checkout -b change-1508 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/08/1508/8","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/8 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"54b5093c59c516e8465384f9a790a16f3f3d48d1","subject":"init: Avoid sign-compare warnings"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-02 17:02:29.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-12 13:24:59.000000000","tz":60},"subject":"crypto: Change cipher_kt_*_size to return unsigned instead of int","message":"crypto: Change cipher_kt_*_size to return unsigned instead of int\n\nOpenSSL uses int but never returns negative values.\nmbedTLS \u003c 4 uses size_t and mbedTLS \u003e\u003d 4 doesn\u0027t have\nits own implementation, so we can choose.\n\nWe chose unsigned int since size_t seems a bit silly for\nvalues that are never even close to UINT_MAX.\nMaking it unsigned makes it easier in most cases to write\ncode that doesn\u0027t have sign-compare issues.\n\nAlso change cipher_ctx_iv_length and cipher_ctx_block_size\nto return an unsigned value for similar reasons.\n\nv7:\n - switch to unsigned int instead of size_t\n\nChange-Id: I1bc576c4c7ffacbb9300608d98b06b22f2475fd9\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"beb57e9529440012317c3813319f54d1f714167d":{"kind":"TRIVIAL_REBASE","_number":9,"created":"2026-03-13 16:39:02.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/08/1508/9","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/08/1508/9","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/9 \u0026\u0026 git checkout -b change-1508 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/08/1508/9","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/9 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"806e38bc7e5d2500062f41183a06fc13a2c11b55","subject":"buffer: Avoid sign-compare warnings"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-02 17:02:29.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-13 15:56:32.000000000","tz":60},"subject":"crypto: Change cipher_kt_*_size to return unsigned instead of int","message":"crypto: Change cipher_kt_*_size to return unsigned instead of int\n\nOpenSSL uses int but never returns negative values.\nmbedTLS \u003c 4 uses size_t and mbedTLS \u003e\u003d 4 doesn\u0027t have\nits own implementation, so we can choose.\n\nWe chose unsigned int since size_t seems a bit silly for\nvalues that are never even close to UINT_MAX.\nMaking it unsigned makes it easier in most cases to write\ncode that doesn\u0027t have sign-compare issues.\n\nAlso change cipher_ctx_iv_length and cipher_ctx_block_size\nto return an unsigned value for similar reasons.\n\nv7:\n - switch to unsigned int instead of size_t\n\nChange-Id: I1bc576c4c7ffacbb9300608d98b06b22f2475fd9\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"b0c2174a9ee7bfdf40df5a728b84967bded555d7":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":10,"created":"2026-03-14 17:07:33.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/08/1508/10","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/08/1508/10","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/10 \u0026\u0026 git checkout -b change-1508 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/08/1508/10","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/08/1508/10 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c26437c0d38b5325e26c4f77775c2fd2e60bcff4","subject":"doc: fix typo with --ingore-unknown-option"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-13 17:52:04.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-03-14 17:01:22.000000000","tz":60},"subject":"crypto: Change cipher_kt_*_size to return unsigned instead of int","message":"crypto: Change cipher_kt_*_size to return unsigned instead of int\n\nOpenSSL uses int but never returns negative values.\nmbedTLS \u003c 4 uses size_t and mbedTLS \u003e\u003d 4 doesn\u0027t have\nits own implementation, so we can choose.\n\nWe chose unsigned int since size_t seems a bit silly for\nvalues that are never even close to UINT_MAX.\nMaking it unsigned makes it easier in most cases to write\ncode that doesn\u0027t have sign-compare issues.\n\nAlso change cipher_ctx_iv_length and cipher_ctx_block_size\nto return an unsigned value for similar reasons.\n\nv7:\n - switch to unsigned int instead of size_t\n\nChange-Id: I1bc576c4c7ffacbb9300608d98b06b22f2475fd9\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1508\nMessage-Id: \u003c20260313175209.12024-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36114.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}