)]}'
{"id":"openvpn~1510","triplet_id":"openvpn~master~I73dba29719ea685f0427a3c479e7f1f176f09eba","project":"openvpn","branch":"master","topic":"wextra","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-03-12 17:03:47.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-03-26 16:49:56.000000000","reason":"Change was submitted"}},"hashtags":["mailsubmitted"],"change_id":"I73dba29719ea685f0427a3c479e7f1f176f09eba","subject":"auth_token: Clean up type handling in verify_auth_token and its UT","status":"MERGED","created":"2026-02-06 12:02:49.000000000","updated":"2026-03-26 16:49:56.000000000","submitted":"2026-03-26 16:49:56.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1510-wextra","meta_rev_id":"96aeaedb118e796af4eb455e85ca4226125957af","_number":1510,"virtual_id_number":1510,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-02-06 12:02:50.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-02-06 12:02:50.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"c690525de70efea1a410022c0ea793166e688dcc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-06 12:02:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8748b8ab8c9471bb36ea1ea3470c214f6dde084a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-10 14:55:07.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"c940dfebf1f0f4cfc299ad411fbe86c3d9db106c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-16 15:50:01.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"9dcda04af9bfbafa670839a518897332ccb89b08","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-06 11:56:43.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"4128fb6026bc63ed40759a321d7f817b30f30954","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-10 13:21:27.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.","accounts_in_message":[],"_revision_number":5},{"id":"29d071ca620814866d062e5b036a53bb94f4bc78","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-12 13:25:17.000000000","message":"Uploaded patch set 6: Patch Set 5 was rebased.","accounts_in_message":[],"_revision_number":6},{"id":"76cf6f6a65e6513a2a3bd9563205217a0871b47e","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-03-12 17:03:47.000000000","message":"Patch Set 6: Code-Review+2","accounts_in_message":[],"_revision_number":6},{"id":"dd8def6ac6f661c7e711833d368dbdff6a7f7dd3","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-13 10:48:22.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":6},{"id":"6617527354c1e7fb143e697a7ff4b364263cae14","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-16 11:56:47.000000000","message":"Uploaded patch set 7: Patch Set 6 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":7},{"id":"973f88dbe8f3f8ffa50b96cdedb10cee52786b00","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-23 17:11:18.000000000","message":"Uploaded patch set 8: Patch Set 7 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":8},{"id":"96aeaedb118e796af4eb455e85ca4226125957af","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-03-26 16:49:56.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":9}],"current_revision_number":9,"current_revision":"5933af1620a93bb06b8c48b6f1f0eb23ed13cbf9","revisions":{"c736915e0eecb65db66fc52d12c957771d6db973":{"kind":"REWORK","_number":1,"created":"2026-02-06 12:02:49.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/10/1510/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/10/1510/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/1 \u0026\u0026 git checkout -b change-1510 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/10/1510/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"053ee82885f7b4b696239879fac6047f06b7ddc6","subject":"crypto: Change cipher_kt_*_size to return size_t instead of int"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-06 11:56:47.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-06 11:56:47.000000000","tz":60},"subject":"auth_token: Clean up type handling in verify_auth_token and its UT","message":"auth_token: Clean up type handling in verify_auth_token and its UT\n\nFirst of all remove the testing of renegotiation_seconds.\nCommit 9a5161704173e31f2510d3f5c29361f76e275d0f made it\nirrelevant for verify_auth_token but still left UTs for it.\nBut AFAICT these UTs only test that renegotiation_seconds\nis bigger than auth_token_renewal, so it tests the UT\nsetup routine...\n\nAlso improve the code to require less casts under\n-Wsign-compare.\n\nAdd a comment that this code is not y38 safe if time_t\nis 32bit. Probably nothing we want to do from our side\nsince in that case everything that uses \"now\" is borked.\nSo we trust in the OS here...\n\nChange-Id: I73dba29719ea685f0427a3c479e7f1f176f09eba\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"6f7810af7701fa80022923fca610f1c141a2bd5a":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-02-10 14:55:07.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/10/1510/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/10/1510/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/2 \u0026\u0026 git checkout -b change-1510 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/10/1510/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f738167cd935ae69d6b21b917e223b51ab34a52e","subject":"crypto: Change cipher_kt_*_size to return size_t instead of int"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-06 11:56:47.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-10 14:51:33.000000000","tz":60},"subject":"auth_token: Clean up type handling in verify_auth_token and its UT","message":"auth_token: Clean up type handling in verify_auth_token and its UT\n\nFirst of all remove the testing of renegotiation_seconds.\nCommit 9a5161704173e31f2510d3f5c29361f76e275d0f made it\nirrelevant for verify_auth_token but still left UTs for it.\nBut AFAICT these UTs only test that renegotiation_seconds\nis bigger than auth_token_renewal, so it tests the UT\nsetup routine...\n\nAlso improve the code to require less casts under\n-Wsign-compare.\n\nAdd a comment that this code is not y38 safe if time_t\nis 32bit. Probably nothing we want to do from our side\nsince in that case everything that uses \"now\" is borked.\nSo we trust in the OS here...\n\nChange-Id: I73dba29719ea685f0427a3c479e7f1f176f09eba\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"66c7f4f44a9ecefe7fbb122cd628f6cbf5edfe86":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2026-02-16 15:50:01.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/10/1510/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/10/1510/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/3 \u0026\u0026 git checkout -b change-1510 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/10/1510/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6b9bfa52ef5794b46776a363fa517002e052d87d","subject":"crypto: Change cipher_kt_*_size to return size_t instead of int"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-06 11:56:47.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-16 15:48:30.000000000","tz":60},"subject":"auth_token: Clean up type handling in verify_auth_token and its UT","message":"auth_token: Clean up type handling in verify_auth_token and its UT\n\nFirst of all remove the testing of renegotiation_seconds.\nCommit 9a5161704173e31f2510d3f5c29361f76e275d0f made it\nirrelevant for verify_auth_token but still left UTs for it.\nBut AFAICT these UTs only test that renegotiation_seconds\nis bigger than auth_token_renewal, so it tests the UT\nsetup routine...\n\nAlso improve the code to require less casts under\n-Wsign-compare.\n\nAdd a comment that this code is not y38 safe if time_t\nis 32bit. Probably nothing we want to do from our side\nsince in that case everything that uses \"now\" is borked.\nSo we trust in the OS here...\n\nChange-Id: I73dba29719ea685f0427a3c479e7f1f176f09eba\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"36560eb326554f20d77554c6f1e97b4ad7c6efca":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2026-03-06 11:56:43.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/10/1510/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/10/1510/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/4 \u0026\u0026 git checkout -b change-1510 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/10/1510/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b501eac26fcd695edf0d0189b4d9ff7cb978f898","subject":"crypto: Change cipher_kt_*_size to return size_t instead of int"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-06 11:56:47.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-06 11:52:04.000000000","tz":60},"subject":"auth_token: Clean up type handling in verify_auth_token and its UT","message":"auth_token: Clean up type handling in verify_auth_token and its UT\n\nFirst of all remove the testing of renegotiation_seconds.\nCommit 9a5161704173e31f2510d3f5c29361f76e275d0f made it\nirrelevant for verify_auth_token but still left UTs for it.\nBut AFAICT these UTs only test that renegotiation_seconds\nis bigger than auth_token_renewal, so it tests the UT\nsetup routine...\n\nAlso improve the code to require less casts under\n-Wsign-compare.\n\nAdd a comment that this code is not y38 safe if time_t\nis 32bit. Probably nothing we want to do from our side\nsince in that case everything that uses \"now\" is borked.\nSo we trust in the OS here...\n\nChange-Id: I73dba29719ea685f0427a3c479e7f1f176f09eba\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"cfc1c9279d0623014e4ce9a677a692cac980c622":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2026-03-10 13:21:27.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/10/1510/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/10/1510/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/5 \u0026\u0026 git checkout -b change-1510 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/10/1510/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3abc1c49b4e5d73006aaf430a2f159b12c206f1e","subject":"wfp_block: Avoid sign-compare warning with Fwpm* return types"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-06 11:56:47.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-10 13:14:53.000000000","tz":60},"subject":"auth_token: Clean up type handling in verify_auth_token and its UT","message":"auth_token: Clean up type handling in verify_auth_token and its UT\n\nFirst of all remove the testing of renegotiation_seconds.\nCommit 9a5161704173e31f2510d3f5c29361f76e275d0f made it\nirrelevant for verify_auth_token but still left UTs for it.\nBut AFAICT these UTs only test that renegotiation_seconds\nis bigger than auth_token_renewal, so it tests the UT\nsetup routine...\n\nAlso improve the code to require less casts under\n-Wsign-compare.\n\nAdd a comment that this code is not y38 safe if time_t\nis 32bit. Probably nothing we want to do from our side\nsince in that case everything that uses \"now\" is borked.\nSo we trust in the OS here...\n\nChange-Id: I73dba29719ea685f0427a3c479e7f1f176f09eba\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"f0cbd606a991685130726dba62859b6b5c60ae30":{"kind":"TRIVIAL_REBASE","_number":6,"created":"2026-03-12 13:25:17.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/10/1510/6","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/10/1510/6","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/6 \u0026\u0026 git checkout -b change-1510 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/10/1510/6","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"dce5f7af581582106eff92281ff3b7eb47b2c84c","subject":"wfp_block: Avoid sign-compare warning with Fwpm* return types"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-06 11:56:47.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-12 11:00:06.000000000","tz":60},"subject":"auth_token: Clean up type handling in verify_auth_token and its UT","message":"auth_token: Clean up type handling in verify_auth_token and its UT\n\nFirst of all remove the testing of renegotiation_seconds.\nCommit 9a5161704173e31f2510d3f5c29361f76e275d0f made it\nirrelevant for verify_auth_token but still left UTs for it.\nBut AFAICT these UTs only test that renegotiation_seconds\nis bigger than auth_token_renewal, so it tests the UT\nsetup routine...\n\nAlso improve the code to require less casts under\n-Wsign-compare.\n\nAdd a comment that this code is not y38 safe if time_t\nis 32bit. Probably nothing we want to do from our side\nsince in that case everything that uses \"now\" is borked.\nSo we trust in the OS here...\n\nChange-Id: I73dba29719ea685f0427a3c479e7f1f176f09eba\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"fddd19a5cf2f6c79ca239e15d3f64c8c9a2e0b36":{"kind":"TRIVIAL_REBASE","_number":7,"created":"2026-03-16 11:56:47.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/10/1510/7","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/10/1510/7","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/7 \u0026\u0026 git checkout -b change-1510 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/10/1510/7","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/7 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f0082905ed610a1d9a89475ef02cad0ebe818b89","subject":"wfp_block: Avoid sign-compare warning with Fwpm* return types"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-06 11:56:47.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-16 11:55:06.000000000","tz":60},"subject":"auth_token: Clean up type handling in verify_auth_token and its UT","message":"auth_token: Clean up type handling in verify_auth_token and its UT\n\nFirst of all remove the testing of renegotiation_seconds.\nCommit 9a5161704173e31f2510d3f5c29361f76e275d0f made it\nirrelevant for verify_auth_token but still left UTs for it.\nBut AFAICT these UTs only test that renegotiation_seconds\nis bigger than auth_token_renewal, so it tests the UT\nsetup routine...\n\nAlso improve the code to require less casts under\n-Wsign-compare.\n\nAdd a comment that this code is not y38 safe if time_t\nis 32bit. Probably nothing we want to do from our side\nsince in that case everything that uses \"now\" is borked.\nSo we trust in the OS here...\n\nChange-Id: I73dba29719ea685f0427a3c479e7f1f176f09eba\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"5815349269d6f8bcd18d75efefa526d054e4a6ad":{"kind":"TRIVIAL_REBASE","_number":8,"created":"2026-03-23 17:11:18.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/10/1510/8","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/10/1510/8","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/8 \u0026\u0026 git checkout -b change-1510 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/10/1510/8","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/8 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1fd2ec69b47a8ed29ffb71a166dc67d64cc1c451","subject":"wfp_block: Avoid sign-compare warning with Fwpm* return types"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-06 11:56:47.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-23 17:11:11.000000000","tz":60},"subject":"auth_token: Clean up type handling in verify_auth_token and its UT","message":"auth_token: Clean up type handling in verify_auth_token and its UT\n\nFirst of all remove the testing of renegotiation_seconds.\nCommit 9a5161704173e31f2510d3f5c29361f76e275d0f made it\nirrelevant for verify_auth_token but still left UTs for it.\nBut AFAICT these UTs only test that renegotiation_seconds\nis bigger than auth_token_renewal, so it tests the UT\nsetup routine...\n\nAlso improve the code to require less casts under\n-Wsign-compare.\n\nAdd a comment that this code is not y38 safe if time_t\nis 32bit. Probably nothing we want to do from our side\nsince in that case everything that uses \"now\" is borked.\nSo we trust in the OS here...\n\nChange-Id: I73dba29719ea685f0427a3c479e7f1f176f09eba\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"5933af1620a93bb06b8c48b6f1f0eb23ed13cbf9":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":9,"created":"2026-03-26 16:49:56.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/10/1510/9","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/10/1510/9","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/9 \u0026\u0026 git checkout -b change-1510 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/10/1510/9","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1510/9 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7b5ebf7c447db16953c9541fdd00c7aa56124fc5","subject":"Increase default size of internal hash maps to 4 * --max-clients"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-12 17:31:38.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-03-26 16:46:10.000000000","tz":60},"subject":"auth_token: Clean up type handling in verify_auth_token and its UT","message":"auth_token: Clean up type handling in verify_auth_token and its UT\n\nFirst of all remove the testing of renegotiation_seconds.\nCommit 9a5161704173e31f2510d3f5c29361f76e275d0f made it\nirrelevant for verify_auth_token but still left UTs for it.\nBut AFAICT these UTs only test that renegotiation_seconds\nis bigger than auth_token_renewal, so it tests the UT\nsetup routine...\n\nAlso improve the code to require less casts under\n-Wsign-compare.\n\nAdd a comment that this code is not y38 safe if time_t\nis 32bit. Probably nothing we want to do from our side\nsince in that case everything that uses \"now\" is borked.\nSo we trust in the OS here...\n\nChange-Id: I73dba29719ea685f0427a3c479e7f1f176f09eba\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1510\nMessage-Id: \u003c20260312173144.15602-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36079.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}