)]}'
{"id":"openvpn~1513","triplet_id":"openvpn~master~I3eb4581980f532cb2960b37a6fa43a7baee4b603","project":"openvpn","branch":"master","topic":"wextra","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-03-07 09:11:03.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-03-07 09:11:03.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I3eb4581980f532cb2960b37a6fa43a7baee4b603","subject":"Fix various sign-compare warnings due to write return value","status":"MERGED","created":"2026-02-10 14:55:07.000000000","updated":"2026-03-07 09:11:03.000000000","submitted":"2026-03-07 09:11:03.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1513-wextra","meta_rev_id":"4f64808f8ece5a3fa78e6aaa6381a7655e6d6d76","_number":1513,"virtual_id_number":1513,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}],"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-02-10 14:55:29.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-02-10 14:55:29.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-03-06 16:33:24.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"d7f7d9f4efa4c82aa8b41d15ba8042e6fd87fa1f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-10 14:55:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fb87da1c67687d24c815ebdb7367736bb052fa29","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-16 15:50:01.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"b0d66f9fb29a0eaa43b89dce1165acb1df5de837","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-06 11:56:43.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"7697da244697d6b196324a60bdfdae558121d42a","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-03-06 16:33:24.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"4f64808f8ece5a3fa78e6aaa6381a7655e6d6d76","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-03-07 09:11:03.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"0401eacfe255ccd7b41fa594e004fddeb8ba1a24","revisions":{"e0bfc0b6652f2657032581694dc527c1ab7def1d":{"kind":"REWORK","_number":1,"created":"2026-02-10 14:55:07.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/13/1513/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/13/1513/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1513/1 \u0026\u0026 git checkout -b change-1513 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1513/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1513/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1513/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/13/1513/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1513/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6f7810af7701fa80022923fca610f1c141a2bd5a","subject":"auth_token: Clean up type handling in verify_auth_token and its UT"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-10 14:43:05.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-10 14:51:33.000000000","tz":60},"subject":"Fix various sign-compare warnings due to write return value","message":"Fix various sign-compare warnings due to write return value\n\nwrite takes size_t as count (unsigned int on\nWindows) and returns ssize_t (int on Windows).\nBut we often want to compare the return value\nto the count.\n\nGenerally we can just rely on the fact that\nsizeof(ssize_t) \u003d\u003d sizeof(size_t) and use that\nfor all values. (Until we want to introduce\n-Wsign-conversion that is...)\n\nChange-Id: I3eb4581980f532cb2960b37a6fa43a7baee4b603\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"17a4da9c5623e26b102ed22fb20ff7bb8ac80271":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-02-16 15:50:01.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/13/1513/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/13/1513/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1513/2 \u0026\u0026 git checkout -b change-1513 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1513/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1513/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1513/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/13/1513/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1513/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"66c7f4f44a9ecefe7fbb122cd628f6cbf5edfe86","subject":"auth_token: Clean up type handling in verify_auth_token and its UT"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-10 14:43:05.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-16 15:48:30.000000000","tz":60},"subject":"Fix various sign-compare warnings due to write return value","message":"Fix various sign-compare warnings due to write return value\n\nwrite takes size_t as count (unsigned int on\nWindows) and returns ssize_t (int on Windows).\nBut we often want to compare the return value\nto the count.\n\nGenerally we can just rely on the fact that\nsizeof(ssize_t) \u003d\u003d sizeof(size_t) and use that\nfor all values. (Until we want to introduce\n-Wsign-conversion that is...)\n\nChange-Id: I3eb4581980f532cb2960b37a6fa43a7baee4b603\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"548d81ce5d3af8cb6606adef5b6a39ae290cc120":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2026-03-06 11:56:43.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/13/1513/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/13/1513/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1513/3 \u0026\u0026 git checkout -b change-1513 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1513/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1513/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1513/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/13/1513/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1513/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"36560eb326554f20d77554c6f1e97b4ad7c6efca","subject":"auth_token: Clean up type handling in verify_auth_token and its UT"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-10 14:43:05.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-06 11:52:04.000000000","tz":60},"subject":"Fix various sign-compare warnings due to write return value","message":"Fix various sign-compare warnings due to write return value\n\nwrite takes size_t as count (unsigned int on\nWindows) and returns ssize_t (int on Windows).\nBut we often want to compare the return value\nto the count.\n\nGenerally we can just rely on the fact that\nsizeof(ssize_t) \u003d\u003d sizeof(size_t) and use that\nfor all values. (Until we want to introduce\n-Wsign-conversion that is...)\n\nChange-Id: I3eb4581980f532cb2960b37a6fa43a7baee4b603\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"0401eacfe255ccd7b41fa594e004fddeb8ba1a24":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2026-03-07 09:11:03.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/13/1513/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/13/1513/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1513/4 \u0026\u0026 git checkout -b change-1513 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1513/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1513/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1513/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/13/1513/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1513/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5f7b1c548b69e0ba0c54bfb63c94243c4ffaea97","subject":"Use USER_PASS_LEN for private key password buffer size"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-06 16:33:31.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-03-07 09:08:17.000000000","tz":60},"subject":"Fix various sign-compare warnings due to write return value","message":"Fix various sign-compare warnings due to write return value\n\nwrite takes size_t as count (unsigned int on\nWindows) and returns ssize_t (int on Windows).\nBut we often want to compare the return value\nto the count.\n\nGenerally we can just rely on the fact that\nsizeof(ssize_t) \u003d\u003d sizeof(size_t) and use that\nfor all values. (Until we want to introduce\n-Wsign-conversion that is...)\n\nChange-Id: I3eb4581980f532cb2960b37a6fa43a7baee4b603\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1513\nMessage-Id: \u003c20260306163337.2756-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg35963.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}