)]}'
{"id":"openvpn~1517","triplet_id":"openvpn~master~I14395665f197349e374a81b56f28536ff88937a8","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-02-11 11:36:32.000000000","reason":"removed on reply"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2026-02-16 14:54:39.000000000","reason":"Change was submitted"}},"hashtags":["mailsubmitted"],"change_id":"I14395665f197349e374a81b56f28536ff88937a8","subject":"rework all occurrences of \u0027M_ERR | M_ERRNO\u0027","status":"MERGED","created":"2026-02-11 08:53:18.000000000","updated":"2026-02-16 14:54:39.000000000","submitted":"2026-02-16 14:54:39.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1517","meta_rev_id":"ecc92bd401cf4232b64465a562da05f8ff7e32ba","_number":1517,"virtual_id_number":1517,"owner":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-02-11 08:53:19.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-02-11 08:53:19.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"54927277eb0b813ba8e14c116fc82e30981a25cf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-02-11 08:53:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"60d68f5858cedb0067da7d886a91d54dda2f8026","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-02-11 11:36:32.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"cf361922ad5adb90872b61de71d72526644081b3","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-11 15:06:59.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":1},{"id":"ecc92bd401cf4232b64465a562da05f8ff7e32ba","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-02-16 14:54:39.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"f349b0a61499d3d36e69e2aa4dbbb7692b7d1df8","revisions":{"9c55ae9d841b13dcd9a26fb5b92425fd16e8fd2f":{"kind":"REWORK","_number":1,"created":"2026-02-11 08:53:18.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/17/1517/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/17/1517/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/17/1517/1 \u0026\u0026 git checkout -b change-1517 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/17/1517/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/17/1517/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/17/1517/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/17/1517/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/17/1517/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"44a5b330210ef1f1fd371a178bb0b1aefdab8088","subject":"Update the clang-format reference version to 21.1.8"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-02-11 08:48:08.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-02-11 08:52:05.000000000","tz":60},"subject":"rework all occurrences of \u0027M_ERR | M_ERRNO\u0027","message":"rework all occurrences of \u0027M_ERR | M_ERRNO\u0027\n\nM_ERR is defined as (M_FATAL | M_ERRNO), so \u0027msg(M_ERR | M_ERRNO, ...)\u0027\nis just the same as \u0027msg(M_ERR, ...)\u0027.\n\nThe occurances in tun.c and dco_freebsd.c are really \"if this happens,\nwe can not go on\" errors, so \u0027M_ERR\u0027 (\u003d FATAL, plus log errno string)\nis the correct thing to do.\n\nThe occurances in dns.c do come with error handling and cleanup after\nthe msg() call, so the right thing is \u0027M_WARN | M_ERRNO\u0027 instead\n(warning, plus log errno string).\n\nGithub: fixes OpenVPN/openvpn#939\n\nChange-Id: I14395665f197349e374a81b56f28536ff88937a8\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"f349b0a61499d3d36e69e2aa4dbbb7692b7d1df8":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2026-02-16 14:54:39.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/17/1517/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/17/1517/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/17/1517/2 \u0026\u0026 git checkout -b change-1517 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/17/1517/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/17/1517/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/17/1517/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/17/1517/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/17/1517/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"344f13fcdfc159277e7ba7d28e23537d718e7cef","subject":"clang-format: Add missing InsertBraces: true"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-02-11 15:06:48.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-02-16 14:52:26.000000000","tz":60},"subject":"rework all occurrences of \u0027M_ERR | M_ERRNO\u0027","message":"rework all occurrences of \u0027M_ERR | M_ERRNO\u0027\n\nM_ERR is defined as (M_FATAL | M_ERRNO), so \u0027msg(M_ERR | M_ERRNO, ...)\u0027\nis just the same as \u0027msg(M_ERR, ...)\u0027.\n\nThe occurances in tun.c and dco_freebsd.c are really \"if this happens,\nwe can not go on\" errors, so \u0027M_ERR\u0027 (\u003d FATAL, plus log errno string)\nis the correct thing to do.\n\nThe occurances in dns.c do come with error handling and cleanup after\nthe msg() call, so the right thing is \u0027M_WARN | M_ERRNO\u0027 instead\n(warning, plus log errno string).\n\nGithub: fixes OpenVPN/openvpn#939\n\nChange-Id: I14395665f197349e374a81b56f28536ff88937a8\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1517\nMessage-Id: \u003c20260211150648.113547-1-frank@lichtenheld.com\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg35594.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}