)]}'
{"id":"openvpn~1523","triplet_id":"openvpn~master~Idf5ce8f82e7727505cce67560e0b7423b8e41a40","project":"openvpn","branch":"master","topic":"wextra","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-03-12 07:38:44.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-03-12 07:38:44.000000000","reason":"Change was submitted"}},"hashtags":["mailsubmitted"],"change_id":"Idf5ce8f82e7727505cce67560e0b7423b8e41a40","subject":"socket: Avoid sign-compare issue by comparing before assignment","status":"MERGED","created":"2026-02-13 18:44:44.000000000","updated":"2026-03-12 07:38:44.000000000","submitted":"2026-03-12 07:38:44.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1523-wextra","meta_rev_id":"e3de1cd1ef8816305784948febd92196161d3d8a","_number":1523,"virtual_id_number":1523,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-02-13 18:44:45.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-02-13 18:44:45.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-03-06 16:31:50.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"abd07e42722289cc592898d22aa6b3b30be1a88d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-13 18:44:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"06ca371125e90b40b088327412c1077b1b18265d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-16 15:50:01.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"7696f0698bee2fb21e417169566408d3abc71483","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-06 11:56:43.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"58d2ae0907c5074122658b8ac34f77edc7f982cc","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-03-06 16:31:50.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"d74e08554619d0f88f782b77969a62347ec2ed5a","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-09 13:35:11.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":3},{"id":"09f0af54cb9b950520d24319486c9126cb4bc88c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-10 13:21:27.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":4},{"id":"e3de1cd1ef8816305784948febd92196161d3d8a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-03-12 07:38:44.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"45f52d3aef2c014127e9a9d19368ee6c0547c1a2","revisions":{"1bda6dca19ce6cd59e18c1faaac75122493d22e9":{"kind":"REWORK","_number":1,"created":"2026-02-13 18:44:44.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/23/1523/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/23/1523/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1523/1 \u0026\u0026 git checkout -b change-1523 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1523/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1523/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1523/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/23/1523/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1523/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"63c2048c6c7fd1fdce6828633268947b7a7f1c75","subject":"DNS/DHCP: Make _len attributes consistently unsigned"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-13 18:30:14.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-13 18:30:14.000000000","tz":60},"subject":"socket: Avoid sign-compare issue by comparing before assignment","message":"socket: Avoid sign-compare issue by comparing before assignment\n\nThe assignment implicitly converts the values, but\nwe can just do the comparison before the assignment.\n\nChange-Id: Idf5ce8f82e7727505cce67560e0b7423b8e41a40\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"c52c6ba1e5f9bb4452e3befef5a3c33d9d85241e":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-02-16 15:50:01.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/23/1523/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/23/1523/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1523/2 \u0026\u0026 git checkout -b change-1523 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1523/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1523/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1523/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/23/1523/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1523/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d8d9b089dd5c1f04e6167036bef8984ec4c6abf2","subject":"DNS/DHCP: Make _len attributes consistently unsigned"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-13 18:30:14.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-16 15:48:30.000000000","tz":60},"subject":"socket: Avoid sign-compare issue by comparing before assignment","message":"socket: Avoid sign-compare issue by comparing before assignment\n\nThe assignment implicitly converts the values, but\nwe can just do the comparison before the assignment.\n\nChange-Id: Idf5ce8f82e7727505cce67560e0b7423b8e41a40\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"4d103dbc2a62cd2df98179fa706c5aff68e6088d":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2026-03-06 11:56:43.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/23/1523/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/23/1523/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1523/3 \u0026\u0026 git checkout -b change-1523 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1523/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1523/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1523/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/23/1523/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1523/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8bd6b87e1718e50860f2e8d87dddcef29ce28806","subject":"DNS/DHCP: Make _len attributes consistently unsigned"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-13 18:30:14.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-06 11:52:04.000000000","tz":60},"subject":"socket: Avoid sign-compare issue by comparing before assignment","message":"socket: Avoid sign-compare issue by comparing before assignment\n\nThe assignment implicitly converts the values, but\nwe can just do the comparison before the assignment.\n\nChange-Id: Idf5ce8f82e7727505cce67560e0b7423b8e41a40\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"ec584a0d5b1ba14a8a3a53c74e3892de2bc18343":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2026-03-10 13:21:27.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/23/1523/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/23/1523/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1523/4 \u0026\u0026 git checkout -b change-1523 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1523/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1523/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1523/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/23/1523/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1523/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b955c5fdef186273de0385757ceae8dcebc11972","subject":"DNS/DHCP: Make _len attributes consistently unsigned"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-13 18:30:14.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-10 13:14:53.000000000","tz":60},"subject":"socket: Avoid sign-compare issue by comparing before assignment","message":"socket: Avoid sign-compare issue by comparing before assignment\n\nThe assignment implicitly converts the values, but\nwe can just do the comparison before the assignment.\n\nChange-Id: Idf5ce8f82e7727505cce67560e0b7423b8e41a40\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"45f52d3aef2c014127e9a9d19368ee6c0547c1a2":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":5,"created":"2026-03-12 07:38:44.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/23/1523/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/23/1523/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1523/5 \u0026\u0026 git checkout -b change-1523 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1523/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1523/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1523/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/23/1523/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1523/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"28a7bd69953af35f976a4005835523a65e13e558","subject":"DNS/DHCP: Make _len attributes consistently unsigned"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-06 16:31:56.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-03-12 07:36:17.000000000","tz":60},"subject":"socket: Avoid sign-compare issue by comparing before assignment","message":"socket: Avoid sign-compare issue by comparing before assignment\n\nThe assignment implicitly converts the values, but\nwe can just do the comparison before the assignment.\n\nChange-Id: Idf5ce8f82e7727505cce67560e0b7423b8e41a40\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1523\nMessage-Id: \u003c20260306163202.2586-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg35961.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}