)]}'
{"id":"openvpn~1525","triplet_id":"openvpn~master~Ifc7ad2407b9cca8cfcef79d7392a058735416139","project":"openvpn","branch":"master","topic":"wextra","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-03-11 14:57:37.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-03-11 14:57:37.000000000","reason":"Change was submitted"}},"hashtags":["mailsubmitted"],"change_id":"Ifc7ad2407b9cca8cfcef79d7392a058735416139","subject":"tun: Avoid sign-compare issues in tun_read_queue","status":"MERGED","created":"2026-02-13 18:44:44.000000000","updated":"2026-03-11 14:57:37.000000000","submitted":"2026-03-11 14:57:37.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1525-wextra","meta_rev_id":"da9f0f1ef78e949335371bc4391c7bf82bdbb099","_number":1525,"virtual_id_number":1525,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-02-13 18:44:46.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-02-13 18:44:46.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-03-06 16:29:10.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"ee1b990adba9d3601394dd8b066fa578153d7162","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-13 18:44:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5fc6df385658c3f9f386cef3a2bd95f3c1cc30d5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-16 15:50:01.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"84fac2cae78788af148d554cdf99d1f7aa5242b6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-06 11:56:43.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"25ee0cfe4ff8326c73e2efec0d9f4cfda90c5d14","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-03-06 16:29:10.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"ccd5068db1a8631bae63f7df1f91ec5597bca4aa","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-09 13:31:37.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":3},{"id":"eabab701c4e2ded64fd8450ca933d6a4fdbe7765","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-10 13:21:27.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":4},{"id":"da9f0f1ef78e949335371bc4391c7bf82bdbb099","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-03-11 14:57:37.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"4f98585e40ee370ace71cd6ef379d01b4c516460","revisions":{"894fca676be200ed47da647375c3b57f222bd122":{"kind":"REWORK","_number":1,"created":"2026-02-13 18:44:44.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/25/1525/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/25/1525/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/1525/1 \u0026\u0026 git checkout -b change-1525 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/1525/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/1525/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/1525/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/25/1525/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/1525/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fb05435db73e537759254b6dc85aea996f28e6c1","subject":"tls_crypt: Avoid a sign-compare warning"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-13 18:34:43.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-13 18:34:43.000000000","tz":60},"subject":"tun: Avoid sign-compare issues in tun_read_queue","message":"tun: Avoid sign-compare issues in tun_read_queue\n\nJust use the same type that the other values\nalready have.\n\nWhile here review and remove some other useless\ncasts in msg() calls.\n\nChange-Id: Ifc7ad2407b9cca8cfcef79d7392a058735416139\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"c9b02fbdbda6e7425af7d4ac73e9ead578388afb":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-02-16 15:50:01.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/25/1525/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/25/1525/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/1525/2 \u0026\u0026 git checkout -b change-1525 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/1525/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/1525/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/1525/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/25/1525/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/1525/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d90e8195c8cf38892cb4ed28ee72756ee3443cbd","subject":"tls_crypt: Avoid a sign-compare warning"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-13 18:34:43.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-16 15:48:30.000000000","tz":60},"subject":"tun: Avoid sign-compare issues in tun_read_queue","message":"tun: Avoid sign-compare issues in tun_read_queue\n\nJust use the same type that the other values\nalready have.\n\nWhile here review and remove some other useless\ncasts in msg() calls.\n\nChange-Id: Ifc7ad2407b9cca8cfcef79d7392a058735416139\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"a5aeaec0bd064a5242546fd05c4d4f12da28f109":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2026-03-06 11:56:43.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/25/1525/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/25/1525/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/1525/3 \u0026\u0026 git checkout -b change-1525 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/1525/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/1525/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/1525/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/25/1525/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/1525/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9711dc552166b5d3c28f9e123a8ca5dcd23b5b00","subject":"tls_crypt: Avoid a sign-compare warning"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-13 18:34:43.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-06 11:52:04.000000000","tz":60},"subject":"tun: Avoid sign-compare issues in tun_read_queue","message":"tun: Avoid sign-compare issues in tun_read_queue\n\nJust use the same type that the other values\nalready have.\n\nWhile here review and remove some other useless\ncasts in msg() calls.\n\nChange-Id: Ifc7ad2407b9cca8cfcef79d7392a058735416139\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"a8a6f3e86d6b2d53c4797d95bf024b22fecffffa":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2026-03-10 13:21:27.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/25/1525/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/25/1525/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/1525/4 \u0026\u0026 git checkout -b change-1525 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/1525/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/1525/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/1525/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/25/1525/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/1525/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c822bbdec3ba41f5f10e925809eff71d5168e9d1","subject":"tls_crypt: Avoid a sign-compare warning"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-13 18:34:43.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-10 13:14:53.000000000","tz":60},"subject":"tun: Avoid sign-compare issues in tun_read_queue","message":"tun: Avoid sign-compare issues in tun_read_queue\n\nJust use the same type that the other values\nalready have.\n\nWhile here review and remove some other useless\ncasts in msg() calls.\n\nChange-Id: Ifc7ad2407b9cca8cfcef79d7392a058735416139\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"4f98585e40ee370ace71cd6ef379d01b4c516460":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":5,"created":"2026-03-11 14:57:37.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/25/1525/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/25/1525/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/1525/5 \u0026\u0026 git checkout -b change-1525 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/1525/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/1525/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/1525/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/25/1525/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/1525/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"66060627a8cf05c8761d75985e76482d20df4f29","subject":"ssl_verify_openssl: Clean up extract_x509_extension"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-06 16:29:19.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-03-11 14:55:47.000000000","tz":60},"subject":"tun: Avoid sign-compare issues in tun_read_queue","message":"tun: Avoid sign-compare issues in tun_read_queue\n\nJust use the same type that the other values\nalready have.\n\nWhile here review and remove some other useless\ncasts in msg() calls.\n\nChange-Id: Ifc7ad2407b9cca8cfcef79d7392a058735416139\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1525\nMessage-Id: \u003c20260306162925.2359-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg35956.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}