)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"change_message_id":"a93953600ceedf00941eb9c81923805772a4273b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"24fefb47_9b5229f8","updated":"2026-02-16 01:35:08.000000000","message":"If any client/UI/GUI is already using this command via some internal work-around, this patch may potentially break it depending on how robust the work-around is. Alternative is to respond only if the management-client version being set is \u003e\u003d 3. Currently documented max version is 2.","commit_id":"01025edc9b0875a8c4bfe7d1e2fa24aad08f214f"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"eedb1232026f22dee7fbbb6eed146f2b12c1b185","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e90498a0_d121d536","in_reply_to":"24fefb47_9b5229f8","updated":"2026-02-24 18:14:16.000000000","message":"I think we should keep v1 + v2 behaviour as it is, and fix it for v3 (+document this) - which is, from what I saw on the list, what we\u0027ll see \"soonish\" anyway for the no-password enhancement.","commit_id":"01025edc9b0875a8c4bfe7d1e2fa24aad08f214f"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"eedb1232026f22dee7fbbb6eed146f2b12c1b185","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"86c01769_fe99fdc4","updated":"2026-02-24 18:14:16.000000000","message":"meh, gerrit tricked me.  I answered on the \"to respond only if ... \u003e\u003d 3\" thought, but forgot to \"send it for real\".","commit_id":"5d33d0b32d2b068294e0b071c08895cb0d8a7069"},{"author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"change_message_id":"525371aed2b8b7d0e2d830b82a283bcc64a29cc6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"946f3772_434930c4","in_reply_to":"86c01769_fe99fdc4","updated":"2026-02-24 20:14:26.000000000","message":"I do that all the time -- the other day deleted a dozen old comments that never saw the light of day...\n\nAnyway, I found \"commit 8be444df8\" had upped the latest client version to 3, so enabling this for \u003e\u003d 4. We really need a way to document client versions -- right now one has to just know.\n\nWhat about something like a private enum in manage.c with {CLIENT_VERSION_BASE \u003d 1, CLIENT_VERSION_PKSIGN \u003d 2, ... } and then use those like \"if (client_version \u003e\u003d CLIENT_VERSION_PKSIGN)\" etc? As a separate patch of course. Or, is there a better way?","commit_id":"5d33d0b32d2b068294e0b071c08895cb0d8a7069"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"51edebada51c69b3074d5dfab5210b7df90b6d4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a6777a25_04aa73e6","in_reply_to":"946f3772_434930c4","updated":"2026-02-24 21:29:38.000000000","message":"yes, please :-) (documenting + enum)","commit_id":"5d33d0b32d2b068294e0b071c08895cb0d8a7069"}],"src/openvpn/manage.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"501fd97bfe3026d8eaec938de99ffddb267e3211","unresolved":true,"context_lines":[{"line_number":1333,"context_line":"    if (version)"},{"line_number":1334,"context_line":"    {"},{"line_number":1335,"context_line":"        man-\u003econnection.client_version \u003d atoi(version);"},{"line_number":1336,"context_line":"        msg(M_CLIENT, \"SUCCESS: Management client version set to %d\", atoi(version));"},{"line_number":1337,"context_line":"    }"},{"line_number":1338,"context_line":"    else"},{"line_number":1339,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"396de3ef_ba7ee49b","line":1336,"updated":"2026-02-16 12:52:44.000000000","message":"Really shouldn\u0027t call `atoi` twice but instead use the return value.","commit_id":"01025edc9b0875a8c4bfe7d1e2fa24aad08f214f"},{"author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"change_message_id":"9e6adbc610269eb7f5bff32e630c1069431c5c4b","unresolved":false,"context_lines":[{"line_number":1333,"context_line":"    if (version)"},{"line_number":1334,"context_line":"    {"},{"line_number":1335,"context_line":"        man-\u003econnection.client_version \u003d atoi(version);"},{"line_number":1336,"context_line":"        msg(M_CLIENT, \"SUCCESS: Management client version set to %d\", atoi(version));"},{"line_number":1337,"context_line":"    }"},{"line_number":1338,"context_line":"    else"},{"line_number":1339,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"c384acb2_fca0e0f6","line":1336,"in_reply_to":"396de3ef_ba7ee49b","updated":"2026-02-16 19:33:07.000000000","message":"Done","commit_id":"01025edc9b0875a8c4bfe7d1e2fa24aad08f214f"}]}