)]}'
{"id":"openvpn~1529","triplet_id":"openvpn~master~Idb1e96a4d0a618089db4290c5980d192985b5d29","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-02-16 14:34:29.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-02-16 14:34:29.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Idb1e96a4d0a618089db4290c5980d192985b5d29","subject":"clang-format: Add missing InsertBraces: true","status":"MERGED","created":"2026-02-16 12:24:45.000000000","updated":"2026-02-16 14:34:29.000000000","submitted":"2026-02-16 14:34:29.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1529","meta_rev_id":"d3976c8b1a41e7c8161044ef89b06ebf97839d5f","_number":1529,"virtual_id_number":1529,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-02-16 12:24:46.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-02-16 12:24:46.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-02-16 12:29:52.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"feaf289e97a7b50a213a173f33e2569e4b9098bf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-16 12:24:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"45b7e4336c7ce9ebc991d34aa1b0310d05d3985d","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-02-16 12:29:52.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"d3976c8b1a41e7c8161044ef89b06ebf97839d5f","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-02-16 14:34:29.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"344f13fcdfc159277e7ba7d28e23537d718e7cef","revisions":{"023fe770c2c18ab59d2f81e93badd37669fc92e1":{"kind":"REWORK","_number":1,"created":"2026-02-16 12:24:45.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/29/1529/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/29/1529/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1529/1 \u0026\u0026 git checkout -b change-1529 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1529/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1529/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1529/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/29/1529/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1529/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6f9ab9647cf0a3bc53e42e609437f892ce009e7a","subject":"port-share: log incoming connections at verb 3 only"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-16 12:21:57.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-16 12:24:00.000000000","tz":60},"subject":"clang-format: Add missing InsertBraces: true","message":"clang-format: Add missing InsertBraces: true\n\nThis takes care to add missing braces in\ncase of one-line if-statements or loops.\n\nApparently we never tested this specific error\nand we had no existing cases in the code when\nwe did the reformat. Noticed this during a code\nreview.\n\nChange-Id: Idb1e96a4d0a618089db4290c5980d192985b5d29\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"344f13fcdfc159277e7ba7d28e23537d718e7cef":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2026-02-16 14:34:29.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/29/1529/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/29/1529/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1529/2 \u0026\u0026 git checkout -b change-1529 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1529/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1529/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1529/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/29/1529/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/1529/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6f9ab9647cf0a3bc53e42e609437f892ce009e7a","subject":"port-share: log incoming connections at verb 3 only"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-16 12:30:20.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-02-16 14:29:54.000000000","tz":60},"subject":"clang-format: Add missing InsertBraces: true","message":"clang-format: Add missing InsertBraces: true\n\nThis takes care to add missing braces in\ncase of one-line if-statements or loops.\n\nApparently we never tested this specific error\nand we had no existing cases in the code when\nwe did the reformat. Noticed this during a code\nreview.\n\nChange-Id: Idb1e96a4d0a618089db4290c5980d192985b5d29\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1529\nMessage-Id: \u003c20260216123026.3310-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg35635.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
