)]}'
{"src/openvpn/manage.c":[{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"81db64c840e263f6e8ce43ac37f369a993f7c389","unresolved":true,"context_lines":[{"line_number":491,"context_line":"     * coarse timer wakeup. Reset the timer to ensure it fires at the correct,"},{"line_number":492,"context_line":"     * earlier time."},{"line_number":493,"context_line":"     */"},{"line_number":494,"context_line":"    if (man-\u003epersist.callback.arg)"},{"line_number":495,"context_line":"    {"},{"line_number":496,"context_line":"        struct context *c;"},{"line_number":497,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"89b44519_1aac559c","line":494,"updated":"2026-07-24 16:57:17.000000000","message":"All the other uses of man-\u003epersist.callback.arg seem to just use that without check. Any reason that we need to check it here?","commit_id":"1056b69289db0a8464ea8b7a14009cee1d01611d"},{"author":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"change_message_id":"530b9f5d7c8f7ac1007c586ab7f97c2b06f5a857","unresolved":true,"context_lines":[{"line_number":491,"context_line":"     * coarse timer wakeup. Reset the timer to ensure it fires at the correct,"},{"line_number":492,"context_line":"     * earlier time."},{"line_number":493,"context_line":"     */"},{"line_number":494,"context_line":"    if (man-\u003epersist.callback.arg)"},{"line_number":495,"context_line":"    {"},{"line_number":496,"context_line":"        struct context *c;"},{"line_number":497,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c5ca2000_1a51c973","line":494,"in_reply_to":"89b44519_1aac559c","updated":"2026-11-16 13:13:07.000000000","message":"Sorry, I completely missed this comment.\n\nThe check is necessary because this function can run before `init_management_callback_multi`/`init_management_callback_p2p` has populated the `persist.callback.arg` field, specifically when `--management-hold` is set. In that case, the management interface will still process commands while waiting for the release and removing the guard will lead to null deref.\n\nOther man functions do not need that protection because they check the callback presence itself (for example `man_status`), operate on management state (for example `hold` or `env-filter`) or have other invariants making the `arg` check unnecessary.","commit_id":"1056b69289db0a8464ea8b7a14009cee1d01611d"}]}
