)]}'
{"id":"openvpn~1532","triplet_id":"openvpn~release%2F2.6~I4e1e8a204d1371a314b01737aedaa3d68fe28531","project":"openvpn","branch":"release/2.6","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-02-16 13:54:43.000000000","reason":"Reviewer was added"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I4e1e8a204d1371a314b01737aedaa3d68fe28531","subject":"Refactor management bytecount tracking","status":"NEW","created":"2026-02-16 13:54:41.000000000","updated":"2026-02-16 13:54:43.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"bed9a6428d54b3824b2cf0cc36788735808df10b","_number":1532,"virtual_id_number":1532,"owner":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-02-16 13:54:43.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-02-16 13:54:43.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"faecea979d05b4e882bc1339cc0a127f0ff15021","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2026-02-16 13:54:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"b937899819052437403503a828fe4cf3151acd6d","revisions":{"b937899819052437403503a828fe4cf3151acd6d":{"kind":"REWORK","_number":1,"created":"2026-02-16 13:54:41.000000000","uploader":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"ref":"refs/changes/32/1532/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/32/1532/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1532/1 \u0026\u0026 git checkout -b change-1532 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1532/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1532/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1532/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/32/1532/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1532/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1056b69289db0a8464ea8b7a14009cee1d01611d","subject":"management: resync timer on bytecount interval change"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-08-27 11:15:07.000000000","tz":180},"committer":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2026-02-16 13:32:42.000000000","tz":60},"subject":"Refactor management bytecount tracking","message":"Refactor management bytecount tracking\n\nThere are few issues with it:\n\n - when using DCO, the server part doesn\u0027t output BYTECOUNT_CLI\n since process_incoming_link_part1/process_outgoing_link are not called\n\n - when using DCO, the server part applies bytecount timer to the each\n connection, unneccessary making too many calls to the kernel and also\n uses incorect BYTECOUNT output.\n\n - client part outputs counters using timer, server part utilizes\n traffic activity -\u003e inconsistency\n\nFollowing changes have been made:\n\n - Use timer to output counters in client and server mode. Code which\n deals with bytecount on traffic activity has been removed. This unifies\n DCO and non-DCO, as well as client and server mode\n\n - In server mode, peers stats are fetched with the single ioctl call\n\n - Per-packet stats are not persisted anymore in the client mode during\n   traffic activity. Instead cumulative stats (including DCO stats) are\n   persisted when the session closes.\n\nGitHub: https://github.com/OpenVPN/openvpn/issues/820\n\nChange-Id: I4e1e8a204d1371a314b01737aedaa3d68fe28531\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/release/2.6"}},"requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"}]},{"rule_name":"checks~ChecksSubmitRule","status":"NOT_READY","requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}]}],"submit_requirements":[{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}},{"name":"checks~ChecksSubmitRule","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:checks~ChecksSubmitRule","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["checks~ChecksSubmitRule"]}}]}