)]}'
{"id":"openvpn~1534","triplet_id":"openvpn~release%2F2.6~I65c7225fe48c24a4734fc1b9df64b9580f6f6e5f","project":"openvpn","branch":"release/2.6","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-02-16 13:54:44.000000000","reason":"Reviewer was added"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I65c7225fe48c24a4734fc1b9df64b9580f6f6e5f","subject":"management: ensure consistent BYTECOUNT timing on server","status":"NEW","created":"2026-02-16 13:54:41.000000000","updated":"2026-02-16 13:54:44.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"89d1b4d6d5f0fe02b88ef3a580ea5da80466324e","_number":1534,"virtual_id_number":1534,"owner":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-02-16 13:54:44.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-02-16 13:54:44.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"af6dd7be28758f28190c35d8b348ccd452180e46","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2026-02-16 13:54:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f72220b9a963f125757ffb742df0bf664532ab0e","revisions":{"f72220b9a963f125757ffb742df0bf664532ab0e":{"kind":"REWORK","_number":1,"created":"2026-02-16 13:54:41.000000000","uploader":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"ref":"refs/changes/34/1534/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/34/1534/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/34/1534/1 \u0026\u0026 git checkout -b change-1534 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/34/1534/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/34/1534/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/34/1534/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/34/1534/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/34/1534/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f4198874f48e0358844fa731d17c7bfa4664d239","subject":"management: stop bytecount on client disconnection"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-10-19 21:33:16.000000000","tz":120},"committer":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2026-02-16 13:38:02.000000000","tz":60},"subject":"management: ensure consistent BYTECOUNT timing on server","message":"management: ensure consistent BYTECOUNT timing on server\n\nThe BYTECOUNT notification is expected to be emitted every N seconds\nwhen a management client issues the \u0027bytecount N\u0027 command. However, the\nserver currently relies on timeouts from unrelated periodic operations,\nresulting in irregular notification timing.\n\nThis issue is especially noticeable with low bytecount intervals and DCO\nenabled, as openvpn handles less traffic in userspace, causing the main\nloop to run less frequently.\n\nTo address this, refactor the timeout logic and pass the timeval\nreference to management_check_bytecount_server so that the timeout is\ncorrectly set and notifications adhere to the specified interval.\n\nChange-Id: I65c7225fe48c24a4734fc1b9df64b9580f6f6e5f\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\n"},"branch":"refs/heads/release/2.6"}},"requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"}]},{"rule_name":"checks~ChecksSubmitRule","status":"NOT_READY","requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}]}],"submit_requirements":[{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}},{"name":"checks~ChecksSubmitRule","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:checks~ChecksSubmitRule","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["checks~ChecksSubmitRule"]}}]}