)]}'
{"doc/man-sections/windows-options.rst":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"1c9500b48b46651905dbe341e9f335bc1835b0b3","unresolved":true,"context_lines":[{"line_number":20,"context_line":"  This option is considered unknown on non-Windows platforms and"},{"line_number":21,"context_line":"  unsupported on Windows XP, resulting in fatal error. You may want to use"},{"line_number":22,"context_line":"  ``--setenv opt`` or ``--ignore-unknown-option`` (not suitable for"},{"line_number":23,"context_line":"  Windows XP) to ignore said error. Note that pushing unknown options from"},{"line_number":24,"context_line":"  server does not trigger fatal errors."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"--cryptoapicert select-string"}],"source_content_type":"text/x-rst","patch_set":1,"id":"d5bb05f2_99eae1b5","line":23,"updated":"2026-03-04 11:40:35.000000000","message":"Can we maybe remove this Windows XP mention as a drive-by fix?","commit_id":"636a94b308edc3ef6a58d26eaeac1addc57f371e"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"ca4ccd3dd8d48a157edd49f942f4d907f30c471f","unresolved":true,"context_lines":[{"line_number":20,"context_line":"  This option is considered unknown on non-Windows platforms and"},{"line_number":21,"context_line":"  unsupported on Windows XP, resulting in fatal error. You may want to use"},{"line_number":22,"context_line":"  ``--setenv opt`` or ``--ignore-unknown-option`` (not suitable for"},{"line_number":23,"context_line":"  Windows XP) to ignore said error. Note that pushing unknown options from"},{"line_number":24,"context_line":"  server does not trigger fatal errors."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"--cryptoapicert select-string"}],"source_content_type":"text/x-rst","patch_set":1,"id":"cdd6f755_709f8251","line":23,"in_reply_to":"02f29f5c_ebfbd6bf","updated":"2026-03-05 11:08:16.000000000","message":"Feel free to put it in a separate patch *nudge*, *nudge*, *wink*, *wink* ;)\n\nEither way, it is just a suggestion, it doesn\u0027t influence the merge of this patch.","commit_id":"636a94b308edc3ef6a58d26eaeac1addc57f371e"},{"author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"change_message_id":"8dd62a160d2fd5bcda79ebefed0d01a8d202b463","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  This option is considered unknown on non-Windows platforms and"},{"line_number":21,"context_line":"  unsupported on Windows XP, resulting in fatal error. You may want to use"},{"line_number":22,"context_line":"  ``--setenv opt`` or ``--ignore-unknown-option`` (not suitable for"},{"line_number":23,"context_line":"  Windows XP) to ignore said error. Note that pushing unknown options from"},{"line_number":24,"context_line":"  server does not trigger fatal errors."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"--cryptoapicert select-string"}],"source_content_type":"text/x-rst","patch_set":1,"id":"175adec9_5d09e09d","line":23,"in_reply_to":"cdd6f755_709f8251","updated":"2026-03-05 20:09:16.000000000","message":"Yeah, I think it\u0027s worth a dedicated patch. Will do.","commit_id":"636a94b308edc3ef6a58d26eaeac1addc57f371e"},{"author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"change_message_id":"d5c93184c2e69bc30b64c282391dc770e04f3164","unresolved":true,"context_lines":[{"line_number":20,"context_line":"  This option is considered unknown on non-Windows platforms and"},{"line_number":21,"context_line":"  unsupported on Windows XP, resulting in fatal error. You may want to use"},{"line_number":22,"context_line":"  ``--setenv opt`` or ``--ignore-unknown-option`` (not suitable for"},{"line_number":23,"context_line":"  Windows XP) to ignore said error. Note that pushing unknown options from"},{"line_number":24,"context_line":"  server does not trigger fatal errors."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"--cryptoapicert select-string"}],"source_content_type":"text/x-rst","patch_set":1,"id":"02f29f5c_ebfbd6bf","line":23,"in_reply_to":"d5bb05f2_99eae1b5","updated":"2026-03-05 01:42:36.000000000","message":"Hm, I find the whole paragraph of limited use and would remove it rather completely. On the other hand it\u0027s not directly related to the change here.","commit_id":"636a94b308edc3ef6a58d26eaeac1addc57f371e"}],"src/openvpn/wfp_block.h":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"ca4ccd3dd8d48a157edd49f942f4d907f30c471f","unresolved":true,"context_lines":[{"line_number":45,"context_line":" * The firewall filters added here are automatically removed when the process exits or"},{"line_number":46,"context_line":" * on calling \\ref delete_wfp_block_filters()."},{"line_number":47,"context_line":" *"},{"line_number":48,"context_line":" * @param engine_handle On successful return contains the handle for a newly opened fwp"},{"line_number":49,"context_line":" *                      session in which the filters are added. May be closed by passing"},{"line_number":50,"context_line":" *                      to \\ref delete_wfp_block_filters() to remove the filters."},{"line_number":51,"context_line":" * @param index         The index of adapter for which traffic is permitted."}],"source_content_type":"text/x-csrc","patch_set":4,"id":"2a9315b1_d4e0a1d9","line":48,"updated":"2026-03-05 11:08:16.000000000","message":"Parameter names are wrong\n\n```\nwfp_block.h:48: warning: argument \u0027engine_handle\u0027 of command @param is not found in the argument list of add_wfp_block_filters(HANDLE *engine, int iface_index, const WCHAR *exe_path, wfp_block_msg_handler_t msg_handler_callback, const wfp_block_t block_type)\nwfp_block.h:48: warning: argument \u0027index\u0027 of command @param is not found in the argument list of add_wfp_block_filters(HANDLE *engine, int iface_index, const WCHAR *exe_path, wfp_block_msg_handler_t msg_handler_callback, const wfp_block_t block_type)\nwfp_block.h:48: warning: argument \u0027msg_handler\u0027 of command @param is not found in the argument list of add_wfp_block_filters(HANDLE *engine, int iface_index, const WCHAR *exe_path, wfp_block_msg_handler_t msg_handler_callback, const wfp_block_t block_type)\nwfp_block.h:48: warning: The following parameters of add_wfp_block_filters(HANDLE *engine, int iface_index, const WCHAR *exe_path, wfp_block_msg_handler_t msg_handler_callback, const wfp_block_t block_type) are not documented:\n  parameter \u0027engine\u0027\n  parameter \u0027iface_index\u0027\n  parameter \u0027msg_handler_callback\u0027\n```","commit_id":"7b53fdbb82077f640aaeda45e1baaa6e4ccccfc6"},{"author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"change_message_id":"8dd62a160d2fd5bcda79ebefed0d01a8d202b463","unresolved":false,"context_lines":[{"line_number":45,"context_line":" * The firewall filters added here are automatically removed when the process exits or"},{"line_number":46,"context_line":" * on calling \\ref delete_wfp_block_filters()."},{"line_number":47,"context_line":" *"},{"line_number":48,"context_line":" * @param engine_handle On successful return contains the handle for a newly opened fwp"},{"line_number":49,"context_line":" *                      session in which the filters are added. May be closed by passing"},{"line_number":50,"context_line":" *                      to \\ref delete_wfp_block_filters() to remove the filters."},{"line_number":51,"context_line":" * @param index         The index of adapter for which traffic is permitted."}],"source_content_type":"text/x-csrc","patch_set":4,"id":"113b6688_251db25a","line":48,"in_reply_to":"2a9315b1_d4e0a1d9","updated":"2026-03-05 20:09:16.000000000","message":"Done","commit_id":"7b53fdbb82077f640aaeda45e1baaa6e4ccccfc6"}],"src/openvpnserv/interactive.c":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"1c9500b48b46651905dbe341e9f335bc1835b0b3","unresolved":true,"context_lines":[{"line_number":852,"context_line":"static DWORD"},{"line_number":853,"context_line":"HandleWfpBlockMessage(const wfp_block_message_t *msg, undo_lists_t *lists)"},{"line_number":854,"context_line":"{"},{"line_number":855,"context_line":"    if (msg-\u003eblock_type \u003e\u003d 0 \u0026\u0026 msg-\u003eblock_type \u003c wfp_block_type_count)"},{"line_number":856,"context_line":"    {"},{"line_number":857,"context_line":"        return ERROR_MESSAGE_DATA;"},{"line_number":858,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c9ad5c85_76b9cf5a","line":855,"updated":"2026-03-04 11:40:35.000000000","message":"I don\u0027t understand this conditional. So if block_type is between 0 and wfp_block_type_count, that is an error? Why?","commit_id":"636a94b308edc3ef6a58d26eaeac1addc57f371e"},{"author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"change_message_id":"d5c93184c2e69bc30b64c282391dc770e04f3164","unresolved":false,"context_lines":[{"line_number":852,"context_line":"static DWORD"},{"line_number":853,"context_line":"HandleWfpBlockMessage(const wfp_block_message_t *msg, undo_lists_t *lists)"},{"line_number":854,"context_line":"{"},{"line_number":855,"context_line":"    if (msg-\u003eblock_type \u003e\u003d 0 \u0026\u0026 msg-\u003eblock_type \u003c wfp_block_type_count)"},{"line_number":856,"context_line":"    {"},{"line_number":857,"context_line":"        return ERROR_MESSAGE_DATA;"},{"line_number":858,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"b298a86e_de1d4f16","line":855,"in_reply_to":"c9ad5c85_76b9cf5a","updated":"2026-03-05 01:42:36.000000000","message":"It\u0027s exactly the wrong way around. Good catch.","commit_id":"636a94b308edc3ef6a58d26eaeac1addc57f371e"}]}