)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"change_message_id":"2244ae5281693e954f90ee4a06c74fd2cd9d9ce2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1b32e33b_6ac332ef","updated":"2026-02-19 07:47:11.000000000","message":"The patch looks good to me and it fixes the issue. However, I wonder if there is a more systematic way to prevent this class of bugs in the future, possibly in SITNL_ADDATTR.\n\nnit: \"architcutre\" typ0 in the commit body","commit_id":"30e6ea8d132450e7ef5b86bec75247eb19195634"},{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"010eab95fb447c676c0937517ffda13213f12d54","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1d172748_28319a5b","updated":"2026-02-18 19:42:21.000000000","message":"missing Signed-off-by line.\nAlso, please add the dco_linux.c prefix in the commit title as this is something very specific to it.\n\nAs for the first sentence I am not sure it\u0027s the right wording, but I don\u0027t have a strong opinion.","commit_id":"30e6ea8d132450e7ef5b86bec75247eb19195634"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"45a88e6de7f3c59f5ffa591cf7e501566d4f5c41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"16b61e2f_7aacb5e9","in_reply_to":"1d172748_28319a5b","updated":"2026-02-19 10:22:12.000000000","message":"Done","commit_id":"30e6ea8d132450e7ef5b86bec75247eb19195634"},{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"9638279ba5649c0b3e19e462229b857cb9cf5099","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4b071859_7b94cf9b","updated":"2026-02-19 11:06:36.000000000","message":"Lgtm","commit_id":"3d3072d67fc13e349cbca1a7d54c60ee0c0517e3"}],"src/openvpn/networking_sitnl.c":[{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"624621b386c643be64182151f5eb43eba16e467b","unresolved":true,"context_lines":[{"line_number":1339,"context_line":"        struct rtattr *data \u003d SITNL_NEST(\u0026req.n, sizeof(req), IFLA_INFO_DATA);"},{"line_number":1340,"context_line":""},{"line_number":1341,"context_line":"        /* the netlink format is uint8_t for this and using something"},{"line_number":1342,"context_line":"         * other than uint8_t here causes the values to be 0 when passed"},{"line_number":1343,"context_line":"         * on big endian arch as we only take the byte directly at the address"},{"line_number":1344,"context_line":"         */"},{"line_number":1345,"context_line":"        uint8_t ifmode \u003d (uint8_t)dco-\u003eifmode;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"aafb395a_49dc4aa8","line":1342,"updated":"2026-02-18 19:44:45.000000000","message":"maybe you can mention that the enum is probably wending up being a uint16 or uint32? Because you are implying that, but this detail is actually the crux of the issue. In a few months from now we may not remember anymore.\n\nWhat you are mentioning in this comment is just how endianess works (it can stay if you like it)","commit_id":"30e6ea8d132450e7ef5b86bec75247eb19195634"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"45a88e6de7f3c59f5ffa591cf7e501566d4f5c41","unresolved":false,"context_lines":[{"line_number":1339,"context_line":"        struct rtattr *data \u003d SITNL_NEST(\u0026req.n, sizeof(req), IFLA_INFO_DATA);"},{"line_number":1340,"context_line":""},{"line_number":1341,"context_line":"        /* the netlink format is uint8_t for this and using something"},{"line_number":1342,"context_line":"         * other than uint8_t here causes the values to be 0 when passed"},{"line_number":1343,"context_line":"         * on big endian arch as we only take the byte directly at the address"},{"line_number":1344,"context_line":"         */"},{"line_number":1345,"context_line":"        uint8_t ifmode \u003d (uint8_t)dco-\u003eifmode;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9d502085_4e9be80e","line":1342,"in_reply_to":"aafb395a_49dc4aa8","updated":"2026-02-19 10:22:12.000000000","message":"Done","commit_id":"30e6ea8d132450e7ef5b86bec75247eb19195634"}]}