)]}'
{"id":"openvpn~1547","triplet_id":"openvpn~master~I560f45fb0011180be8ca2b0e7fbc63030fa10f35","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-02-19 15:52:00.000000000","reason":"Change was submitted"},"1000007":{"account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2026-02-19 11:06:36.000000000","reason":"\u003cGERRIT_ACCOUNT_1000007\u003e replied on the change","reason_account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}},"1000041":{"account":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"last_update":"2026-02-19 15:52:00.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I560f45fb0011180be8ca2b0e7fbc63030fa10f35","subject":"DCO Linux: Fix setting DCO ifmode failing on big endian archs","status":"MERGED","created":"2026-02-18 18:02:52.000000000","updated":"2026-02-19 15:52:00.000000000","submitted":"2026-02-19 15:52:00.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1547","meta_rev_id":"d84c5438569466be84e072edf56715f3f3cda223","_number":1547,"virtual_id_number":1547,"owner":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},{"value":0,"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-02-18 18:02:53.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-02-18 19:42:21.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"REVIEWER"},{"updated":"2026-02-19 07:47:11.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"state":"REVIEWER"}],"messages":[{"id":"8951e678911a1e31d702884f3ebf96cf8f745100","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-02-18 18:02:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"010eab95fb447c676c0937517ffda13213f12d54","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-02-18 19:42:21.000000000","message":"Patch Set 1: Code-Review-2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"624621b386c643be64182151f5eb43eba16e467b","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-02-18 19:44:45.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2244ae5281693e954f90ee4a06c74fd2cd9d9ce2","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2026-02-19 07:47:11.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c3d404bc5a0d75e03c42138a99ab47cc1db673d2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-02-19 10:14:44.000000000","message":"Uploaded patch set 2.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR **is:MIN**\")\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"dafe558fbb1c20e81a0345632d4f47f98588ff7f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-02-19 10:20:36.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased. Commit message was updated.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR **is:MIN**\")\n","accounts_in_message":[],"_revision_number":3},{"id":"45a88e6de7f3c59f5ffa591cf7e501566d4f5c41","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-02-19 10:22:12.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"9638279ba5649c0b3e19e462229b857cb9cf5099","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-02-19 11:06:36.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"d84c5438569466be84e072edf56715f3f3cda223","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-02-19 15:52:00.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"b3e0e8696b162794beefc22aad7406b328471cf6","revisions":{"30e6ea8d132450e7ef5b86bec75247eb19195634":{"kind":"REWORK","_number":1,"created":"2026-02-18 18:02:52.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/47/1547/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/47/1547/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1547/1 \u0026\u0026 git checkout -b change-1547 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1547/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1547/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1547/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/47/1547/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1547/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cb7446c23927c1d61c2694152b3e01e81d517e37","subject":"Unbreak Mbed TLS 4 build"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-02-18 17:59:35.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-02-18 18:02:26.000000000","tz":60},"subject":"Fix setting DCO ifmode failing on big endian archs","message":"Fix setting DCO ifmode failing on big endian archs\n\nThe problem is basically that SITNL_ADDATTR is not type safe and on\nbig endian architcutre passing a smaller size than the underlying\ninteger type of data causes only the more significant byte(s) to be passed\ninstead.\n\nChange-Id: I560f45fb0011180be8ca2b0e7fbc63030fa10f35\n"},"branch":"refs/heads/master"},"8a94958ed883f4f56032301884a6770e9537c481":{"kind":"REWORK","_number":2,"created":"2026-02-19 10:14:44.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/47/1547/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/47/1547/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1547/2 \u0026\u0026 git checkout -b change-1547 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1547/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1547/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1547/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/47/1547/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1547/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cb7446c23927c1d61c2694152b3e01e81d517e37","subject":"Unbreak Mbed TLS 4 build"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-02-18 17:59:35.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-02-19 10:14:29.000000000","tz":60},"subject":"DCO Linux: Fix setting DCO ifmode failing on big endian archs","message":"DCO Linux: Fix setting DCO ifmode failing on big endian archs\n\nThe problem is that SITNL_ADDATTR is not forcing type safety and on\nbig endian architcutre passing a smaller size than the underlying\ninteger type of data causes only the more significant byte(s) to be passed\ninstead.\n\nA proper fix would be to add specific methods for common integer types like\nSITNL_ADDATTR_u8, SITNL_ADDATTR_u16, SITNL_ADDATTR_u32 like netlink library\ndoes with NLA_PUT_U32, NLA_PUT_U16, NLA_PUT_U8.\n\nChange-Id: I560f45fb0011180be8ca2b0e7fbc63030fa10f35\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"3d3072d67fc13e349cbca1a7d54c60ee0c0517e3":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2026-02-19 10:20:36.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/47/1547/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/47/1547/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1547/3 \u0026\u0026 git checkout -b change-1547 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1547/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1547/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1547/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/47/1547/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1547/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"eeaedd13628e27225c8893c2d8bdf5381fc33ba9","subject":"auth-pam: fix discards \u0027const\u0027 qualifier from pointer target type"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-02-18 17:59:35.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-02-19 10:20:05.000000000","tz":60},"subject":"DCO Linux: Fix setting DCO ifmode failing on big endian archs","message":"DCO Linux: Fix setting DCO ifmode failing on big endian archs\n\nThe problem is that SITNL_ADDATTR is not forcing type safety and on\nbig endian architcutre passing a smaller size than the underlying\ninteger type of data causes only the more significant byte(s) to be passed\ninstead.\n\nA proper fix would be to add specific methods for common integer types like\nSITNL_ADDATTR_u8, SITNL_ADDATTR_u16, SITNL_ADDATTR_u32 like netlink library\ndoes with NLA_PUT_U32, NLA_PUT_U16, NLA_PUT_U8.\n\nChange-Id: I560f45fb0011180be8ca2b0e7fbc63030fa10f35\nGithub: closes OpenVPN/ovpn-dco#96\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"b3e0e8696b162794beefc22aad7406b328471cf6":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2026-02-19 15:52:00.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/47/1547/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/47/1547/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1547/4 \u0026\u0026 git checkout -b change-1547 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1547/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1547/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1547/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/47/1547/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/1547/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"eeaedd13628e27225c8893c2d8bdf5381fc33ba9","subject":"auth-pam: fix discards \u0027const\u0027 qualifier from pointer target type"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-02-19 11:09:48.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-02-19 15:46:39.000000000","tz":60},"subject":"DCO Linux: Fix setting DCO ifmode failing on big endian archs","message":"DCO Linux: Fix setting DCO ifmode failing on big endian archs\n\nThe problem is that SITNL_ADDATTR is not forcing type safety and on\nbig endian architcutre passing a smaller size than the underlying\ninteger type of data causes only the more significant byte(s) to be passed\ninstead.\n\nA proper fix would be to add specific methods for common integer types like\nSITNL_ADDATTR_u8, SITNL_ADDATTR_u16, SITNL_ADDATTR_u32 like netlink library\ndoes with NLA_PUT_U32, NLA_PUT_U16, NLA_PUT_U8.\n\nChange-Id: I560f45fb0011180be8ca2b0e7fbc63030fa10f35\nGithub: closes OpenVPN/ovpn-dco#96\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nAcked-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1547\nMessage-Id: \u003c20260219110954.21471-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg35752.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}