)]}'
{"id":"openvpn~1551","triplet_id":"openvpn~master~I84fe7a11391eafde3660d25a3c99094a0c525f3d","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-02-28 09:38:41.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2026-02-28 09:38:41.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I84fe7a11391eafde3660d25a3c99094a0c525f3d","subject":"dco_freebsd: use AF_LOCAL sockets for ioctl() communication with DCO driver","status":"MERGED","created":"2026-02-21 14:46:00.000000000","updated":"2026-02-28 09:38:41.000000000","submitted":"2026-02-28 09:38:41.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1551","meta_rev_id":"3f9d7aa9998dad965c1c2d28e4a1851335fc8365","_number":1551,"virtual_id_number":1551,"owner":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-02-21 14:46:00.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-02-21 14:46:00.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-02-27 22:40:27.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"REVIEWER"}],"messages":[{"id":"f2e026d03e93138c54f42c26d98c5e6d17cff6f0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-02-21 14:46:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"27cd1639debc2eea41134834dc302eb065268cde","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-02-27 22:40:27.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"3f9d7aa9998dad965c1c2d28e4a1851335fc8365","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-02-28 09:38:41.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"5f19355d15da17cbc70624f833171f162adc4ea4","revisions":{"7c87837fd64bc286338ddeb7f30ddd0b64a1c926":{"kind":"REWORK","_number":1,"created":"2026-02-21 14:46:00.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/51/1551/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/51/1551/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1551/1 \u0026\u0026 git checkout -b change-1551 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1551/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1551/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1551/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/51/1551/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1551/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"38243844f225517fa1d288517db9a34a33c5ad13","subject":"configure.ac: adjust to native inotify support for FreeBSD 15+"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-02-21 14:37:11.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-02-21 14:41:58.000000000","tz":60},"subject":"dco_freebsd: use AF_LOCAL sockets for ioctl() communication with DCO driver","message":"dco_freebsd: use AF_LOCAL sockets for ioctl() communication with DCO driver\n\nDCO FreeBSD uses ioctl() calls for userland -\u003e driver communication, on\na socket() file descriptor.  The original code uses AF_INET sockets,\nwhich fails if using a kernel compiled without IPv4 support.\n\nThe kernel side ioctl() handling does not differentiate between AF_INET,\nAF_INET6 and AF_LOCAL sockets, and only the latter are guaranteed to be\npresent.\n\nWhile add it, add a clear message if the socket() call in dco_available()\nfails (it will lead to disabling of DCO).\n\nFreeBSD PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id\u003d286263\nReported-by: Marek Zarychta \u003czarychtam@plan-b.pwste.edu.pl\u003e\n\nChange-Id: I84fe7a11391eafde3660d25a3c99094a0c525f3d\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"5f19355d15da17cbc70624f833171f162adc4ea4":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2026-02-28 09:38:41.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/51/1551/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/51/1551/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1551/2 \u0026\u0026 git checkout -b change-1551 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1551/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1551/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1551/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/51/1551/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1551/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"adc0febaeac0d83246dbd2cc77b2a5d80e41741e","subject":"Fixup version command on management interface"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-02-27 22:47:39.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-02-28 09:23:46.000000000","tz":60},"subject":"dco_freebsd: use AF_LOCAL sockets for ioctl() communication with DCO driver","message":"dco_freebsd: use AF_LOCAL sockets for ioctl() communication with DCO driver\n\nDCO FreeBSD uses ioctl() calls for userland -\u003e driver communication, on\na socket() file descriptor.  The original code uses AF_INET sockets,\nwhich fails if using a kernel compiled without IPv4 support.\n\nThe kernel side ioctl() handling does not differentiate between AF_INET,\nAF_INET6 and AF_LOCAL sockets, and only the latter are guaranteed to be\npresent.\n\nWhile add it, add a clear message if the socket() call in dco_available()\nfails (it will lead to disabling of DCO).\n\nFreeBSD PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id\u003d286263\nReported-by: Marek Zarychta \u003czarychtam@plan-b.pwste.edu.pl\u003e\n\nChange-Id: I84fe7a11391eafde3660d25a3c99094a0c525f3d\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nAcked-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1551\nMessage-Id: \u003c20260227224745.3175-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg35795.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}