)]}'
{"id":"openvpn~1554","triplet_id":"openvpn~master~Iabe1992b2608661b862a81363574e957d18395f0","project":"openvpn","branch":"master","topic":"wconversion","attention_set":{"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-06-23 09:17:12.000000000","reason":"Someone else replied on the change"}},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-06-23 09:17:12.000000000","reason":"removed on reply"}},"hashtags":["mailsubmitted"],"change_id":"Iabe1992b2608661b862a81363574e957d18395f0","subject":"socket: Never use negative buf-\u003elen in link_socket_read*","status":"NEW","created":"2026-03-03 16:09:30.000000000","updated":"2026-07-08 15:29:01.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0a808c7e8c3b53cbc0ce3d2f23ee6e94818e7e55","_number":1554,"virtual_id_number":1554,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"all":[{"value":2,"date":"2026-06-23 09:17:12.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-03-03 16:09:33.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-03-03 16:09:33.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"b3589479d1766d576fd3808c9b8ef2f0cee213e1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-03 16:09:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6a890d6e41ffa2d64299dfc4cf4d99b3abd4909a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-03 16:41:54.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"356ea19e342fbd121365c12f8ea706f22098d925","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-04 13:20:38.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"0a0918ce9b72adef18e199474e90ffd680429f82","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-06-12 10:25:28.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"4c865048340f0d82f81cf86a16330a688eb88203","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-06-23 09:17:12.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"0a808c7e8c3b53cbc0ce3d2f23ee6e94818e7e55","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-07-08 15:29:01.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"3353dd9c5cc152588111892a1b878e96b5d51fca","revisions":{"46d09e40d0b2173ab37dec7f9e8fad0dd5c7d155":{"kind":"REWORK","_number":1,"created":"2026-03-03 16:09:30.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/54/1554/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/54/1554/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1554/1 \u0026\u0026 git checkout -b change-1554 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1554/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1554/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1554/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/54/1554/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1554/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d5814ecd2323ec7c2e6dad2cbf3884c031d9a5a3","subject":"Document management client versions"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-03 15:58:25.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-03 15:58:25.000000000","tz":60},"subject":"socket: Never use negative buf-\u003elen in link_socket_read*","message":"socket: Never use negative buf-\u003elen in link_socket_read*\n\nWe really don\u0027t want to use negative buf lengths in\nour code. So remove some places where we did so before.\n\nChange-Id: Iabe1992b2608661b862a81363574e957d18395f0\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"e008bc72147e655b65a966900afbca69cd335dae":{"kind":"REWORK","_number":2,"created":"2026-03-03 16:41:54.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/54/1554/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/54/1554/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1554/2 \u0026\u0026 git checkout -b change-1554 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1554/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1554/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1554/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/54/1554/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1554/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d5814ecd2323ec7c2e6dad2cbf3884c031d9a5a3","subject":"Document management client versions"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-03 15:58:25.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-03 16:41:25.000000000","tz":60},"subject":"socket: Never use negative buf-\u003elen in link_socket_read*","message":"socket: Never use negative buf-\u003elen in link_socket_read*\n\nWe really don\u0027t want to use negative buf lengths in\nour code. So remove some places where we did so before.\n\nChange-Id: Iabe1992b2608661b862a81363574e957d18395f0\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"8c67b51a3cba6dba50c5fc5be99eb7c7ce66c7d3":{"kind":"REWORK","_number":3,"created":"2026-03-04 13:20:38.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/54/1554/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/54/1554/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1554/3 \u0026\u0026 git checkout -b change-1554 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1554/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1554/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1554/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/54/1554/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1554/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"28941473f32153a762db25a0ebe54aae321a8155","subject":"buffer: Add BLENZ macro that returns size_t and use it where required"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-03 15:58:25.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-04 13:20:24.000000000","tz":60},"subject":"socket: Never use negative buf-\u003elen in link_socket_read*","message":"socket: Never use negative buf-\u003elen in link_socket_read*\n\nWe really don\u0027t want to use negative buf lengths in\nour code. So remove some places where we did so before.\n\nChange-Id: Iabe1992b2608661b862a81363574e957d18395f0\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"3353dd9c5cc152588111892a1b878e96b5d51fca":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2026-06-12 10:25:28.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/54/1554/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/54/1554/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1554/4 \u0026\u0026 git checkout -b change-1554 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1554/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1554/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1554/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/54/1554/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1554/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fe72bbec92decbf15984163bc7852f8e6dab7de7","subject":"AWS-LC: Add casts and openssl_opt_t typdef to allow AWS-LC with -Werror"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-03 15:58:25.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-06-12 10:25:18.000000000","tz":120},"subject":"socket: Never use negative buf-\u003elen in link_socket_read*","message":"socket: Never use negative buf-\u003elen in link_socket_read*\n\nWe really don\u0027t want to use negative buf lengths in\nour code. So remove some places where we did so before.\n\nChange-Id: Iabe1992b2608661b862a81363574e957d18395f0\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}}]},{"rule_name":"checks~ChecksSubmitRule","status":"NOT_READY","requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}]}],"submit_requirements":[{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}},{"name":"checks~ChecksSubmitRule","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:checks~ChecksSubmitRule","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["checks~ChecksSubmitRule"]}}]}