)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"94e3937d7bcf0f4837c287feeb162db675fda4f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9d514b20_5f3b3671","updated":"2026-03-16 13:46:30.000000000","message":"Maybe Gert can fix the comment by moving the ending \"*/\" on a new line.\nThe rest looks good to me!","commit_id":"a245f92a379b99d30d45d98ee0fb23c9e0a4a7b1"}],"src/openvpn/socket.c":[{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"a374671c02f9c94ba70afc6665b9bc25dfea33c8","unresolved":true,"context_lines":[{"line_number":1347,"context_line":"    ASSERT(sock);"},{"line_number":1348,"context_line":""},{"line_number":1349,"context_line":"    const char *host \u003d o-\u003ece.local_list-\u003earray[sock_index]-\u003elocal;"},{"line_number":1350,"context_line":"    const char *port \u003d (o-\u003emode \u003d\u003d MODE_POINT_TO_POINT \u0026\u0026 o-\u003ece.local_port_defined)"},{"line_number":1351,"context_line":"                           ? o-\u003ece.local_port"},{"line_number":1352,"context_line":"                           : o-\u003ece.local_list-\u003earray[sock_index]-\u003eport;"},{"line_number":1353,"context_line":"    int proto \u003d o-\u003ece.local_list-\u003earray[sock_index]-\u003eproto;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"29141286_321bf2c0","line":1350,"updated":"2026-03-10 13:42:28.000000000","message":"similarly to what we do with o-\u003ece.proto, can we have an if just below the variables declaration, rather than having this longer/complex expression in here?\n\nwe could just have:\n\nif (o-\u003emode \u003d\u003d MODE_POINT_TO_POINT \u0026\u0026 o-\u003ece.local_port_defined)\n{\n    port \u003d o-\u003ece.local_port\n}\n\nand keep the variable declaration/initialization as it was before.\nMaybe also add a comment of top of that if saying something like \"if --lport is specified in a client connection block we give it higher priority\"","commit_id":"2d65cc89000c6f75d8a06356c767f6091a098a67"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"a6cb74cb84f173caeb6eb89643cf52679de15d9c","unresolved":false,"context_lines":[{"line_number":1347,"context_line":"    ASSERT(sock);"},{"line_number":1348,"context_line":""},{"line_number":1349,"context_line":"    const char *host \u003d o-\u003ece.local_list-\u003earray[sock_index]-\u003elocal;"},{"line_number":1350,"context_line":"    const char *port \u003d (o-\u003emode \u003d\u003d MODE_POINT_TO_POINT \u0026\u0026 o-\u003ece.local_port_defined)"},{"line_number":1351,"context_line":"                           ? o-\u003ece.local_port"},{"line_number":1352,"context_line":"                           : o-\u003ece.local_list-\u003earray[sock_index]-\u003eport;"},{"line_number":1353,"context_line":"    int proto \u003d o-\u003ece.local_list-\u003earray[sock_index]-\u003eproto;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"21d779a6_4ec1a1d6","line":1350,"in_reply_to":"29141286_321bf2c0","updated":"2026-03-10 16:20:11.000000000","message":"Done","commit_id":"2d65cc89000c6f75d8a06356c767f6091a098a67"}]}
