)]}'
{"id":"openvpn~1555","triplet_id":"openvpn~master~I7cf5d5ef7e2531f397ad97baf4663e3763072f6b","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-03-30 11:28:19.000000000","reason":"Change was submitted"},"1000034":{"account":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"last_update":"2026-03-30 11:28:19.000000000","reason":"Change was submitted"},"1000007":{"account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2026-03-16 13:46:30.000000000","reason":"\u003cGERRIT_ACCOUNT_1000007\u003e replied on the change","reason_account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}}},"hashtags":["mailsubmitted"],"change_id":"I7cf5d5ef7e2531f397ad97baf4663e3763072f6b","subject":"socket: restore per-connection lport override over global default","status":"MERGED","created":"2026-03-04 12:00:35.000000000","updated":"2026-03-30 11:28:19.000000000","submitted":"2026-03-30 11:28:19.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1555","meta_rev_id":"fa2d4f99a1711da4ba326f7fc5f946e23018b18d","_number":1555,"virtual_id_number":1555,"owner":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-03-04 12:00:36.000000000","updated_by":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-03-04 12:00:36.000000000","updated_by":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-03-10 13:42:28.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"REVIEWER"}],"messages":[{"id":"b2a711593103031a66e0679365a7f9f2fc21f94f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2026-03-04 12:00:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a374671c02f9c94ba70afc6665b9bc25dfea33c8","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-03-10 13:42:28.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"495a63af129f2c411e210e082d975faecafefcfc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2026-03-10 16:19:28.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"a6cb74cb84f173caeb6eb89643cf52679de15d9c","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2026-03-10 16:20:11.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"94e3937d7bcf0f4837c287feeb162db675fda4f0","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-03-16 13:46:30.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"7b84fa7806477cf69d09480d8c3b4a121587e8be","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-18 14:12:57.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":2},{"id":"fa2d4f99a1711da4ba326f7fc5f946e23018b18d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-03-30 11:28:19.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"7ac5f89023b2c2870a210016a862ec042f709bb7","revisions":{"2d65cc89000c6f75d8a06356c767f6091a098a67":{"kind":"REWORK","_number":1,"created":"2026-03-04 12:00:35.000000000","uploader":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/55/1555/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/55/1555/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1555/1 \u0026\u0026 git checkout -b change-1555 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1555/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1555/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1555/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/55/1555/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1555/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9735675529450467ff5ad5e6500caef4d225b17b","subject":"buffer: Clarify usage of char_class"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-03-04 10:54:52.000000000","tz":60},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-03-04 11:42:12.000000000","tz":60},"subject":"socket: restore per-connection lport override over global default","message":"socket: restore per-connection lport override over global default\n\nOpenVPN 2.7.x introduced a regression where --lport specified\ninside a \u003cconnection\u003e block did not override a globally defined\nlocal port. As a result, the socket was bound to the global\ndefault port instead of the per-connection value.\n\nAdjust the socket local_port selection logic to honour\nlocal_port_defined when set for the active connection profile.\n\nThis change restores the documented and previously working\nbehaviour from 2.6.x, where connection-level lport takes\nprecedence over global defaults.\n\nGithub: #995\n\nChange-Id: I7cf5d5ef7e2531f397ad97baf4663e3763072f6b\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"a245f92a379b99d30d45d98ee0fb23c9e0a4a7b1":{"kind":"REWORK","_number":2,"created":"2026-03-10 16:19:28.000000000","uploader":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/55/1555/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/55/1555/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1555/2 \u0026\u0026 git checkout -b change-1555 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1555/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1555/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1555/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/55/1555/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1555/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"66060627a8cf05c8761d75985e76482d20df4f29","subject":"ssl_verify_openssl: Clean up extract_x509_extension"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-03-04 10:54:52.000000000","tz":60},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-03-10 16:06:50.000000000","tz":60},"subject":"socket: restore per-connection lport override over global default","message":"socket: restore per-connection lport override over global default\n\nOpenVPN 2.7.x introduced a regression where --lport specified\ninside a \u003cconnection\u003e block did not override a globally defined\nlocal port. As a result, the socket was bound to the global\ndefault port instead of the per-connection value.\n\nAdjust the socket local_port selection logic to honour\nlocal_port_defined when set for the active connection profile.\n\nThis change restores the documented and previously working\nbehaviour from 2.6.x, where connection-level lport takes\nprecedence over global defaults.\n\nGithub: #995\n\nChange-Id: I7cf5d5ef7e2531f397ad97baf4663e3763072f6b\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"7ac5f89023b2c2870a210016a862ec042f709bb7":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2026-03-30 11:28:19.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/55/1555/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/55/1555/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1555/3 \u0026\u0026 git checkout -b change-1555 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1555/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1555/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1555/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/55/1555/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1555/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"690aace41a68292412da3f313389e79d4a12bfbc","subject":"tests: skip test execution when cross-compiling"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-03-16 13:48:36.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-03-30 11:08:40.000000000","tz":120},"subject":"socket: restore per-connection lport override over global default","message":"socket: restore per-connection lport override over global default\n\nOpenVPN 2.7.x introduced a regression where --lport specified\ninside a \u003cconnection\u003e block did not override a globally defined\nlocal port. As a result, the socket was bound to the global\ndefault port instead of the per-connection value.\n\nAdjust the socket local_port selection logic to honour\nlocal_port_defined when set for the active connection profile.\n\nThis change restores the documented and previously working\nbehaviour from 2.6.x, where connection-level lport takes\nprecedence over global defaults.\n\nGithub: closes OpenVPN/openvpn#995\n\nChange-Id: I7cf5d5ef7e2531f397ad97baf4663e3763072f6b\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\nAcked-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1555\nMessage-Id: \u003c20260316134841.28362-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36164.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}