)]}'
{"src/openvpn/multi.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"5c27d3b7a16f51dbd4a2bddef4e9004deb7b0ca9","unresolved":true,"context_lines":[{"line_number":4106,"context_line":"        }"},{"line_number":4107,"context_line":"    }"},{"line_number":4108,"context_line":""},{"line_number":4109,"context_line":"    if (mi-\u003econtext.c2.tls_multi-\u003epeer_id \u003e m-\u003emax_peerid)"},{"line_number":4110,"context_line":"    {"},{"line_number":4111,"context_line":"        m-\u003emax_peerid \u003d mi-\u003econtext.c2.tls_multi-\u003epeer_id;"},{"line_number":4112,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d4a87d22_1c3297f5","line":4109,"updated":"2026-03-06 11:39:26.000000000","message":"I would suggest moving this code below the ASSERT. In the end it makes no difference. But I think it is easier to read if the code that checks that the loop failed is directly below the loop.\n\nAs an aside I think the ASSERT is a bit unclear already. I think what it actually should check is against MAX_PEER_ID, not max_clients. From this code it is not clear that it assumes that peer_id was initialized to MAX_PEER_ID. So I think it would be better to have an ASSERT at the top of the function that checks that peer_id is indeed MAX_PEER_ID and then an assert below that checks that peer_id is not MAX_PEER_ID. Much clearer. But not directly the job of this patch.","commit_id":"2b44e94b98a7895f2a4646ed1cb10710452b39dc"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"3f153dc654a2513ae6a7eadd689e42369bd306c0","unresolved":false,"context_lines":[{"line_number":4106,"context_line":"        }"},{"line_number":4107,"context_line":"    }"},{"line_number":4108,"context_line":""},{"line_number":4109,"context_line":"    if (mi-\u003econtext.c2.tls_multi-\u003epeer_id \u003e m-\u003emax_peerid)"},{"line_number":4110,"context_line":"    {"},{"line_number":4111,"context_line":"        m-\u003emax_peerid \u003d mi-\u003econtext.c2.tls_multi-\u003epeer_id;"},{"line_number":4112,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"aa64aaec_78ffb9f4","line":4109,"in_reply_to":"54c3fb30_19036b99","updated":"2026-03-06 14:01:48.000000000","message":"Done","commit_id":"2b44e94b98a7895f2a4646ed1cb10710452b39dc"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"05ffb94bcee635584ebb73fdc090183fc6800974","unresolved":true,"context_lines":[{"line_number":4106,"context_line":"        }"},{"line_number":4107,"context_line":"    }"},{"line_number":4108,"context_line":""},{"line_number":4109,"context_line":"    if (mi-\u003econtext.c2.tls_multi-\u003epeer_id \u003e m-\u003emax_peerid)"},{"line_number":4110,"context_line":"    {"},{"line_number":4111,"context_line":"        m-\u003emax_peerid \u003d mi-\u003econtext.c2.tls_multi-\u003epeer_id;"},{"line_number":4112,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"54c3fb30_19036b99","line":4109,"in_reply_to":"d4a87d22_1c3297f5","updated":"2026-03-06 13:36:56.000000000","message":"done","commit_id":"2b44e94b98a7895f2a4646ed1cb10710452b39dc"}],"src/openvpn/multi.h":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"3f153dc654a2513ae6a7eadd689e42369bd306c0","unresolved":true,"context_lines":[{"line_number":163,"context_line":"    struct multi_instance **instances; /**\u003c Array of multi_instances with the size of"},{"line_number":164,"context_line":"                                        *  max_clients.  An instance can be"},{"line_number":165,"context_line":"                                        * accessed using peer-id as an index. */"},{"line_number":166,"context_line":"    uint32_t max_peerid;               /**\u003c currently highest allocated peerid and"},{"line_number":167,"context_line":"                                        * maximum allocated/valid index in"},{"line_number":168,"context_line":"                                        * instances */"},{"line_number":169,"context_line":"    struct hash *hash;                 /**\u003c VPN tunnel instances indexed by real"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"cefa47db_0826c6d4","line":166,"updated":"2026-03-06 14:01:48.000000000","message":"\"highest currently\"","commit_id":"339c2831fd7968f570c25546116d1bca607a6ad1"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"7e323bb6742097f688e960bc8b321b131803f011","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    struct multi_instance **instances; /**\u003c Array of multi_instances with the size of"},{"line_number":164,"context_line":"                                        *  max_clients.  An instance can be"},{"line_number":165,"context_line":"                                        * accessed using peer-id as an index. */"},{"line_number":166,"context_line":"    uint32_t max_peerid;               /**\u003c currently highest allocated peerid and"},{"line_number":167,"context_line":"                                        * maximum allocated/valid index in"},{"line_number":168,"context_line":"                                        * instances */"},{"line_number":169,"context_line":"    struct hash *hash;                 /**\u003c VPN tunnel instances indexed by real"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"6ce2d185_dc6b762e","line":166,"in_reply_to":"cefa47db_0826c6d4","updated":"2026-03-19 11:27:19.000000000","message":"I will update this if I have to update the patch again as this has been already sent out as mail.","commit_id":"339c2831fd7968f570c25546116d1bca607a6ad1"}]}