)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"76a6d8520ae057d5b113c2b63328aef317548fa3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9af37622_762d4dbc","updated":"2026-03-14 17:16:12.000000000","message":"I withdraw my +2 for the time being, because I do not understand why this is needed in the first place - also, the *new* code brings `\"dns_server_%zu_resolve_domain_%d\", i, j` which can\u0027t be right (second `%d`)","commit_id":"df6be08ea0e64b1dd87d67492cc89f34747ecdd8"}],"src/openvpn/dns.c":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"8795b74a563fdc2be5c6e807b37825d58922d730","unresolved":true,"context_lines":[{"line_number":484,"context_line":"    char name[64];"},{"line_number":485,"context_line":"    bool name_ok \u003d false;"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"    if (!j)"},{"line_number":488,"context_line":"    {"},{"line_number":489,"context_line":"        name_ok \u003d checked_snprintf(name, sizeof(name), format, i);"},{"line_number":490,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"fccde101_7d7bf6c3","line":487,"updated":"2026-03-12 08:03:14.000000000","message":"technically this is fine, but it takes me as a reader few more seconds to understand what this check does - I would prefer `if (j \u003d\u003d 0)` here.","commit_id":"79a7a5f43351709d15235388cb2000a159798b80"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"2c181e679686ad41007eb59198f01abae95f202b","unresolved":false,"context_lines":[{"line_number":484,"context_line":"    char name[64];"},{"line_number":485,"context_line":"    bool name_ok \u003d false;"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"    if (!j)"},{"line_number":488,"context_line":"    {"},{"line_number":489,"context_line":"        name_ok \u003d checked_snprintf(name, sizeof(name), format, i);"},{"line_number":490,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"afed0dee_70196530","line":487,"in_reply_to":"fccde101_7d7bf6c3","updated":"2026-03-12 13:26:01.000000000","message":"Done","commit_id":"79a7a5f43351709d15235388cb2000a159798b80"}]}