)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"824b4701f152abd3d09071b2efda49b9ce987892","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2c3b545a_f2828f7a","updated":"2026-03-19 14:41:11.000000000","message":"I\u0027d personally just add a remark in the commit next to 1024 to make it clear that this is the default max-client value, because at first glance it wasn\u0027t obvious to me.\n\nOther than that, the patch looks good!","commit_id":"be9d1d3c47532c70fd2c0209446d2999a1e82ffb"},{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"7ac937fb8376dae747f011a10a80c2fb8c67f2bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"dfa239d7_d5ec229e","updated":"2026-03-19 14:56:38.000000000","message":"Thanks!","commit_id":"ff865d650f47afb9617191ac5aad73cddb218f41"}],"src/openvpn/options.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"3dce09ca84e86018214658d5733c889c0c2439f9","unresolved":true,"context_lines":[{"line_number":850,"context_line":"    o-\u003evlan_accept \u003d VLAN_ALL;"},{"line_number":851,"context_line":"    o-\u003evlan_pvid \u003d 1;"},{"line_number":852,"context_line":"    o-\u003ereal_hash_size \u003d 1024;"},{"line_number":853,"context_line":"    o-\u003evirtual_hash_size \u003d 1024;"},{"line_number":854,"context_line":"    o-\u003en_bcast_buf \u003d 256;"},{"line_number":855,"context_line":"    o-\u003etcp_queue_limit \u003d 64;"},{"line_number":856,"context_line":"    o-\u003emax_clients \u003d 1024;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"7744ca59_c2802330","line":853,"updated":"2026-03-12 11:20:40.000000000","message":"Do we have any justification for 1024 specifically? I.e. any way to say whether 2048 would be better or worse?","commit_id":"0719fb4fc6e4c5a50a29037b9ad9aa9a7fb88241"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"3d5b7ec9011b1d37376ac9868fe93d08c937abc3","unresolved":false,"context_lines":[{"line_number":850,"context_line":"    o-\u003evlan_accept \u003d VLAN_ALL;"},{"line_number":851,"context_line":"    o-\u003evlan_pvid \u003d 1;"},{"line_number":852,"context_line":"    o-\u003ereal_hash_size \u003d 1024;"},{"line_number":853,"context_line":"    o-\u003evirtual_hash_size \u003d 1024;"},{"line_number":854,"context_line":"    o-\u003en_bcast_buf \u003d 256;"},{"line_number":855,"context_line":"    o-\u003etcp_queue_limit \u003d 64;"},{"line_number":856,"context_line":"    o-\u003emax_clients \u003d 1024;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"0f7cef1a_f02730ea","line":853,"in_reply_to":"7744ca59_c2802330","updated":"2026-03-12 13:12:32.000000000","message":"Done","commit_id":"0719fb4fc6e4c5a50a29037b9ad9aa9a7fb88241"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"5f4f633fdfaa877521741dc54af8ec8af3a76f21","unresolved":true,"context_lines":[{"line_number":850,"context_line":"    o-\u003evlan_accept \u003d VLAN_ALL;"},{"line_number":851,"context_line":"    o-\u003evlan_pvid \u003d 1;"},{"line_number":852,"context_line":"    o-\u003ereal_hash_size \u003d 1024;"},{"line_number":853,"context_line":"    o-\u003evirtual_hash_size \u003d 1024;"},{"line_number":854,"context_line":"    o-\u003en_bcast_buf \u003d 256;"},{"line_number":855,"context_line":"    o-\u003etcp_queue_limit \u003d 64;"},{"line_number":856,"context_line":"    o-\u003emax_clients \u003d 1024;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"d29fabc9_bfbab811","line":853,"in_reply_to":"7744ca59_c2802330","updated":"2026-03-12 15:27:13.000000000","message":"Not. Not really. Should I maybe change the default to be 4 * max_clients?","commit_id":"0719fb4fc6e4c5a50a29037b9ad9aa9a7fb88241"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"84dbdcc0c7b6a369f83d72bd9ec5ab56380b6b55","unresolved":false,"context_lines":[{"line_number":850,"context_line":"    o-\u003evlan_accept \u003d VLAN_ALL;"},{"line_number":851,"context_line":"    o-\u003evlan_pvid \u003d 1;"},{"line_number":852,"context_line":"    o-\u003ereal_hash_size \u003d 1024;"},{"line_number":853,"context_line":"    o-\u003evirtual_hash_size \u003d 1024;"},{"line_number":854,"context_line":"    o-\u003en_bcast_buf \u003d 256;"},{"line_number":855,"context_line":"    o-\u003etcp_queue_limit \u003d 64;"},{"line_number":856,"context_line":"    o-\u003emax_clients \u003d 1024;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"7accb437_15a12c0f","line":853,"in_reply_to":"d29fabc9_bfbab811","updated":"2026-03-16 16:03:11.000000000","message":"Done","commit_id":"0719fb4fc6e4c5a50a29037b9ad9aa9a7fb88241"}]}
